Re: [PATCHv7 04/15] HID: add HDMI CEC specific keycodes
On Tue, Jun 30, 2015 at 09:36:49AM +0200, Hans Verkuil wrote: > On 06/29/15 21:25, Dmitry Torokhov wrote: > > On Mon, Jun 29, 2015 at 12:14:49PM +0200, Hans Verkuil wrote: > >> From: Kamil Debski > >> > >> Add HDMI CEC specific keycodes to the keycodes definition. > >> > >> Signed-off-by: Kamil Debski > >> Signed-off-by: Hans Verkuil > > > > Could you please describe the intended use for these keycodes for people > > who do not live and breathe CEC specs? > > Do you want this as comments in the patch or as the commit description? In the patch would be preferable. Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCHv7 04/15] HID: add HDMI CEC specific keycodes
On 06/29/15 21:25, Dmitry Torokhov wrote:
> On Mon, Jun 29, 2015 at 12:14:49PM +0200, Hans Verkuil wrote:
>> From: Kamil Debski
>>
>> Add HDMI CEC specific keycodes to the keycodes definition.
>>
>> Signed-off-by: Kamil Debski
>> Signed-off-by: Hans Verkuil
>
> Could you please describe the intended use for these keycodes for people
> who do not live and breathe CEC specs?
Do you want this as comments in the patch or as the commit description?
I realized that this patch needs to be updated anyway since there are a few
keys missing that were added for CEC 2.0.
Regards,
Hans
>
> Thanks!
>
>> ---
>> include/uapi/linux/input.h | 12
>> 1 file changed, 12 insertions(+)
>>
>> diff --git a/include/uapi/linux/input.h b/include/uapi/linux/input.h
>> index 731417c..7430a3f 100644
>> --- a/include/uapi/linux/input.h
>> +++ b/include/uapi/linux/input.h
>> @@ -752,6 +752,18 @@ struct input_keymap_entry {
>> #define KEY_KBDINPUTASSIST_ACCEPT 0x264
>> #define KEY_KBDINPUTASSIST_CANCEL 0x265
>>
>> +#define KEY_RIGHT_UP0x266
>> +#define KEY_RIGHT_DOWN 0x267
>> +#define KEY_LEFT_UP 0x268
>> +#define KEY_LEFT_DOWN 0x269
>> +
>> +#define KEY_NEXT_FAVORITE 0x270
>> +#define KEY_STOP_RECORD 0x271
>> +#define KEY_PAUSE_RECORD0x272
>> +#define KEY_VOD 0x273
>> +#define KEY_UNMUTE 0x274
>> +#define KEY_DVB 0x275
>> +
>> #define BTN_TRIGGER_HAPPY 0x2c0
>> #define BTN_TRIGGER_HAPPY1 0x2c0
>> #define BTN_TRIGGER_HAPPY2 0x2c1
>> --
>> 2.1.4
>>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCHv7 04/15] HID: add HDMI CEC specific keycodes
On Mon, Jun 29, 2015 at 12:14:49PM +0200, Hans Verkuil wrote:
> From: Kamil Debski
>
> Add HDMI CEC specific keycodes to the keycodes definition.
>
> Signed-off-by: Kamil Debski
> Signed-off-by: Hans Verkuil
Could you please describe the intended use for these keycodes for people
who do not live and breathe CEC specs?
Thanks!
> ---
> include/uapi/linux/input.h | 12
> 1 file changed, 12 insertions(+)
>
> diff --git a/include/uapi/linux/input.h b/include/uapi/linux/input.h
> index 731417c..7430a3f 100644
> --- a/include/uapi/linux/input.h
> +++ b/include/uapi/linux/input.h
> @@ -752,6 +752,18 @@ struct input_keymap_entry {
> #define KEY_KBDINPUTASSIST_ACCEPT0x264
> #define KEY_KBDINPUTASSIST_CANCEL0x265
>
> +#define KEY_RIGHT_UP 0x266
> +#define KEY_RIGHT_DOWN 0x267
> +#define KEY_LEFT_UP 0x268
> +#define KEY_LEFT_DOWN0x269
> +
> +#define KEY_NEXT_FAVORITE0x270
> +#define KEY_STOP_RECORD 0x271
> +#define KEY_PAUSE_RECORD 0x272
> +#define KEY_VOD 0x273
> +#define KEY_UNMUTE 0x274
> +#define KEY_DVB 0x275
> +
> #define BTN_TRIGGER_HAPPY0x2c0
> #define BTN_TRIGGER_HAPPY1 0x2c0
> #define BTN_TRIGGER_HAPPY2 0x2c1
> --
> 2.1.4
>
--
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCHv7 04/15] HID: add HDMI CEC specific keycodes
From: Kamil Debski
Add HDMI CEC specific keycodes to the keycodes definition.
Signed-off-by: Kamil Debski
Signed-off-by: Hans Verkuil
---
include/uapi/linux/input.h | 12
1 file changed, 12 insertions(+)
diff --git a/include/uapi/linux/input.h b/include/uapi/linux/input.h
index 731417c..7430a3f 100644
--- a/include/uapi/linux/input.h
+++ b/include/uapi/linux/input.h
@@ -752,6 +752,18 @@ struct input_keymap_entry {
#define KEY_KBDINPUTASSIST_ACCEPT 0x264
#define KEY_KBDINPUTASSIST_CANCEL 0x265
+#define KEY_RIGHT_UP 0x266
+#define KEY_RIGHT_DOWN 0x267
+#define KEY_LEFT_UP0x268
+#define KEY_LEFT_DOWN 0x269
+
+#define KEY_NEXT_FAVORITE 0x270
+#define KEY_STOP_RECORD0x271
+#define KEY_PAUSE_RECORD 0x272
+#define KEY_VOD0x273
+#define KEY_UNMUTE 0x274
+#define KEY_DVB0x275
+
#define BTN_TRIGGER_HAPPY 0x2c0
#define BTN_TRIGGER_HAPPY1 0x2c0
#define BTN_TRIGGER_HAPPY2 0x2c1
--
2.1.4
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
