Re: [RFC PATCH 0/3] Fix power domains handling on exynos542x
Hello Kukjin, On 02/05/2015 03:45 PM, Javier Martinez Canillas wrote: Hello Andrzej, Thanks a lot for finally finding what was causing the HDMI issue. On 02/05/2015 01:35 PM, Andrzej Hajda wrote: Hi, Exynos chipsets since 542x have asynchronous bridges connecting different IPs. These bridges should be operational during power domain switching, ie associated clocks cannot be gated. This patchset adds binding to provide such clocks per power domain and adds code which enables them during domain on/off operation. This patchset fixes power domain issues with disp1 domain and HDMI (some of them) on Odroid XU3: - disp1 power domain can be turned off, - no more imprecise external abort faults. The patchset is based on '[PATCH v5 0/9] Enable HDMI support on Exynos platforms' [1]. It also depends on '[PATCH 0/2] Add HDMI support for Exynos5420 platform' [2]. It was successfully tested on OdroidXU3. [1]: http://permalink.gmane.org/gmane.linux.kernel.samsung-soc/42743 Your patches looks good to me so please feel free to add: Reviewed-by: Javier Martinez Canillas javier.marti...@collabora.co.uk I also tested on an Exynos5420 Peach Pit Chromebook and both the Power domain power-domain disable failed message and the system crash are gone. Tested-by: Javier Martinez Canillas javier.marti...@collabora.co.uk Best regards, Javier [2]: https://lkml.org/lkml/2015/1/20/235 Any comments about this series? It fixes system hangs on Exynos 5420/5422/5800 boards and has been in the list for a while. Please keep in mind that a v2 of patch 3/3 was posted [0]. Best regards, Javier [0]: https://lkml.org/lkml/2015/2/6/138 -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RFC PATCH 0/3] Fix power domains handling on exynos542x
Hello Joonyoung, On 02/06/2015 06:27 AM, Joonyoung Shim wrote: On 02/05/2015 11:45 PM, Javier Martinez Canillas wrote: I also tested on an Exynos5420 Peach Pit Chromebook and both the Power domain power-domain disable failed message and the system crash are gone. Really gone out Power domain power-domain disable failed message? Still i get the message from second try, # modetest -M exynos -s 23@21:1920x1080 setting mode 1920x1080@XR24 on connectors 23, crtc 21 # modetest -M exynos -s 23@21:1920x1080 setting mode 1920x1080@XR24 on connectors 23, crtc 21 [ 39.608881] Power domain power-domain disable failed # modetest -M exynos -s 23@21:1920x1080 setting mode 1920x1080@XR24 on connectors 23, crtc 21 [ 42.827637] Power domain power-domain disable failed ... You are right, I tested that if I execute: # for val in 1 0; do echo $val /sys/class/drm/card0/device/graphics/fb0/blank; done many times I see the Power domain power-domain disable failed message again and there is no output in the HDMI display when dpms on. But even in that case, the imprecise external abort does not happen when the exynos_mixer driver tries to access the mixer registers and the system does not crash anymore. So I think that Andrzej's patches are at least a step in the right direction. Best regards, Javier -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RFC PATCH 0/3] Fix power domains handling on exynos542x
Hi, On 02/05/2015 11:45 PM, Javier Martinez Canillas wrote: Hello Andrzej, Thanks a lot for finally finding what was causing the HDMI issue. On 02/05/2015 01:35 PM, Andrzej Hajda wrote: Hi, Exynos chipsets since 542x have asynchronous bridges connecting different IPs. These bridges should be operational during power domain switching, ie associated clocks cannot be gated. This patchset adds binding to provide such clocks per power domain and adds code which enables them during domain on/off operation. This patchset fixes power domain issues with disp1 domain and HDMI (some of them) on Odroid XU3: - disp1 power domain can be turned off, - no more imprecise external abort faults. The patchset is based on '[PATCH v5 0/9] Enable HDMI support on Exynos platforms' [1]. It also depends on '[PATCH 0/2] Add HDMI support for Exynos5420 platform' [2]. It was successfully tested on OdroidXU3. [1]: http://permalink.gmane.org/gmane.linux.kernel.samsung-soc/42743 Your patches looks good to me so please feel free to add: Reviewed-by: Javier Martinez Canillas javier.marti...@collabora.co.uk I also tested on an Exynos5420 Peach Pit Chromebook and both the Power domain power-domain disable failed message and the system crash are gone. Really gone out Power domain power-domain disable failed message? Still i get the message from second try, # modetest -M exynos -s 23@21:1920x1080 setting mode 1920x1080@XR24 on connectors 23, crtc 21 # modetest -M exynos -s 23@21:1920x1080 setting mode 1920x1080@XR24 on connectors 23, crtc 21 [ 39.608881] Power domain power-domain disable failed # modetest -M exynos -s 23@21:1920x1080 setting mode 1920x1080@XR24 on connectors 23, crtc 21 [ 42.827637] Power domain power-domain disable failed ... Thanks. Tested-by: Javier Martinez Canillas javier.marti...@collabora.co.uk Best regards, Javier [2]: https://lkml.org/lkml/2015/1/20/235 -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RFC PATCH 0/3] Fix power domains handling on exynos542x
Hello Andrzej, Thanks a lot for finally finding what was causing the HDMI issue. On 02/05/2015 01:35 PM, Andrzej Hajda wrote: Hi, Exynos chipsets since 542x have asynchronous bridges connecting different IPs. These bridges should be operational during power domain switching, ie associated clocks cannot be gated. This patchset adds binding to provide such clocks per power domain and adds code which enables them during domain on/off operation. This patchset fixes power domain issues with disp1 domain and HDMI (some of them) on Odroid XU3: - disp1 power domain can be turned off, - no more imprecise external abort faults. The patchset is based on '[PATCH v5 0/9] Enable HDMI support on Exynos platforms' [1]. It also depends on '[PATCH 0/2] Add HDMI support for Exynos5420 platform' [2]. It was successfully tested on OdroidXU3. [1]: http://permalink.gmane.org/gmane.linux.kernel.samsung-soc/42743 Your patches looks good to me so please feel free to add: Reviewed-by: Javier Martinez Canillas javier.marti...@collabora.co.uk I also tested on an Exynos5420 Peach Pit Chromebook and both the Power domain power-domain disable failed message and the system crash are gone. Tested-by: Javier Martinez Canillas javier.marti...@collabora.co.uk Best regards, Javier [2]: https://lkml.org/lkml/2015/1/20/235 -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[RFC PATCH 0/3] Fix power domains handling on exynos542x
Hi, Exynos chipsets since 542x have asynchronous bridges connecting different IPs. These bridges should be operational during power domain switching, ie associated clocks cannot be gated. This patchset adds binding to provide such clocks per power domain and adds code which enables them during domain on/off operation. This patchset fixes power domain issues with disp1 domain and HDMI (some of them) on Odroid XU3: - disp1 power domain can be turned off, - no more imprecise external abort faults. The patchset is based on '[PATCH v5 0/9] Enable HDMI support on Exynos platforms' [1]. It was successfully tested on OdroidXU3. [1]: http://permalink.gmane.org/gmane.linux.kernel.samsung-soc/42743 Regards Andrzej Andrzej Hajda (3): arm/exynos: add asynchronous bridge clock bindings arm/exynos/pm_domains: add support for async-bridge clocks ARM: dts: exynos5420: add async-bridge clock to disp1 power domain .../bindings/arm/exynos/power_domain.txt | 3 +++ arch/arm/boot/dts/exynos5420.dtsi | 6 +++-- arch/arm/mach-exynos/pm_domains.c | 27 ++ 3 files changed, 30 insertions(+), 6 deletions(-) -- 1.9.1 -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
