Re: [alsa-devel] [PATCH 2/3] ASoC: samsung: Document Trats2 audio subsystem bindings

2015-01-12 Thread Inha Song 
Hi Mark,

Thank you for your feedback and sorry for late response.

I think, I should remove clock settings in machine driver.
If the clock settings are necessary, I will add assigned-clocks nodes
in trats2 sound DT like odroid board.

Best Regards,
Inha Song.

 On Mon, Jan 05, 2015 at 08:25:16PM +0900, Inha Song wrote:
 
  + - clocks : Reference to the codec master clock
  + - clock-names : The clock should be named mclk
 
 This should be done in the CODEC driver, not in the machine driver - the
 CODEC always needs the clock, it's not something specific to this
 machine.  Even if we decide that for Linux the best thing to do is to
 manage the clock in the machine driver it should be described in the DT
 as being attached to the CODEC.
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[alsa-devel] [PATCH 2/3] ASoC: samsung: Document Trats2 audio subsystem bindings

2015-01-05 Thread Inha Song 
This patch add Trats2 audio subsystem bindings document.

Signed-off-by: Inha Song ideal.s...@samsung.com
---
 .../bindings/sound/samsung,trats2-wm1811.txt   | 31 ++
 1 file changed, 31 insertions(+)
 create mode 100644 
Documentation/devicetree/bindings/sound/samsung,trats2-wm1811.txt

diff --git a/Documentation/devicetree/bindings/sound/samsung,trats2-wm1811.txt 
b/Documentation/devicetree/bindings/sound/samsung,trats2-wm1811.txt
new file mode 100644
index 000..9d4d3f1
--- /dev/null
+++ b/Documentation/devicetree/bindings/sound/samsung,trats2-wm1811.txt
@@ -0,0 +1,31 @@
+Samsung Exynos Trats2 audio with WM1811 codec
+
+Required properties:
+
+ - compatible : Must be samsung,trats2-audio
+
+ - clocks : Reference to the codec master clock
+ - clock-names : The clock should be named mclk
+
+ - samsung,i2s-controller : The phandle of the I2S controller
+
+ - samsung,model : The user visible name of this sound
+
+ - samsung,audio-routing : A list of the connections between audio
+   components. each entry is a pair of strings, the first being the
+   connection's sink, the second being the connection's source
+
+Example:
+
+sound {
+   compatible = samsung,trats2-audio;
+   clocks = pmu_system_controller 0;
+   clock-names = mclk;
+   samsung,i2s-controller = i2s0;
+   samsung,model = wm1811;
+   samsung,audio-routing =
+   SPK, SPKOUTLN,
+   SPK, SPKOUTLP,
+   SPK, SPKOUTRN,
+   SPK, SPKOUTRP;
+};
-- 
2.0.0.390.gcb682f8

--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [alsa-devel] [PATCH 2/3] ASoC: samsung: Document Trats2 audio subsystem bindings

2015-01-05 Thread Mark Brown 
On Mon, Jan 05, 2015 at 08:25:16PM +0900, Inha Song wrote:

 + - clocks : Reference to the codec master clock
 + - clock-names : The clock should be named mclk

This should be done in the CODEC driver, not in the machine driver - the
CODEC always needs the clock, it's not something specific to this
machine.  Even if we decide that for Linux the best thing to do is to
manage the clock in the machine driver it should be described in the DT
as being attached to the CODEC.


signature.asc
Description: Digital signature