Re: [patch] pinctrl: s3c24xx: off by one in s3c24xx_eint_init()

[Linus Walleij]

On Tue, Aug 27, 2013 at 3:11 AM, Dan Carpenter dan.carpen...@oracle.com wrote:

 If irq == NUM_EINT then it writes one space beyond the end of the
 eint_data-domains[] array.

 Signed-off-by: Dan Carpenter dan.carpen...@oracle.com

Patch applied with Heiko's ACK.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [patch] pinctrl: s3c24xx: off by one in s3c24xx_eint_init()

[Heiko Stübner]

Am Dienstag, 27. August 2013, 03:11:26 schrieb Dan Carpenter:
 If irq == NUM_EINT then it writes one space beyond the end of the
 eint_data-domains[] array.

Thanks for catching this.


 Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
Reviewed-by: Heiko Stuebner he...@sntech.de


 
 diff --git a/drivers/pinctrl/pinctrl-s3c24xx.c
 b/drivers/pinctrl/pinctrl-s3c24xx.c index 24446da..ad3eaad 100644
 --- a/drivers/pinctrl/pinctrl-s3c24xx.c
 +++ b/drivers/pinctrl/pinctrl-s3c24xx.c
 @@ -549,7 +549,7 @@ static int s3c24xx_eint_init(struct
 samsung_pinctrl_drv_data *d) irq = bank-eint_offset;
   mask = bank-eint_mask;
   for (pin = 0; mask; ++pin, mask = 1) {
 - if (irq  NUM_EINT)
 + if (irq = NUM_EINT)
   break;
   if (!(mask  1))
   continue;
 --
 To unsubscribe from this list: send the line unsubscribe
 linux-samsung-soc in the body of a message to majord...@vger.kernel.org
 More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[patch] pinctrl: s3c24xx: off by one in s3c24xx_eint_init()

[Dan Carpenter]

If irq == NUM_EINT then it writes one space beyond the end of the
eint_data-domains[] array.

Signed-off-by: Dan Carpenter dan.carpen...@oracle.com

diff --git a/drivers/pinctrl/pinctrl-s3c24xx.c 
b/drivers/pinctrl/pinctrl-s3c24xx.c
index 24446da..ad3eaad 100644
--- a/drivers/pinctrl/pinctrl-s3c24xx.c
+++ b/drivers/pinctrl/pinctrl-s3c24xx.c
@@ -549,7 +549,7 @@ static int s3c24xx_eint_init(struct 
samsung_pinctrl_drv_data *d)
irq = bank-eint_offset;
mask = bank-eint_mask;
for (pin = 0; mask; ++pin, mask = 1) {
-   if (irq  NUM_EINT)
+   if (irq = NUM_EINT)
break;
if (!(mask  1))
continue;
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html