Re: [v3] libdrm: improvements to userspace exynos component
On 2015-03-11 19:56, Emil Velikov wrote: Tobias, Can you please re-spin the remaining patches on top of master, and address Inki's comment. Also please add Inki's and Joonyoung Shim's tags. Done. I hope I did the tagging correctly. With best wishes, Tobias -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [v3] libdrm: improvements to userspace exynos component
On 11 March 2015 at 13:31, Inki Dae inki@samsung.com wrote: Hi, On 2015년 02월 24일 23:20, Tobias Jakobi wrote: Hello, here are some miscellaneous improvements (small features, bugfixes, spelling fixes, etc.) for the exynos component of libdrm. The general idea is to let userspace use the G2D engine functionality more efficiently. If someone is interested in an application that actually makes use of this, the RetroArch frontend has a custom video backend: https://github.com/libretro/RetroArch/blob/master/gfx/drivers/exynos_gfx.c Please review and let me know what I can improve. v2: - Mention value of G2D scaling normalization factor (02/15). - Moved patch (04/15) description from commit message to source itself, like suggested by Joonyoung Shim. v3: I integrated the suggestions by Emil Velikov and added two additional patches to the series. One doing the header cleanup that Emil point out, another one just a trivial whitespace thing. I'm resending the whole series, since number of patches and order changed. Wohoo Inki's back ! Looks good to me except for 14/17 patch. For the patch, I commented already, which may be very trivial but should be fixed correctly. I think Emil could fix it before merging it. To Emil, Could you please fix the patch 14/17 like below?, before - /* Global Alpha : Set by ALPHA_REG(0x618) */ + /* Global Color : Set by ALPHA_REG(0x618) */ after - /* Global Alpha : Set by ALPHA_REG(0x618) */ + /* Global Color and Alpha: Set by ALPHA_REG(0x618) */ If you don't mind I'll leave this to Tobias as a follow up patch, as the one you've looked at is already in master. for all patches - 1 though 17, Signed-off-by : Inki Dae inki@samsung.com I believe you mean Reviewed-by, isn't that right ? Tobias, Can you please re-spin the remaining patches on top of master, and address Inki's comment. Also please add Inki's and Joonyoung Shim's tags. Thanks Emil -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [v3] libdrm: improvements to userspace exynos component
Hi, On 2015년 02월 24일 23:20, Tobias Jakobi wrote: Hello, here are some miscellaneous improvements (small features, bugfixes, spelling fixes, etc.) for the exynos component of libdrm. The general idea is to let userspace use the G2D engine functionality more efficiently. If someone is interested in an application that actually makes use of this, the RetroArch frontend has a custom video backend: https://github.com/libretro/RetroArch/blob/master/gfx/drivers/exynos_gfx.c Please review and let me know what I can improve. v2: - Mention value of G2D scaling normalization factor (02/15). - Moved patch (04/15) description from commit message to source itself, like suggested by Joonyoung Shim. v3: I integrated the suggestions by Emil Velikov and added two additional patches to the series. One doing the header cleanup that Emil point out, another one just a trivial whitespace thing. I'm resending the whole series, since number of patches and order changed. Looks good to me except for 14/17 patch. For the patch, I commented already, which may be very trivial but should be fixed correctly. I think Emil could fix it before merging it. To Emil, Could you please fix the patch 14/17 like below?, before - /* Global Alpha : Set by ALPHA_REG(0x618) */ + /* Global Color : Set by ALPHA_REG(0x618) */ after - /* Global Alpha : Set by ALPHA_REG(0x618) */ + /* Global Color and Alpha: Set by ALPHA_REG(0x618) */ for all patches - 1 though 17, Signed-off-by : Inki Dae inki@samsung.com Thanks, Inki Dae With best wishes, Tobias -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [v3] libdrm: improvements to userspace exynos component
Hi Tobias and Emil On 2015년 03월 11일 04:36, Emil Velikov wrote: On 08/03/15 23:12, Tobias Jakobi wrote: Hello Emil, Emil Velikov wrote: I'm planning to push the above mentioned patches around lunchtime this Tuesday. If anyone has objections please speak up. I doubt you're going to hear anything from Inki Dae. Despite that it might sound a bit rude, I sincerely hope that you're wrong on this one. I'm would assume that the lack of reply from Inki was due to being him busy, rather than ignoring you. I was busy so I didn't care of it. Sorry for this. Anyway, thanks for considering to merge this, even though it lacks the review of the exynos-drm maintainer. At least this gives me confidence to continue to work on this (I also want to expose async g2d operation to userspace). Glad that you're still planning to work on this. Ideally the Exynos/Samsung guys will take a look at the rest of your patches which require someone with greater knowledge of the hardware than me :-) Right. We will review this patch and reply at least until tomorrow. Thanks, Inki Dae Cheers, Emil -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [v3] libdrm: improvements to userspace exynos component
On 08/03/15 23:12, Tobias Jakobi wrote: Hello Emil, Emil Velikov wrote: I'm planning to push the above mentioned patches around lunchtime this Tuesday. If anyone has objections please speak up. I doubt you're going to hear anything from Inki Dae. Despite that it might sound a bit rude, I sincerely hope that you're wrong on this one. I'm would assume that the lack of reply from Inki was due to being him busy, rather than ignoring you. Anyway, thanks for considering to merge this, even though it lacks the review of the exynos-drm maintainer. At least this gives me confidence to continue to work on this (I also want to expose async g2d operation to userspace). Glad that you're still planning to work on this. Ideally the Exynos/Samsung guys will take a look at the rest of your patches which require someone with greater knowledge of the hardware than me :-) Cheers, Emil -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [v3] libdrm: improvements to userspace exynos component
Hello Emil, Emil Velikov wrote: I'm planning to push the above mentioned patches around lunchtime this Tuesday. If anyone has objections please speak up. I doubt you're going to hear anything from Inki Dae. I've contacted him a few times with questions when I wrote the series, but never heard anything back from him. Anyway, thanks for considering to merge this, even though it lacks the review of the exynos-drm maintainer. At least this gives me confidence to continue to work on this (I also want to expose async g2d operation to userspace). With best wishes, Tobias -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [v3] libdrm: improvements to userspace exynos component
On 25 February 2015 at 15:54, Emil Velikov emil.l.veli...@gmail.com wrote: On 24 February 2015 at 14:20, Tobias Jakobi tjak...@math.uni-bielefeld.de wrote: Hello, here are some miscellaneous improvements (small features, bugfixes, spelling fixes, etc.) for the exynos component of libdrm. The general idea is to let userspace use the G2D engine functionality more efficiently. If someone is interested in an application that actually makes use of this, the RetroArch frontend has a custom video backend: https://github.com/libretro/RetroArch/blob/master/gfx/drivers/exynos_gfx.c Please review and let me know what I can improve. v2: - Mention value of G2D scaling normalization factor (02/15). - Moved patch (04/15) description from commit message to source itself, like suggested by Joonyoung Shim. v3: I integrated the suggestions by Emil Velikov and added two additional patches to the series. One doing the header cleanup that Emil point out, another one just a trivial whitespace thing. I'm resending the whole series, since number of patches and order changed. Thanks for the update. For the future please add the tags (tested-by,etc.) when resending patches. Don't worry about these I'll add them before pushing. The two extra patches look good imho. Inki, This cleanup series has been around for a little while now. v3 can be found at http://lists.freedesktop.org/archives/dri-devel/2015-February/078111.html Do you mind if we apply the trivial and tested* patches within the next week or so ? The more serious patches hw specific, etc are lacking preview and can be committed at a later stage. Thanks Emil [*] Patches 2-4, 6, 8, 10, 12, 14-17, out of which Joonyoung Shim has tested all but 12 and 17. I'm planning to push the above mentioned patches around lunchtime this Tuesday. If anyone has objections please speak up. -Emil -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [v3] libdrm: improvements to userspace exynos component
On 24 February 2015 at 14:20, Tobias Jakobi tjak...@math.uni-bielefeld.de wrote: Hello, here are some miscellaneous improvements (small features, bugfixes, spelling fixes, etc.) for the exynos component of libdrm. The general idea is to let userspace use the G2D engine functionality more efficiently. If someone is interested in an application that actually makes use of this, the RetroArch frontend has a custom video backend: https://github.com/libretro/RetroArch/blob/master/gfx/drivers/exynos_gfx.c Please review and let me know what I can improve. v2: - Mention value of G2D scaling normalization factor (02/15). - Moved patch (04/15) description from commit message to source itself, like suggested by Joonyoung Shim. v3: I integrated the suggestions by Emil Velikov and added two additional patches to the series. One doing the header cleanup that Emil point out, another one just a trivial whitespace thing. I'm resending the whole series, since number of patches and order changed. Thanks for the update. For the future please add the tags (tested-by,etc.) when resending patches. Don't worry about these I'll add them before pushing. The two extra patches look good imho. Inki, This cleanup series has been around for a little while now. v3 can be found at http://lists.freedesktop.org/archives/dri-devel/2015-February/078111.html Do you mind if we apply the trivial and tested* patches within the next week or so ? The more serious patches hw specific, etc are lacking preview and can be committed at a later stage. Thanks Emil [*] Patches 2-4, 6, 8, 10, 12, 14-17, out of which Joonyoung Shim has tested all but 12 and 17. -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[v3] libdrm: improvements to userspace exynos component
Hello, here are some miscellaneous improvements (small features, bugfixes, spelling fixes, etc.) for the exynos component of libdrm. The general idea is to let userspace use the G2D engine functionality more efficiently. If someone is interested in an application that actually makes use of this, the RetroArch frontend has a custom video backend: https://github.com/libretro/RetroArch/blob/master/gfx/drivers/exynos_gfx.c Please review and let me know what I can improve. v2: - Mention value of G2D scaling normalization factor (02/15). - Moved patch (04/15) description from commit message to source itself, like suggested by Joonyoung Shim. v3: I integrated the suggestions by Emil Velikov and added two additional patches to the series. One doing the header cleanup that Emil point out, another one just a trivial whitespace thing. I'm resending the whole series, since number of patches and order changed. With best wishes, Tobias -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
