RE: [alsa-devel] [PATCH 1/2] ASOC: SAMSUNG: Add DT support for i2s

2012-08-01 Thread Sangbeom Kim
Hi,
On Wednesday, July 25, 2012 9:09 PM, Padmavathi Venna wrote:

 Add support for device based discovery.
 
Currently, I'm reviewing your patch set.
Your patch can support device tree for Samsung's i2s.
But I wonder that Your patch can support non-dt too,
So, Please test your patch on non-dt environment.
It looks unclear handling of clock source.
After code review, I will give you more detail comments,

Thanks,
Sangbeom.

--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [alsa-devel] [PATCH 1/2] ASOC: SAMSUNG: Add DT support for i2s

2012-08-01 Thread Padma Venkat
Hi,
On Wed, Aug 1, 2012 at 1:59 PM, Sangbeom Kim sbki...@samsung.com wrote:
 Hi,
 On Wednesday, July 25, 2012 9:09 PM, Padmavathi Venna wrote:

 Add support for device based discovery.

 Currently, I'm reviewing your patch set.
 Your patch can support device tree for Samsung's i2s.
 But I wonder that Your patch can support non-dt too,
 So, Please test your patch on non-dt environment.
 It looks unclear handling of clock source.
 After code review, I will give you more detail comments,
Okey. I will test these patches in non-dt environment.

 Thanks,
 Sangbeom.

 --
 To unsubscribe from this list: send the line unsubscribe linux-samsung-soc 
 in
 the body of a message to majord...@vger.kernel.org
 More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html