RE: [PATCH 0/2] ARM: S3C64xx: cpuidle cleanups
Daniel Lezcano wrote: These couple of patches use the new cpuidle core api to refactor some part of the code. The first one declares the states directly in the driver declaration and the second one use the timekeeping flag to let the cpuidle core to compute the idle time. Basically, looks ok to me. I don't have this board, I was not able to test these patches. Mark, could you please check this patches on your board? Now, my smdk6410 has some problem to test this :( Thanks. Best regards, Kgene. -- Kukjin Kim kgene@samsung.com, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. Daniel Lezcano (2): ARM: s3c64xx: cpuidle - declare the states with the new api ARM: s3c64xx: cpuidle - use timekeeping wrapper arch/arm/mach-s3c64xx/cpuidle.c | 45 +-- 1 files changed, 15 insertions(+), 30 deletions(-) -- 1.7.5.4 -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/2] ARM: S3C64xx: cpuidle cleanups
Am Montag, 14. Mai 2012, 01:51:00 schrieb Daniel Lezcano: On 05/09/2012 04:08 PM, Daniel Lezcano wrote: These couple of patches use the new cpuidle core api to refactor some part of the code. The first one declares the states directly in the driver declaration and the second one use the timekeeping flag to let the cpuidle core to compute the idle time. I don't have this board, I was not able to test these patches. Daniel Lezcano (2): ARM: s3c64xx: cpuidle - declare the states with the new api ARM: s3c64xx: cpuidle - use timekeeping wrapper Are these patches ok for inclusion ? you might want to include the maintainer Kukjin Kim kgene@samsung.com and the samsung list linux-samsung-soc@vger.kernel.org into your recipients Heiko -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/2] ARM: S3C64xx: cpuidle cleanups
On Mon, May 14, 2012 at 10:52:46AM +0200, Heiko St??bner wrote: Am Montag, 14. Mai 2012, 01:51:00 schrieb Daniel Lezcano: On 05/09/2012 04:08 PM, Daniel Lezcano wrote: Are these patches ok for inclusion ? you might want to include the maintainer Kukjin Kim kgene@samsung.com and the samsung list linux-samsung-soc@vger.kernel.org into your recipients Also the original author (me). -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/2] ARM: S3C64xx: cpuidle cleanups
On 05/14/2012 10:57 AM, Mark Brown wrote: On Mon, May 14, 2012 at 10:52:46AM +0200, Heiko St??bner wrote: Am Montag, 14. Mai 2012, 01:51:00 schrieb Daniel Lezcano: On 05/09/2012 04:08 PM, Daniel Lezcano wrote: Are these patches ok for inclusion ? you might want to include the maintainer Kukjin Kimkgene@samsung.com and the samsung list linux-samsung-soc@vger.kernel.org into your recipients Also the original author (me). Oh, ok. I thought I did it, sorry. -- Daniel -- http://www.linaro.org/ Linaro.org │ Open source software for ARM SoCs Follow Linaro: http://www.facebook.com/pages/Linaro Facebook | http://twitter.com/#!/linaroorg Twitter | http://www.linaro.org/linaro-blog/ Blog -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/2] ARM: S3C64xx: cpuidle cleanups
On 05/14/2012 10:57 AM, Mark Brown wrote: On Mon, May 14, 2012 at 10:52:46AM +0200, Heiko St??bner wrote: Am Montag, 14. Mai 2012, 01:51:00 schrieb Daniel Lezcano: On 05/09/2012 04:08 PM, Daniel Lezcano wrote: Are these patches ok for inclusion ? you might want to include the maintainer Kukjin Kimkgene@samsung.com and the samsung list linux-samsung-soc@vger.kernel.org into your recipients Also the original author (me). Mark, I noticed you are not in the cpuidle.c header file neither in the MAINTAINERS entry for the s3c64xx. Just FYI. Thanks -- Daniel -- http://www.linaro.org/ Linaro.org │ Open source software for ARM SoCs Follow Linaro:http://www.facebook.com/pages/Linaro Facebook | http://twitter.com/#!/linaroorg Twitter | http://www.linaro.org/linaro-blog/ Blog -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/2] ARM: S3C64xx: cpuidle cleanups
On 05/14/12 18:22, Daniel Lezcano wrote: On 05/14/2012 10:57 AM, Mark Brown wrote: On Mon, May 14, 2012 at 10:52:46AM +0200, Heiko St??bner wrote: Am Montag, 14. Mai 2012, 01:51:00 schrieb Daniel Lezcano: On 05/09/2012 04:08 PM, Daniel Lezcano wrote: Are these patches ok for inclusion ? you might want to include the maintainer Kukjin Kimkgene@samsung.com and the samsung list linux-samsung-soc@vger.kernel.org into your recipients Also the original author (me). Oh, ok. I thought I did it, sorry. Heiko, thanks :-) Daniel, could you please re-submit this series with adding me and Mark Brown in Cc. I couldn't find your patches in my mailbox... Thanks. Best regards, Kgene. -- Kukjin Kim kgene@samsung.com, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/2] ARM: S3C64xx: cpuidle cleanups
On 05/14/2012 03:51 PM, Kukjin Kim wrote: On 05/14/12 18:22, Daniel Lezcano wrote: On 05/14/2012 10:57 AM, Mark Brown wrote: On Mon, May 14, 2012 at 10:52:46AM +0200, Heiko St??bner wrote: Am Montag, 14. Mai 2012, 01:51:00 schrieb Daniel Lezcano: On 05/09/2012 04:08 PM, Daniel Lezcano wrote: Are these patches ok for inclusion ? you might want to include the maintainer Kukjin Kimkgene@samsung.com and the samsung list linux-samsung-soc@vger.kernel.org into your recipients Also the original author (me). Oh, ok. I thought I did it, sorry. Heiko, thanks :-) Daniel, could you please re-submit this series with adding me and Mark Brown in Cc. I couldn't find your patches in my mailbox... Sure. -- http://www.linaro.org/ Linaro.org │ Open source software for ARM SoCs Follow Linaro: http://www.facebook.com/pages/Linaro Facebook | http://twitter.com/#!/linaroorg Twitter | http://www.linaro.org/linaro-blog/ Blog -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html