Re: [PATCH 00/14] drm/exynos: rewrite fimg2d error handling

2015-08-31 Thread Inki Dae 
On 2015년 08월 28일 05:46, Tobias Jakobi wrote:
> Hey Emil,
> 
> 
> Emil Velikov wrote:
>> Hi Tobias,
>>
>> On 24 August 2015 at 15:13, Tobias Jakobi  
>> wrote:
>>> Hello,
>>>
>>> during the discussion about the last patchset touching the
>>> fimg2d code, it became apparent that the error handling for
>>> the command submission is currently unsatisfactory.
>>>
>>> This series rewrites the handling. All functions that submit
>>> command buffers now first check if enough space is available
>>> and only then proceed to build the command buffers.
>>>
>>> In particular the command buffer is no longer left in a
>>> half-finished state, since parameters passed to the functions
>>> are now validated before command submission. For this some
>>> validation functions are introduced.
>>>
>>> This should also increase performance if the bottleneck is
>>> the submission part, since adding commands to the buffer
>>> is now more lightweight.
>>>
>>> Last but not least some prefix was added to messages printed
>>> by fprintf and printf, and the G2D context struct was moved
>>> out of the public header.
>>>
>>>
>> Thanks for going with my earlier suggestion and untangling all this.
>>
>> I've went through the lot and it looks great afaict. Fwiw for the series
>> Reviewed-by: Emil Velikov 
> thanks for the review and the help on IRC!
> 
> 
>> As pretty much none of this is hardware specific and/or requires
>> additional knowledge of the kernel module I'm inclined to pull this in
>> even if we don't get too many reviewers. We better keep it around for
>> a couple of weeks in case others are swamped with unrelated work atm,
>> yet willing to take a look.
> Sure, I'm going to wait and do some pings from time to time :)
> 

I had a review and looks good to me. There are just cleanup issues but
no problem to upstream them as-is. However, in my opinion, I think the
patch 7 could be more cleaned up.

Signed-off-by: Inki Dae 

Thanks,
Inki Dae


> 
> With best wishes,
> Tobias
> 
>>
>> Cheers,
>> Emil
>>
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" 
> in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 00/14] drm/exynos: rewrite fimg2d error handling

2015-08-27 Thread Emil Velikov 
Hi Tobias,

On 24 August 2015 at 15:13, Tobias Jakobi tjak...@math.uni-bielefeld.de wrote:
 Hello,

 during the discussion about the last patchset touching the
 fimg2d code, it became apparent that the error handling for
 the command submission is currently unsatisfactory.

 This series rewrites the handling. All functions that submit
 command buffers now first check if enough space is available
 and only then proceed to build the command buffers.

 In particular the command buffer is no longer left in a
 half-finished state, since parameters passed to the functions
 are now validated before command submission. For this some
 validation functions are introduced.

 This should also increase performance if the bottleneck is
 the submission part, since adding commands to the buffer
 is now more lightweight.

 Last but not least some prefix was added to messages printed
 by fprintf and printf, and the G2D context struct was moved
 out of the public header.


Thanks for going with my earlier suggestion and untangling all this.

I've went through the lot and it looks great afaict. Fwiw for the series
Reviewed-by: Emil Velikov emil.l.veli...@gmail.com

As pretty much none of this is hardware specific and/or requires
additional knowledge of the kernel module I'm inclined to pull this in
even if we don't get too many reviewers. We better keep it around for
a couple of weeks in case others are swamped with unrelated work atm,
yet willing to take a look.

Cheers,
Emil
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 00/14] drm/exynos: rewrite fimg2d error handling

2015-08-27 Thread Tobias Jakobi 
Hey Emil,


Emil Velikov wrote:
 Hi Tobias,
 
 On 24 August 2015 at 15:13, Tobias Jakobi tjak...@math.uni-bielefeld.de 
 wrote:
 Hello,

 during the discussion about the last patchset touching the
 fimg2d code, it became apparent that the error handling for
 the command submission is currently unsatisfactory.

 This series rewrites the handling. All functions that submit
 command buffers now first check if enough space is available
 and only then proceed to build the command buffers.

 In particular the command buffer is no longer left in a
 half-finished state, since parameters passed to the functions
 are now validated before command submission. For this some
 validation functions are introduced.

 This should also increase performance if the bottleneck is
 the submission part, since adding commands to the buffer
 is now more lightweight.

 Last but not least some prefix was added to messages printed
 by fprintf and printf, and the G2D context struct was moved
 out of the public header.


 Thanks for going with my earlier suggestion and untangling all this.
 
 I've went through the lot and it looks great afaict. Fwiw for the series
 Reviewed-by: Emil Velikov emil.l.veli...@gmail.com
thanks for the review and the help on IRC!


 As pretty much none of this is hardware specific and/or requires
 additional knowledge of the kernel module I'm inclined to pull this in
 even if we don't get too many reviewers. We better keep it around for
 a couple of weeks in case others are swamped with unrelated work atm,
 yet willing to take a look.
Sure, I'm going to wait and do some pings from time to time :)


With best wishes,
Tobias

 
 Cheers,
 Emil
 

--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html