Re: [PATCH 1/1] ARM: dts: Add missing clock names for exynos4412 dwmmc node

2013-12-02 Thread Mark Rutland 
On Sun, Dec 01, 2013 at 10:11:47AM +, Alex Ling wrote:
 This patch adds biu and ciu clock names for exynos4412 dwmmc
 node. Without this patch, dwmmc host driver will skip enabling the
 two clocks and it will break dwmmc host function on exynos4412.
 Tested on FriendlyARM TINY4412 board.

The patch description is a little off; this patch adds the clocks as
well as the clock-names.

The patch itself looks fine to me.

Mark.

 
 Signed-off-by: Alex Ling kasiml...@gmail.com
 ---
  arch/arm/boot/dts/exynos4412.dtsi |2 ++
  1 file changed, 2 insertions(+)
 
 diff --git a/arch/arm/boot/dts/exynos4412.dtsi 
 b/arch/arm/boot/dts/exynos4412.dtsi
 index e743e67..67bef99 100644
 --- a/arch/arm/boot/dts/exynos4412.dtsi
 +++ b/arch/arm/boot/dts/exynos4412.dtsi
 @@ -67,5 +67,7 @@
   interrupts = 0 77 0;
   #address-cells = 1;
   #size-cells = 0;
 + clocks = clock 301, clock 149;
 + clock-names = biu, ciu;
   };
  };
 -- 
 1.7.9.5
 
 
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/1] ARM: dts: Add missing clock names for exynos4412 dwmmc node

2013-12-02 Thread Alex Ling 
On Mon, Dec 2, 2013 at 5:52 PM, Mark Rutland mark.rutl...@arm.com wrote:
 On Sun, Dec 01, 2013 at 10:11:47AM +, Alex Ling wrote:
 This patch adds biu and ciu clock names for exynos4412 dwmmc
 node. Without this patch, dwmmc host driver will skip enabling the
 two clocks and it will break dwmmc host function on exynos4412.
 Tested on FriendlyARM TINY4412 board.

 The patch description is a little off; this patch adds the clocks as
 well as the clock-names.
Well noted. I'll update the description later. Thanks!

 The patch itself looks fine to me.

 Mark.


 Signed-off-by: Alex Ling kasiml...@gmail.com
 ---
  arch/arm/boot/dts/exynos4412.dtsi |2 ++
  1 file changed, 2 insertions(+)

 diff --git a/arch/arm/boot/dts/exynos4412.dtsi 
 b/arch/arm/boot/dts/exynos4412.dtsi
 index e743e67..67bef99 100644
 --- a/arch/arm/boot/dts/exynos4412.dtsi
 +++ b/arch/arm/boot/dts/exynos4412.dtsi
 @@ -67,5 +67,7 @@
   interrupts = 0 77 0;
   #address-cells = 1;
   #size-cells = 0;
 + clocks = clock 301, clock 149;
 + clock-names = biu, ciu;
   };
  };
 --
 1.7.9.5



BR,
Alex
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/1] ARM: dts: Add missing clock names for exynos4412 dwmmc node

2013-12-01 Thread randy 
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

I don't know whether it will works. Actually I don't what the name
used for. So I just referencing my mail before.
Thank you

-  origin mail 
主题: Re: linux 3.13-rc1 make dw_mmc-exynos more worse
日期: Tue, 26 Nov 2013 14:00:20 +0800
发件人: randy lxr1...@hotmail.com
收件人: Jaehoon Chung jh80.ch...@samsung.com
抄送: Tomasz Figa tomasz.f...@gmail.com,
linux-samsung-soc@vger.kernel.org, devicet...@vger.kernel.org, Seungwon
Jeon tgih@samsung.com, t.f...@samsung.com, o...@lixom.net,
kgene@samsung.com

Thanks Jaehoon,
I have noticed that before it, but in dw_mmc driver, I won't meet this
problem.
As you can seen in dts, I have defined a clock source.
Or the clock source what I choose is not correct?
I don't know how to debug this, I don't know much about it.
Actually, I don't really understand the contain in chapter 7 of datasheet.
I am sorry for that.
Would you like to tell me some more about it?

于 2013年11月26日 12:32, Jaehoon Chung 写道:
 Hi, Randy,
 
 It seems a problem that controller didn't find the clock source. 
 Also you can see the below message. Did you check the clock 
 source?
 
 [1.125000] s3c-sdhci 1255.sdhci: failed to get io clock
 
 Actually, need to prevent the null pointer dereference for clock 
 in dw-mmc.c
 
 And If dw-mmc controller can be used, recommend to use it. dw-mmc 
 can use DDR mode, but sdhci can't.
 
 Best Regards, Jaehoon Chung
 
 On 11/26/2013 10:47 AM, randy wrote: 于 2013年11月26日 08:41, Tomasz 
 Figa 写道:
 On Sunday 24 of November 2013 22:18:46 Olof Johansson wrote:
 Hi,
 
 On Sun, Nov 24, 2013 at 4:07 AM, randy 
 lxr1...@hotmail.com wrote:
 -BEGIN PGP SIGNED MESSAGE- Hash: SHA1
 
 After pull the merge of 3.13-rc1, the dw_mmc-exynos will 
 make the boot stock.In 3.13, it is just stocked udev in 
 3.13 and makse udev timeout but kernel report the emmc 
 device is found.
 
 And in the 
 Documentation/devicetree/bindings/mmc/exynos-dw-mshc.txt 
 I saw that it is need to define which gpio ports that a 
 emmc slot use, but when I watched others dts, they use 
 pinctrl, which is correct? Here is the log and dts
 
 [..]
 
 ===log begin 
 =
 [..]
 [0.00] CPU EXYNOS4412 (id 0xe4412011)
 
 [..]
 
 [1.095000] mmc0: no vmmc regulator found [ 1.13] 
 mmc0: SDHCI controller on samsung-hsmmc [1253.sdhci] 
 using ADMA [1.13] Synopsys Designware Multimedia 
 Card Interface Driver [ 1.13] Unable to handle
 kernel NULL pointer dereference at virtual address
 002a [ 1.13] pgd = c0004000 [1.13]
 [002a] *pgd= [ 1.135000] Internal error:
 Oops: 5 [#1] PREEMPT SMP ARM [ 1.14] Modules linked
 in: [ 1.14] CPU: 0 PID: 1 Comm: swapper/0 Not
 tainted 3.13.0-rc1-8-g584fa45-dirty #3 [ 1.15]
 task: ef0a4000 ti: ef0a8000 task.ti: ef0a8000 [ 1.155000]
 PC is at clk_get_rate+0x18/0x5c [1.16] LR is at 
 clk_prepare_lock+0xc/0xd8 [1.165000] pc : 
 [c0319400] lr : [c0318864]psr: a113 [ 
 1.165000] sp : ef0a9e20 ip : ee94eb40  fp :  [ 
 1.175000] r10: c0571510  r9 : ef0a8000  r8 : ef227a10 [ 
 1.18] r7 : c043544c  r6 : fffe  r5 : ee94ead0 r4
 : fffe [1.185000] r3 : ef0a4000  r2 : 0001 r1
 : 02b9  r0 : 0001 [ 1.195000] Flags: NzCv IRQs on
 FIQs on  Mode SVC_32  ISA ARM Segment kernel [ 1.20]
 Control: 10c5387d  Table: 4000404a DAC: 0015 [
 1.205000] Process swapper/0 (pid: 1, stack limit =
 0xef0a8240) [1.21] Stack: (0xef0a9e20 to
 0xef0aa000) [1.215000] 9e20: c0308474 ee9ea610
 ee94ead0 c0308488 c0308474 ee9ea610  c030592c [
 1.225000] 9e40: ef227a10 1000 c043544c c020a920
 c0838b04 17d78400 ee9ea610 ef227a00 [ 1.235000] 9e60:
 ef227a10 c05d6b1c  c05d6b1c c05890b0 ef0a8000
 c0571510 c0269448 [ 1.24] 9e80: c0269430 ef227a10
 c061291c c0268088  ef227a10 c05d6b1c ef227a44 [
 1.25] 9ea0:  c026822c  c05d6b1c
 c02681a0 c02668a8 ef005478 ef212740 [ 1.255000] 9ec0:
 c05d6b1c ef2c7900 c05cf438 c0267864 c0511e38 c05d6b1c
 0006 c05d6b1c [1.265000] 9ee0: 0006 c059575c
 c05df580 c026884c  c05a2e14 0006 c00088dc [
 1.275000] 9f00: c0603f70 ef163e00 c040e334 6113
 c05b5000 a113 c05b5054 c05b5050 [ 1.28] 9f20:
 c05df580 c054ad68 c0839c96 c04247b4 0093 c0035158
 c05b5054 c05a2a20 [1.29] 9f40: c050ae2c c054a438
 0006 0006  c05a2e14 0006 c059575c [
 1.30] 9f60: c05df580 0093 c0595768 c0571510
  c0571c48 0006 0006 [ 1.305000] 9f80:
 c0571510 c003df68  c0403544  
   [1.315000] 9fa0:  c040354c
  c000e738     [
 1.32] 9fc0:    
     [ 1.33] 9fe0:
     0013 
 be73efa4 bffd [1.34] [c0319400]