Re: [PATCH 1/1] clk: exynos5420: Restore GATE_BUS_TOP on suspend

2015-04-08 Thread Javier Martinez Canillas
Hello Sylwester,

On 04/08/2015 11:06 AM, Sylwester Nawrocki wrote:
 
 diff --git a/drivers/clk/samsung/clk-exynos5420.c 
 b/drivers/clk/samsung/clk-exynos5420.c
 index 07d666cc6a29..bea4a173eef5 100644
 --- a/drivers/clk/samsung/clk-exynos5420.c
 +++ b/drivers/clk/samsung/clk-exynos5420.c
 @@ -271,6 +271,7 @@ static const struct samsung_clk_reg_dump 
 exynos5420_set_clksrc[] = {
  { .offset = SRC_MASK_PERIC0,.value = 0x1110, },
  { .offset = SRC_MASK_PERIC1,.value = 0x1100, },
  { .offset = SRC_MASK_ISP,   .value = 0x1000, },
 +{ .offset = GATE_BUS_TOP,   .value = 0x, },
  { .offset = GATE_BUS_DISP1, .value = 0x, },
  { .offset = GATE_IP_PERIC,  .value = 0x, },
  };
 
 I'm going to tag this patch for inclusion in the stable tree and send
 it to Mike or Stephen with other clk/samsung fixes after v4.1-rc1 is
 released.
 
 Mike/Stephen, if you're willing to take this patch earlier here is my:
 
 Acked-by: Sylwester Nawrocki s.nawro...@samsung.com
 

Great, thanks a lot for your help!

Best regards,
Javier
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH 1/1] clk: exynos5420: Restore GATE_BUS_TOP on suspend

2015-04-08 Thread Sylwester Nawrocki
Hello,

On 08/04/15 07:34, Javier Martinez Canillas wrote:
 Commit ae43b3289186 (ARM: 8202/1: dmaengine: pl330: Add runtime Power
 Management support v12) added pm support for the pl330 dma driver but
 it makes the clock for the Exynos5420 MDMA0 DMA controller to be gated
 during suspend and this in turn makes its parent clock aclk266_g2d to
 be gated. But the clock needs to be ungated prior suspend to allow the
 system to be suspend and resumed correctly.
 
 Add GATE_BUS_TOP register to the list of registers to be restored when
 the system enters into a suspend state so aclk266_g2d will be ungated.
 
 Thanks to Abhilash Kesavan for figuring out that this was the issue.
 
 Fixes: ae43b32 (ARM: 8202/1: dmaengine: pl330: Add runtime Power Management 
 support v12)
 Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
 Tested-by: Kevin Hilman khil...@linaro.org
 Tested-by: Abhilash Kesavan a.kesa...@samsung.com
 Acked-by: Tomasz Figa tomasz.f...@gmail.com
 ---
  drivers/clk/samsung/clk-exynos5420.c | 1 +
  1 file changed, 1 insertion(+)
 
 diff --git a/drivers/clk/samsung/clk-exynos5420.c 
 b/drivers/clk/samsung/clk-exynos5420.c
 index 07d666cc6a29..bea4a173eef5 100644
 --- a/drivers/clk/samsung/clk-exynos5420.c
 +++ b/drivers/clk/samsung/clk-exynos5420.c
 @@ -271,6 +271,7 @@ static const struct samsung_clk_reg_dump 
 exynos5420_set_clksrc[] = {
   { .offset = SRC_MASK_PERIC0,.value = 0x1110, },
   { .offset = SRC_MASK_PERIC1,.value = 0x1100, },
   { .offset = SRC_MASK_ISP,   .value = 0x1000, },
 + { .offset = GATE_BUS_TOP,   .value = 0x, },
   { .offset = GATE_BUS_DISP1, .value = 0x, },
   { .offset = GATE_IP_PERIC,  .value = 0x, },
  };

I'm going to tag this patch for inclusion in the stable tree and send
it to Mike or Stephen with other clk/samsung fixes after v4.1-rc1 is
released.

Mike/Stephen, if you're willing to take this patch earlier here is my:

Acked-by: Sylwester Nawrocki s.nawro...@samsung.com

-- 
Thanks,
Sylwester
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html