Re: [PATCH 3/5] ARM: EXYNOS: DTS: add SROM device node for exynos4

2015-08-20 Thread Pankaj Dubey 

Hi,


On Wednesday 27 May 2015 05:32 PM, Krzysztof Kozlowski wrote:

W dniu 29.04.2015 o 17:38, Pankaj Dubey pisze:

Add SROM device node for exynos4.


Subject prefix: ARM: dts:


Ok.


CC: Rob Herring robh...@kernel.org
CC: Mark Rutland mark.rutl...@arm.com
CC: Ian Campbell ijc+devicet...@hellion.org.uk
Signed-off-by: Pankaj Dubey pankaj.du...@samsung.com
---
  arch/arm/boot/dts/exynos4.dtsi | 5 +
  1 file changed, 5 insertions(+)

diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi
index 77ea547..48490ea 100644
--- a/arch/arm/boot/dts/exynos4.dtsi
+++ b/arch/arm/boot/dts/exynos4.dtsi
@@ -76,6 +76,11 @@
reg = 0x1000 0x100;
};

+   sromc@1257 {
+   compatible = samsung,exynos-srom;
+   reg = 0x1257 0x100;


There are 5 registers, so size of 0x100 seems to be bigger than needed.
Maybe limit it to actual length?


Yes, we do not need size of 0x100. Will take care in next version.

Thanks,
Pankaj Dubey


Best regards,
Krzysztof


--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 3/5] ARM: EXYNOS: DTS: add SROM device node for exynos4

2015-05-27 Thread Krzysztof Kozlowski 
W dniu 29.04.2015 o 17:38, Pankaj Dubey pisze:
 Add SROM device node for exynos4.

Subject prefix: ARM: dts:

 
 CC: Rob Herring robh...@kernel.org
 CC: Mark Rutland mark.rutl...@arm.com
 CC: Ian Campbell ijc+devicet...@hellion.org.uk
 Signed-off-by: Pankaj Dubey pankaj.du...@samsung.com
 ---
  arch/arm/boot/dts/exynos4.dtsi | 5 +
  1 file changed, 5 insertions(+)
 
 diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi
 index 77ea547..48490ea 100644
 --- a/arch/arm/boot/dts/exynos4.dtsi
 +++ b/arch/arm/boot/dts/exynos4.dtsi
 @@ -76,6 +76,11 @@
   reg = 0x1000 0x100;
   };
  
 + sromc@1257 {
 + compatible = samsung,exynos-srom;
 + reg = 0x1257 0x100;

There are 5 registers, so size of 0x100 seems to be bigger than needed.
Maybe limit it to actual length?

Best regards,
Krzysztof
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html