RE: [PATCH v4 0/6] cpufreq: use generic cpufreq drivers for Exynos4x12 platform
Krzysztof Kozlowski wrote: On 10.08.2015 10:27, Kukjin Kim wrote: Krzysztof Kozlowski wrote: W dniu 08.08.2015 o 11:07, Viresh Kumar pisze: On 08-08-15, 00:24, Rafael J. Wysocki wrote: OK, so please let me know which patches you want me to pick up. Ideally, I'd prefer them to be resent in a separate series with ACKs and all with a cover letter clearly stating whose tree they are being targeted at. He already sent it separately, let me send a confirmatory mail in reply to that. Dear Kukjin, Can you apply the 2-5 of this series to v4.3? It's getting late but maybe they still could go? Once my previous pull-request landed into arm-soc, I'll try to send out this series 2-5 for v4.3. Additionally (better late than never): Sure ;-) Patches 2-5 tested on Trats2 board (Exynos4412) Tested-by: Krzysztof Kozlowski k.kozlow...@samsung.com Applied with Krzysztof's 'Tested-by'. Thanks, Kukjin -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v4 0/6] cpufreq: use generic cpufreq drivers for Exynos4x12 platform
On 10.08.2015 10:27, Kukjin Kim wrote: Krzysztof Kozlowski wrote: W dniu 08.08.2015 o 11:07, Viresh Kumar pisze: On 08-08-15, 00:24, Rafael J. Wysocki wrote: OK, so please let me know which patches you want me to pick up. Ideally, I'd prefer them to be resent in a separate series with ACKs and all with a cover letter clearly stating whose tree they are being targeted at. He already sent it separately, let me send a confirmatory mail in reply to that. Dear Kukjin, Can you apply the 2-5 of this series to v4.3? It's getting late but maybe they still could go? Once my previous pull-request landed into arm-soc, I'll try to send out this series 2-5 for v4.3. Additionally (better late than never): Patches 2-5 tested on Trats2 board (Exynos4412) Tested-by: Krzysztof Kozlowski k.kozlow...@samsung.com Best regards, Krzysztof -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH v4 0/6] cpufreq: use generic cpufreq drivers for Exynos4x12 platform
Krzysztof Kozlowski wrote: W dniu 08.08.2015 o 11:07, Viresh Kumar pisze: On 08-08-15, 00:24, Rafael J. Wysocki wrote: OK, so please let me know which patches you want me to pick up. Ideally, I'd prefer them to be resent in a separate series with ACKs and all with a cover letter clearly stating whose tree they are being targeted at. He already sent it separately, let me send a confirmatory mail in reply to that. Dear Kukjin, Can you apply the 2-5 of this series to v4.3? It's getting late but maybe they still could go? Once my previous pull-request landed into arm-soc, I'll try to send out this series 2-5 for v4.3. Thanks, Kukjin -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v4 0/6] cpufreq: use generic cpufreq drivers for Exynos4x12 platform
On Friday, August 07, 2015 05:26:27 PM Viresh Kumar wrote: On 07-08-15, 13:47, Bartlomiej Zolnierkiewicz wrote: Hmm, wait. Patch 6/6 depends on earlier changes. I cannot remove the config option in question now as it is currently used by exynos-cpufreq specific boost support. Patch 1/6 can be applied now but 6/6 needs to wait for patches 2-5 to be applied first. Actually 6/6 is trivial and can be applied later in v4.3 cycle or even in v4.4 one. Ack. OK, so please let me know which patches you want me to pick up. Ideally, I'd prefer them to be resent in a separate series with ACKs and all with a cover letter clearly stating whose tree they are being targeted at. Thanks, Rafael -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v4 0/6] cpufreq: use generic cpufreq drivers for Exynos4x12 platform
Hi, On Friday, August 07, 2015 10:48:26 AM Viresh Kumar wrote: On 07-08-15, 13:52, Krzysztof Kozlowski wrote: Thanks for explanation. As fair as I understand, Bartlomiej wanted to merge this in a way which would avoid loosing the boost mode. Kukjin prepared topic branches for previous cpu-freq/clk stuff so maybe everything could go through PM? We aren't loosing anything at all. There can be two cases here: 1. Patch 1/6 and 6/6 make it to 4.3 (with suggested changes) via PM tree: - All will work fine in this case, no issues at all.. 2. They don't make it: - Even in this case, nothing will break. Users can just enable a config option and that's all.. Users don't need to enable the config option to get boost functionality working. It is only needed to get scaling_boost_freqs sysfs attribute visible (which lists available boost freqs) when using cpufreq-dt driver. Also the config option in question is not user visible. The worst thing that happens if these 2 PM patches don't make it in time is that there will be no scaling_boost_freqs available when using cpufreq-dt driver. Which is not very important from Exynos4x12 POV as it only supports single boost freq currently. So, no need to divert things into another tree this late. I agree. Over that, Rafael will not be around for 2 weeks now (Plumbers and other stuff) .. So, just target the cpufreq core changes via PM tree.. rest is just fine. I hope that makes sense :) Yes. :) Best regards, -- Bartlomiej Zolnierkiewicz Samsung RD Institute Poland Samsung Electronics -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v4 0/6] cpufreq: use generic cpufreq drivers for Exynos4x12 platform
On 07-08-15, 13:31, Bartlomiej Zolnierkiewicz wrote: Users don't need to enable the config option to get boost functionality working. It is only needed to get scaling_boost_freqs sysfs attribute visible (which lists available boost freqs) when using cpufreq-dt driver. Also the config option in question is not user visible. By users I meant the people who will prepare the build images for the release. They can just enable the config option :) The worst thing that happens if these 2 PM patches don't make it in time is that there will be no scaling_boost_freqs available when using cpufreq-dt driver. Which is not very important from Exynos4x12 POV as it only supports single boost freq currently. Right. So, now that your patch is Acked, send 1/6 and 6/6 separately to pm-list and Rafael can get them merged himself.. I hope, your 6/6 patch will change a bit now ? -- viresh -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v4 0/6] cpufreq: use generic cpufreq drivers for Exynos4x12 platform
On Friday, August 07, 2015 05:09:50 PM Viresh Kumar wrote: On 07-08-15, 13:31, Bartlomiej Zolnierkiewicz wrote: Users don't need to enable the config option to get boost functionality working. It is only needed to get scaling_boost_freqs sysfs attribute visible (which lists available boost freqs) when using cpufreq-dt driver. Also the config option in question is not user visible. By users I meant the people who will prepare the build images for the release. They can just enable the config option :) OK. The worst thing that happens if these 2 PM patches don't make it in time is that there will be no scaling_boost_freqs available when using cpufreq-dt driver. Which is not very important from Exynos4x12 POV as it only supports single boost freq currently. Right. So, now that your patch is Acked, send 1/6 and 6/6 separately to pm-list and Rafael can get them merged himself.. I hope, your 6/6 patch will change a bit now ? Hmm, wait. Patch 6/6 depends on earlier changes. I cannot remove the config option in question now as it is currently used by exynos-cpufreq specific boost support. Patch 1/6 can be applied now but 6/6 needs to wait for patches 2-5 to be applied first. Actually 6/6 is trivial and can be applied later in v4.3 cycle or even in v4.4 one. Best regards, -- Bartlomiej Zolnierkiewicz Samsung RD Institute Poland Samsung Electronics -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v4 0/6] cpufreq: use generic cpufreq drivers for Exynos4x12 platform
On 07-08-15, 13:47, Bartlomiej Zolnierkiewicz wrote: Hmm, wait. Patch 6/6 depends on earlier changes. I cannot remove the config option in question now as it is currently used by exynos-cpufreq specific boost support. Patch 1/6 can be applied now but 6/6 needs to wait for patches 2-5 to be applied first. Actually 6/6 is trivial and can be applied later in v4.3 cycle or even in v4.4 one. Ack. -- viresh -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v4 0/6] cpufreq: use generic cpufreq drivers for Exynos4x12 platform
On 08-08-15, 00:24, Rafael J. Wysocki wrote: OK, so please let me know which patches you want me to pick up. Ideally, I'd prefer them to be resent in a separate series with ACKs and all with a cover letter clearly stating whose tree they are being targeted at. He already sent it separately, let me send a confirmatory mail in reply to that. -- viresh -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v4 0/6] cpufreq: use generic cpufreq drivers for Exynos4x12 platform
Cc'ing Rafael again. Guys please don't miss him for any PM related stuff or use get_maintainers .. Cc'ing Arnd/Olof as well to discuss the merge stuff.. On 07-08-15, 08:53, Kukjin Kim wrote: Depends on: - next-20150806 branch of linux-next kernel tree - [PATCH V3 00/16] OPP: Add code to support operating-points-v2 bindings (http://www.spinics.net/lists/arm-kernel/msg435408.html) BTW, hmm...how can we see this series in v4.3?...to be honest, I don't think it can be done in v4.3 because of dependencies with PM / OPP series That is merged by Rafael Yesterday. That is manageable and previous exynos CPU OPP series in each cross trees...maybe that's why you created based on linux-next...any idea? So there is no build dependency with OPP patches I hope, as its all about using the bindings defined by them. And so you don't need to depend on that. You might have to rebase on the ARM tree to manage your conflicts. In this case you can rebase directly on ARM SoC branch which has your patches (rebase directly over the last patch instead of the whole branch) and make sure Olof knows about this and he doesn't update (i.e. rebase) his branch, which he might not anyway. The whole idea is to keep a single sha-id for a commit. So you can rebase over the published material present in ARM-SoC .. -- viresh -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v4 0/6] cpufreq: use generic cpufreq drivers for Exynos4x12 platform
Fixed Olof's email id.. On 07-08-15, 09:20, Viresh Kumar wrote: Cc'ing Rafael again. Guys please don't miss him for any PM related stuff or use get_maintainers .. Cc'ing Arnd/Olof as well to discuss the merge stuff.. On 07-08-15, 08:53, Kukjin Kim wrote: Depends on: - next-20150806 branch of linux-next kernel tree - [PATCH V3 00/16] OPP: Add code to support operating-points-v2 bindings (http://www.spinics.net/lists/arm-kernel/msg435408.html) BTW, hmm...how can we see this series in v4.3?...to be honest, I don't think it can be done in v4.3 because of dependencies with PM / OPP series That is merged by Rafael Yesterday. That is manageable and previous exynos CPU OPP series in each cross trees...maybe that's why you created based on linux-next...any idea? So there is no build dependency with OPP patches I hope, as its all about using the bindings defined by them. And so you don't need to depend on that. You might have to rebase on the ARM tree to manage your conflicts. In this case you can rebase directly on ARM SoC branch which has your patches (rebase directly over the last patch instead of the whole branch) and make sure Olof knows about this and he doesn't update (i.e. rebase) his branch, which he might not anyway. The whole idea is to keep a single sha-id for a commit. So you can rebase over the published material present in ARM-SoC .. -- viresh -- viresh -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v4 0/6] cpufreq: use generic cpufreq drivers for Exynos4x12 platform
On 07.08.2015 12:51, Viresh Kumar wrote: Fixed Olof's email id.. On 07-08-15, 09:20, Viresh Kumar wrote: Cc'ing Rafael again. Guys please don't miss him for any PM related stuff or use get_maintainers .. Cc'ing Arnd/Olof as well to discuss the merge stuff.. On 07-08-15, 08:53, Kukjin Kim wrote: Depends on: - next-20150806 branch of linux-next kernel tree - [PATCH V3 00/16] OPP: Add code to support operating-points-v2 bindings (http://www.spinics.net/lists/arm-kernel/msg435408.html) BTW, hmm...how can we see this series in v4.3?...to be honest, I don't think it can be done in v4.3 because of dependencies with PM / OPP series That is merged by Rafael Yesterday. That is manageable Indeed, happy to hear it! So the patchset has no external dependencies. and previous exynos CPU OPP series in each cross trees...maybe that's why you created based on linux-next...any idea? So there is no build dependency with OPP patches I hope, as its all about using the bindings defined by them. And so you don't need to depend on that. You might have to rebase on the ARM tree to manage your conflicts. In this case you can rebase directly on ARM SoC branch which has your patches (rebase directly over the last patch instead of the whole branch) and make sure Olof knows about this and he doesn't update (i.e. rebase) his branch, which he might not anyway. The whole idea is to keep a single sha-id for a commit. So you can rebase over the published material present in ARM-SoC .. Still patches 1/6 and 6/6 need your acks. Is the patch 1/6 a prerequisite for others? It does not look like a prerequisite... but it was put at the beginning of the patchset. Best regards, Krzysztof -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v4 0/6] cpufreq: use generic cpufreq drivers for Exynos4x12 platform
On 07-08-15, 13:52, Krzysztof Kozlowski wrote: Thanks for explanation. As fair as I understand, Bartlomiej wanted to merge this in a way which would avoid loosing the boost mode. Kukjin prepared topic branches for previous cpu-freq/clk stuff so maybe everything could go through PM? We aren't loosing anything at all. There can be two cases here: 1. Patch 1/6 and 6/6 make it to 4.3 (with suggested changes) via PM tree: - All will work fine in this case, no issues at all.. 2. They don't make it: - Even in this case, nothing will break. Users can just enable a config option and that's all.. So, no need to divert things into another tree this late. Over that, Rafael will not be around for 2 weeks now (Plumbers and other stuff) .. So, just target the cpufreq core changes via PM tree.. rest is just fine. I hope that makes sense :) -- viresh -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v4 0/6] cpufreq: use generic cpufreq drivers for Exynos4x12 platform
On 07.08.2015 13:30, Viresh Kumar wrote: On 07-08-15, 13:13, Krzysztof Kozlowski wrote: Still patches 1/6 and 6/6 need your acks. Is the patch 1/6 a prerequisite for others? It does not look like a prerequisite... but it was put at the beginning of the patchset. Patch 1/6 is required to get boost working, that's all.. Not sure how important is that. Anyway, that will work without 1/6 as well, all you need to do is enable CONFIG_CPU_FREQ_BOOST_SW in you .config. Anyway, it should go via pm tree and can be sent separately. Thanks for explanation. As fair as I understand, Bartlomiej wanted to merge this in a way which would avoid loosing the boost mode. Kukjin prepared topic branches for previous cpu-freq/clk stuff so maybe everything could go through PM? Kukjin, are you fine with that? Best regards, Krzysztof -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v4 0/6] cpufreq: use generic cpufreq drivers for Exynos4x12 platform
On 07-08-15, 13:13, Krzysztof Kozlowski wrote: Still patches 1/6 and 6/6 need your acks. Is the patch 1/6 a prerequisite for others? It does not look like a prerequisite... but it was put at the beginning of the patchset. Patch 1/6 is required to get boost working, that's all.. Not sure how important is that. Anyway, that will work without 1/6 as well, all you need to do is enable CONFIG_CPU_FREQ_BOOST_SW in you .config. Anyway, it should go via pm tree and can be sent separately. -- viresh -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH v4 0/6] cpufreq: use generic cpufreq drivers for Exynos4x12 platform
Bartlomiej Zolnierkiewicz wrote: Hi, Hi Bart, This patch series removes the use of Exynos4x12 specific support from cpufreq-exynos driver and enables the use of cpufreq-dt driver for this platform. Thanks for this series. This patch series has been tested on Exynos4412 based Odroid-U3 and Trats2 boards. Sounds good. Depends on: - next-20150806 branch of linux-next kernel tree - [PATCH V3 00/16] OPP: Add code to support operating-points-v2 bindings (http://www.spinics.net/lists/arm-kernel/msg435408.html) BTW, hmm...how can we see this series in v4.3?...to be honest, I don't think it can be done in v4.3 because of dependencies with PM / OPP series and previous exynos CPU OPP series in each cross trees...maybe that's why you created based on linux-next...any idea? Thanks, Kukjin Changes since v3 (http://thread.gmane.org/gmane.linux.power-management.general/63464): - rebased on top of next-20150806 branch of linux-next kernel tree - made ARCH_EXYNOS config option select thermal support - made scaling_boost_freqs sysfs attribute available only when boost support is enabled - added Acked-by tag from Viresh to patches #3, #4 and #5 - added Tested-by tag from Tobias to patches #2-5 - added Reviewed-by tag from Krzysztof to patch #4 Changes since v2 (http://thread.gmane.org/gmane.linux.kernel.samsung-soc/46653): - rebased on top of next-20150730 branch of linux-next kernel tree - ported over V3 of opp-v2 bindings support patch series - put cpu0 nodes in alphabetical order in dts files - added Reviewed-by tags from Javier and Krzysztof - added Acked-by tag from Sylwester Changes since v1 (http://thread.gmane.org/gmane.linux.kernel.samsung-soc/44361): - rebased on top of next-20150629 branch of linux-next kernel tree - rebased on top of Exynos5250 cpufreq-dt support patch series - fixed if-statement in exynos4_clk_init() (noticed by Tobias Jakobi) - ported over opp-v2 bindings (requested by Viresh Kumar) Best regards, -- Bartlomiej Zolnierkiewicz Samsung RD Institute Poland Samsung Electronics Bartlomiej Zolnierkiewicz (6): cpufreq: make scaling_boost_freqs sysfs attr available when boost is enabled clk: samsung: exynos4x12: add cpu clock configuration data and instantiate cpu clock ARM: dts: Exynos4x12: add CPU OPP and regulator supply property ARM: Exynos: switch to using generic cpufreq driver for Exynos4x12 cpufreq: exynos: remove Exynos4x12 specific cpufreq driver support cpufreq: remove no longer needed CPU_FREQ_BOOST_SW config option arch/arm/boot/dts/exynos4212.dtsi | 81 arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 4 + arch/arm/boot/dts/exynos4412-origen.dts | 4 + arch/arm/boot/dts/exynos4412-trats2.dts | 4 + arch/arm/boot/dts/exynos4412.dtsi | 83 + arch/arm/mach-exynos/Kconfig| 2 + arch/arm/mach-exynos/exynos.c | 2 + drivers/clk/samsung/clk-exynos4.c | 50 + drivers/cpufreq/Kconfig | 4 - drivers/cpufreq/Kconfig.arm | 38 drivers/cpufreq/Makefile| 2 - drivers/cpufreq/cpufreq-dt.c| 3 + drivers/cpufreq/exynos-cpufreq.c| 236 drivers/cpufreq/exynos-cpufreq.h| 72 drivers/cpufreq/exynos4x12-cpufreq.c| 236 drivers/cpufreq/freq_table.c| 10 +- include/linux/cpufreq.h | 1 + 17 files changed, 241 insertions(+), 591 deletions(-) delete mode 100644 drivers/cpufreq/exynos-cpufreq.c delete mode 100644 drivers/cpufreq/exynos-cpufreq.h delete mode 100644 drivers/cpufreq/exynos4x12-cpufreq.c -- 1.9.1 -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
