Re: PS3: sg chaining support
Jens Axboe wrote: On Tue, Jul 17 2007, Geoff Levand wrote: I'm wondering what the status of this work is. The patch I've seen no longer applies to ps3/system-bus.c. A rebase to linux-2.6.git a5fcaa210626a79465321e344c91a6a7dc3881fa is below, but untested, as I don't have the other patches to do the build. I rebased the tree yesterday to resolve that conflict, it's in the sglist-arch branch now. The result is identical to yours. Shall I take this as an acked-by? I did some casual testing on PS3 with linux-2.6-block.git #sglist-arch 7c132dd2c151dd559baa64abae7a39e9e9a82f28 and it seems to work OK. Acked-by: Geoff Levand [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: PS3 Storage Driver O_DIRECT issue
Geert Uytterhoeven wrote: On Fri, 13 Jul 2007, Olaf Hering wrote: This driver (or the generic PS3 code) has appearently problems with O_DIRECT. glibc aborts parted because the malloc metadata get corrupted. While it is reproducible, the place where it crashes changes with every version of the debug attempt. I dont have a handle right now, all I know is that the metadata after a malloc area get overwritten with zeros. Can you have a look at this? parted /dev/ps3da print (a few times) I can't seem to reproduce this with parted 1.7.1-5.1 (from Debian etch/lenny/sid) and kernel 2.6.22-g77320894. Hi. I found this happens on Fedora 7: [EMAIL PROTECTED] ~]# uname -a Linux ps3-nfs 2.6.22-ps3-linux-dev-g4d898766-dirty #1 SMP Wed Jul 11 13:29:46 PDT 2007 ppc64 ppc64 ppc64 GNU/Linux [EMAIL PROTECTED] ~]# parted --version parted (GNU parted) 1.8.6 Here is the error message from parted: Command History: print Error: SEGV_MAPERR (Address not mapped to object) Backtrace has 20 calls on stack: 20: /usr/lib/libparted-1.8.so.6(ped_assert+0xb0) [0xfb7ea50] 19: parted [0x1000c6dc] 18: [0x100350] 17: [(nil)] 16: /lib/libc.so.6 [0xfdcfe64] 15: /lib/libc.so.6 [0xfdd0b34] 14: /lib/libc.so.6(__libc_memalign+0xec) [0xfdd1e1c] 13: /lib/libc.so.6(posix_memalign+0xbc) [0xfdd207c] 12: /usr/lib/libparted-1.8.so.6 [0xfb8f42c] 11: /usr/lib/libparted-1.8.so.6(ped_device_read+0x164) [0xfb7f5f4] 10: /usr/lib/libparted-1.8.so.6(ped_geometry_read+0x16c) [0xfb89a5c] 9: /usr/lib/libparted-1.8.so.6 [0xfba739c] 8: /usr/lib/libparted-1.8.so.6(ped_file_system_probe_specific+0x104) [0xfb80d04] 7: /usr/lib/libparted-1.8.so.6(ped_file_system_probe+0xec) [0xfb8134c] 6: /usr/lib/libparted-1.8.so.6 [0xfbbcc38] 5: /usr/lib/libparted-1.8.so.6 [0xfbbcfb4] 4: /usr/lib/libparted-1.8.so.6(ped_disk_new+0xc0) [0xfb88bf0] 3: parted [0x10006e00] 2: parted(command_run+0x1c) [0x10004d8c] 1: parted(interactive_mode+0x134) [0x1000e4b4] Aborted - To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
PS3: sg chaining support
Hi Jens.
Geert Uytterhoeven wrote:
-- Forwarded message --
Date: Mon, 16 Jul 2007 11:47:26 +0200
From: Jens Axboe [EMAIL PROTECTED]
To: [EMAIL PROTECTED], linux-scsi@vger.kernel.org
Cc: Jens Axboe [EMAIL PROTECTED], [EMAIL PROTECTED]
Subject: [PATCH 12/33] PPC: sg chaining support
This updates the ppc iommu/pci dma mappers to sg chaining.
Cc: [EMAIL PROTECTED]
Signed-off-by: Jens Axboe [EMAIL PROTECTED]
---
arch/powerpc/kernel/dma_64.c|5 +++--
arch/powerpc/kernel/ibmebus.c | 11 ++-
arch/powerpc/kernel/iommu.c | 18 +++---
arch/powerpc/platforms/ps3/system-bus.c |5 +++--
include/asm-powerpc/dma-mapping.h |2 +-
include/asm-powerpc/scatterlist.h |2 ++
6 files changed, 26 insertions(+), 17 deletions(-)
I'm wondering what the status of this work is. The patch I've
seen no longer applies to ps3/system-bus.c. A rebase to
linux-2.6.git a5fcaa210626a79465321e344c91a6a7dc3881fa is below,
but untested, as I don't have the other patches to do the build.
-Geoff
Subject: PS3: sg chaining support
This updates the ps3 system bus dma mappers to sg chaining.
CC: Jens Axboe [EMAIL PROTECTED]
From: Geoff Levand [EMAIL PROTECTED]
---
arch/powerpc/platforms/ps3/system-bus.c | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
--- a/arch/powerpc/platforms/ps3/system-bus.c
+++ b/arch/powerpc/platforms/ps3/system-bus.c
@@ -622,17 +622,18 @@ static void ps3_unmap_single(struct devi
}
}
-static int ps3_sb_map_sg(struct device *_dev, struct scatterlist *sg, int
nents,
- enum dma_data_direction direction)
+static int ps3_sb_map_sg(struct device *_dev, struct scatterlist *sgl,
+ int nents, enum dma_data_direction direction)
{
#if defined(CONFIG_PS3_DYNAMIC_DMA)
BUG_ON(do);
return -EPERM;
#else
struct ps3_system_bus_device *dev = ps3_dev_to_system_bus_dev(_dev);
+ struct scatterlist *sg;
int i;
- for (i = 0; i nents; i++, sg++) {
+ for_each_sg(sgl, sg, nents, i) {
int result = ps3_dma_map(dev-d_region,
page_to_phys(sg-page) + sg-offset, sg-length,
sg-dma_address, 0);
@@ -650,7 +651,7 @@ static int ps3_sb_map_sg(struct device *
#endif
}
-static int ps3_ioc0_map_sg(struct device *_dev, struct scatterlist *sg,
+static int ps3_ioc0_map_sg(struct device *_dev, struct scatterlist *sgl,
int nents,
enum dma_data_direction direction)
{
@@ -658,7 +659,7 @@ static int ps3_ioc0_map_sg(struct device
return 0;
}
-static void ps3_sb_unmap_sg(struct device *_dev, struct scatterlist *sg,
+static void ps3_sb_unmap_sg(struct device *_dev, struct scatterlist *sgl,
int nents, enum dma_data_direction direction)
{
#if defined(CONFIG_PS3_DYNAMIC_DMA)
@@ -666,7 +667,7 @@ static void ps3_sb_unmap_sg(struct devic
#endif
}
-static void ps3_ioc0_unmap_sg(struct device *_dev, struct scatterlist *sg,
+static void ps3_ioc0_unmap_sg(struct device *_dev, struct scatterlist *sgl,
int nents, enum dma_data_direction direction)
{
BUG();
-
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [patch 6/7] ps3: ROM Storage Driver
Benjamin Herrenschmidt wrote: On Wed, 2007-05-30 at 12:13 +0200, Christoph Hellwig wrote: For any sane hypervisor or hardware the copy should be worth than that. Then again a sane hardware or hypervisor would support SG requests.. Agreed... Sony should fix that, it's a bit ridiculous. Yes, if only to put an end to seeing this kind of comment over and over again. -Geoff - To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
