from:"Xose Vazquez Perez"

[PATCH] scsi: scsi_dh: replace too broad "TP9" string with the exact models

2018-04-06 Thread Xose Vazquez Perez

SGI/TP9100 is not a RDAC array:
^^^
https://git.opensvc.com/gitweb.cgi?p=multipath-tools/.git;a=blob;f=libmultipath/hwtable.c;h=88b4700beb1d8940008020fbe4c3cd97d62f4a56;hb=HEAD#l235

This reverts partially the 35204772ea034b380bc9d8942699dc03898e5c13 commit

Cc: NetApp RDAC team <ng-eseries-upstream-maintain...@netapp.com>
Cc: Hannes Reinecke <h...@suse.de>
Cc: James E.J. Bottomley <j...@linux.vnet.ibm.com>
Cc: Martin K. Petersen <martin.peter...@oracle.com>
Cc: SCSI ML <linux-scsi@vger.kernel.org>
Cc: DM ML <dm-de...@redhat.com>
Signed-off-by: Xose Vazquez Perez <xose.vazq...@gmail.com>
---
 drivers/scsi/scsi_dh.c | 5 -
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/scsi/scsi_dh.c b/drivers/scsi/scsi_dh.c
index b88b5dbbc444..d2fc6521f8ad 100644
--- a/drivers/scsi/scsi_dh.c
+++ b/drivers/scsi/scsi_dh.c
@@ -58,7 +58,10 @@ static const struct scsi_dh_blist scsi_dh_blist[] = {
{"IBM", "3526", "rdac", },
{"IBM", "3542", "rdac", },
{"IBM", "3552", "rdac", },
-   {"SGI", "TP9",  "rdac", },
+   {"SGI", "TP9300",   "rdac"},
+   {"SGI", "TP9400",   "rdac"},
+   {"SGI", "TP9500",   "rdac"},
+   {"SGI", "TP9700",   "rdac"},
{"SGI", "IS",   "rdac", },
{"STK", "OPENstorage",  "rdac", },
{"STK", "FLEXLINE 380", "rdac", },
-- 
2.14.3

[PATCH resend] scsi: devinfo: delete duplicate "Generic"/"USB Storage-SMC" device

2018-04-06 Thread Xose Vazquez Perez

Revision is irrelevant, it's unused by the scsi infrastructure.

$ egrep "Generic.*Storage-SMC" /proc/scsi/device_info
'Generic' 'USB Storage-SMC' 0x402
'Generic' 'USB Storage-SMC' 0x402

Cc: Hannes Reinecke <h...@suse.de>
Cc: Martin K. Petersen <martin.peter...@oracle.com>
Cc: James E.J. Bottomley <j...@linux.vnet.ibm.com>
Cc: SCSI ML <linux-scsi@vger.kernel.org>
Signed-off-by: Xose Vazquez Perez <xose.vazq...@gmail.com>
---
 drivers/scsi/scsi_devinfo.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/scsi/scsi_devinfo.c b/drivers/scsi/scsi_devinfo.c
index f3b117246d47..384bed37b13b 100644
--- a/drivers/scsi/scsi_devinfo.c
+++ b/drivers/scsi/scsi_devinfo.c
@@ -168,8 +168,7 @@ static struct {
{"easyRAID", "F8", NULL, BLIST_NOREPORTLUN},
{"FSC", "CentricStor", "*", BLIST_SPARSELUN | BLIST_LARGELUN},
{"Generic", "USB SD Reader", "1.00", BLIST_FORCELUN | BLIST_INQUIRY_36},
-   {"Generic", "USB Storage-SMC", "0180", BLIST_FORCELUN | 
BLIST_INQUIRY_36},
-   {"Generic", "USB Storage-SMC", "0207", BLIST_FORCELUN | 
BLIST_INQUIRY_36},
+   {"Generic", "USB Storage-SMC", NULL, BLIST_FORCELUN | 
BLIST_INQUIRY_36}, /* FW: 0180 and 0207 */
{"HITACHI", "DF400", "*", BLIST_REPORTLUN2},
{"HITACHI", "DF500", "*", BLIST_REPORTLUN2},
{"HITACHI", "DISK-SUBSYSTEM", "*", BLIST_REPORTLUN2},
-- 
2.14.3

[PATCH RFC] scsi: devinfo: remove dasd devices from the scsi subsystem

2018-03-16 Thread Xose Vazquez Perez

Only present through ccw bus.

Cc: Matthias Rudolph <matthias.rudo...@hitachivantara.com>
Cc: Takahiro Yasui <takahiro.ya...@hitachivantara.com>
Cc: Anthony Cheung <anthony.che...@hpe.com>
Cc: Mike Christie <mchri...@redhat.com>
Cc: Martin K. Petersen <martin.peter...@oracle.com>
Cc: James E.J. Bottomley <j...@linux.vnet.ibm.com>
Cc: s390 ML <linux-s...@vger.kernel.org>
Cc: SCSI ML <linux-scsi@vger.kernel.org>
Cc: device-mapper development <dm-de...@redhat.com>
Signed-off-by: Xose Vazquez Perez <xose.vazq...@gmail.com>
---
 drivers/scsi/scsi_devinfo.c | 10 --
 1 file changed, 10 deletions(-)

diff --git a/drivers/scsi/scsi_devinfo.c b/drivers/scsi/scsi_devinfo.c
index b119b5bfb4d3..31985dd3f4b6 100644
--- a/drivers/scsi/scsi_devinfo.c
+++ b/drivers/scsi/scsi_devinfo.c
@@ -175,11 +175,6 @@ static struct {
{"HITACHI", "DISK-SUBSYSTEM", "*", BLIST_REPORTLUN2},
{"HITACHI", "HUS1530", "*", BLIST_NO_DIF},
{"HITACHI", "OPEN-", "*", BLIST_REPORTLUN2 | BLIST_TRY_VPD_PAGES},
-   {"HITACHI", "OP-C-", "*", BLIST_SPARSELUN | BLIST_LARGELUN},
-   {"HITACHI", "3380-", "*", BLIST_SPARSELUN | BLIST_LARGELUN},
-   {"HITACHI", "3390-", "*", BLIST_SPARSELUN | BLIST_LARGELUN},
-   {"HITACHI", "6586-", "*", BLIST_SPARSELUN | BLIST_LARGELUN},
-   {"HITACHI", "6588-", "*", BLIST_SPARSELUN | BLIST_LARGELUN},
{"HP", "A6189A", NULL, BLIST_SPARSELUN | BLIST_LARGELUN},   /* HP 
VA7400 */
{"HP", "OPEN-", "*", BLIST_REPORTLUN2 | BLIST_TRY_VPD_PAGES}, /* HP XP 
Arrays */
{"HP", "NetRAID-4M", NULL, BLIST_FORCELUN},
@@ -187,11 +182,6 @@ static struct {
{"HP", "C1557A", NULL, BLIST_FORCELUN},
{"HP", "C3323-300", "4269", BLIST_NOTQ},
{"HP", "C5713A", NULL, BLIST_NOREPORTLUN},
-   {"HP", "OP-C-", "*", BLIST_SPARSELUN | BLIST_LARGELUN},
-   {"HP", "3380-", "*", BLIST_SPARSELUN | BLIST_LARGELUN},
-   {"HP", "3390-", "*", BLIST_SPARSELUN | BLIST_LARGELUN},
-   {"HP", "6586-", "*", BLIST_SPARSELUN | BLIST_LARGELUN},
-   {"HP", "6588-", "*", BLIST_SPARSELUN | BLIST_LARGELUN},
{"IBM", "AuSaV1S2", NULL, BLIST_FORCELUN},
{"IBM", "ProFibre 4000R", "*", BLIST_SPARSELUN | BLIST_LARGELUN},
{"IBM", "2105", NULL, BLIST_RETRY_HWERROR},
-- 
2.14.3

[PATCH] scsi: devinfo: remove DF arrays from HP

2018-03-15 Thread Xose Vazquez Perez

Matthias did confirm that there are no such devices.

Cc: Matthias Rudolph <matthias.rudo...@hitachivantara.com>
Cc: Anthony Cheung <anthony.che...@hpe.com>
Cc: Takahiro Yasui <takahiro.ya...@hitachivantara.com>
Cc: Mike Christie <mchri...@redhat.com>
Cc: Martin K. Petersen <martin.peter...@oracle.com>
Cc: James E.J. Bottomley <j...@linux.vnet.ibm.com>
Cc: SCSI ML <linux-scsi@vger.kernel.org>
Cc: device-mapper development <dm-de...@redhat.com>
Signed-off-by: Xose Vazquez Perez <xose.vazq...@gmail.com>
---
 drivers/scsi/scsi_devinfo.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/scsi/scsi_devinfo.c b/drivers/scsi/scsi_devinfo.c
index f3b117246d47..b119b5bfb4d3 100644
--- a/drivers/scsi/scsi_devinfo.c
+++ b/drivers/scsi/scsi_devinfo.c
@@ -187,8 +187,6 @@ static struct {
{"HP", "C1557A", NULL, BLIST_FORCELUN},
{"HP", "C3323-300", "4269", BLIST_NOTQ},
{"HP", "C5713A", NULL, BLIST_NOREPORTLUN},
-   {"HP", "DF400", "*", BLIST_REPORTLUN2},
-   {"HP", "DF500", "*", BLIST_REPORTLUN2},
{"HP", "OP-C-", "*", BLIST_SPARSELUN | BLIST_LARGELUN},
{"HP", "3380-", "*", BLIST_SPARSELUN | BLIST_LARGELUN},
{"HP", "3390-", "*", BLIST_SPARSELUN | BLIST_LARGELUN},
-- 
2.14.3

[PATCH resend] scsi: devinfo: add HP DISK-SUBSYSTEM device, for HP XP arrays

2018-03-15 Thread Xose Vazquez Perez

"The DISK-SUBSYSTEM is a special model name returned when LUs
are not installed. For example, when LU#0 is not installed in "OPEN-"
models, LU#0 is detected as the DISK-SUBSYSTEM model":
https://marc.info/?l=linux-scsi=125424006417825

It's missing for HP XP rebranded arrays, "HP"/"OPEN-".
Only the HITACHI one is present:
13f7e5acc8b329080672c13f05f252ace5b79825
627511e3e67553b04f6917c03e39b797df210e04

Cc: Anthony Cheung <anthony.che...@hpe.com>
Cc: Takahiro Yasui <takahiro.ya...@hitachivantara.com>
Cc: Matthias Rudolph <matthias.rudo...@hitachivantara.com>
Cc: Martin K. Petersen <martin.peter...@oracle.com>
Cc: James E.J. Bottomley <j...@linux.vnet.ibm.com>
Cc: SCSI ML <linux-scsi@vger.kernel.org>
Signed-off-by: Xose Vazquez Perez <xose.vazq...@gmail.com>
---
 drivers/scsi/scsi_devinfo.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/scsi/scsi_devinfo.c b/drivers/scsi/scsi_devinfo.c
index f3b117246d47..4a2d276c42eb 100644
--- a/drivers/scsi/scsi_devinfo.c
+++ b/drivers/scsi/scsi_devinfo.c
@@ -189,6 +189,7 @@ static struct {
{"HP", "C5713A", NULL, BLIST_NOREPORTLUN},
{"HP", "DF400", "*", BLIST_REPORTLUN2},
{"HP", "DF500", "*", BLIST_REPORTLUN2},
+   {"HP", "DISK-SUBSYSTEM", "*", BLIST_REPORTLUN2},
{"HP", "OP-C-", "*", BLIST_SPARSELUN | BLIST_LARGELUN},
{"HP", "3380-", "*", BLIST_SPARSELUN | BLIST_LARGELUN},
{"HP", "3390-", "*", BLIST_SPARSELUN | BLIST_LARGELUN},
-- 
2.14.3

[PATCH] scsi: devinfo: delete duplicate "Generic"/"USB Storage-SMC" device

2018-03-04 Thread Xose Vazquez Perez

Revision is irrelevant, it's unused by the scsi infrastructure.

Cc: Hannes Reinecke <h...@suse.de>
Cc: Martin K. Petersen <martin.peter...@oracle.com>
Cc: James E.J. Bottomley <j...@linux.vnet.ibm.com>
Cc: SCSI ML <linux-scsi@vger.kernel.org>
Signed-off-by: Xose Vazquez Perez <xose.vazq...@gmail.com>
---
 drivers/scsi/scsi_devinfo.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/scsi/scsi_devinfo.c b/drivers/scsi/scsi_devinfo.c
index f3b117246d47..384bed37b13b 100644
--- a/drivers/scsi/scsi_devinfo.c
+++ b/drivers/scsi/scsi_devinfo.c
@@ -168,8 +168,7 @@ static struct {
{"easyRAID", "F8", NULL, BLIST_NOREPORTLUN},
{"FSC", "CentricStor", "*", BLIST_SPARSELUN | BLIST_LARGELUN},
{"Generic", "USB SD Reader", "1.00", BLIST_FORCELUN | BLIST_INQUIRY_36},
-   {"Generic", "USB Storage-SMC", "0180", BLIST_FORCELUN | 
BLIST_INQUIRY_36},
-   {"Generic", "USB Storage-SMC", "0207", BLIST_FORCELUN | 
BLIST_INQUIRY_36},
+   {"Generic", "USB Storage-SMC", NULL, BLIST_FORCELUN | 
BLIST_INQUIRY_36}, /* FW: 0180 and 0207 */
{"HITACHI", "DF400", "*", BLIST_REPORTLUN2},
{"HITACHI", "DF500", "*", BLIST_REPORTLUN2},
{"HITACHI", "DISK-SUBSYSTEM", "*", BLIST_REPORTLUN2},
-- 
2.14.3

[PATCH] scsi: devinfo: add HP DISK-SUBSYSTEM device, for HP XP arrays

2018-03-04 Thread Xose Vazquez Perez

"The DISK-SUBSYSTEM is a special model name returned when LUs
are not installed. For example, when LU#0 is not installed in "OPEN-"
models, LU#0 is detected as the DISK-SUBSYSTEM model":
https://marc.info/?l=linux-scsi=125424006417825

It's missing for HP XP rebranded arrays, "HP"/"OPEN-".
Only the HITACHI one is present:
13f7e5acc8b329080672c13f05f252ace5b79825
627511e3e67553b04f6917c03e39b797df210e04

Cc: Anthony Cheung <anthony.che...@hp.com>
Cc: Takahiro Yasui <takahiro.ya...@hds.com>
Cc: Matthias Rudolph <matthias.rudo...@hitachivantara.com>
Cc: Hannes Reinecke <h...@suse.de>
Cc: Martin K. Petersen <martin.peter...@oracle.com>
Cc: James E.J. Bottomley <j...@linux.vnet.ibm.com>
Cc: SCSI ML <linux-scsi@vger.kernel.org>
Signed-off-by: Xose Vazquez Perez <xose.vazq...@gmail.com>
---
 drivers/scsi/scsi_devinfo.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/scsi/scsi_devinfo.c b/drivers/scsi/scsi_devinfo.c
index f3b117246d47..4a2d276c42eb 100644
--- a/drivers/scsi/scsi_devinfo.c
+++ b/drivers/scsi/scsi_devinfo.c
@@ -189,6 +189,7 @@ static struct {
{"HP", "C5713A", NULL, BLIST_NOREPORTLUN},
{"HP", "DF400", "*", BLIST_REPORTLUN2},
{"HP", "DF500", "*", BLIST_REPORTLUN2},
+   {"HP", "DISK-SUBSYSTEM", "*", BLIST_REPORTLUN2},
{"HP", "OP-C-", "*", BLIST_SPARSELUN | BLIST_LARGELUN},
{"HP", "3380-", "*", BLIST_SPARSELUN | BLIST_LARGELUN},
{"HP", "3390-", "*", BLIST_SPARSELUN | BLIST_LARGELUN},
-- 
2.14.3

Re: [PATCH] scsi: remove extra white space at the end of the line

2018-01-22 Thread Xose Vazquez Perez

Jason Yan wrote:

> My editor always try to remove the extra white space at the end of the
> line when I make some changes. I'm tired of adjusting them manually.

A real (trailing) clean up is done with:
find -type f -exec sed -i 's/[[:cntrl:]]\+$//' {} +

Trailing spaces, tabs and ^L were deleted from drivers/scsi.
There is crap in the whole linux tree.

Re: [PATCH] scsi: handle ABORTED_COMMAND on Fujitsu ETERNUS

2018-01-17 Thread Xose Vazquez Perez

Martin Wilck wrote:

> On Wed, 2018-01-17 at 01:15 -0500, Martin K. Petersen wrote:
>> 
>> > +  if (!strncmp(scmd->device->vendor, "FUJITSU", 7)
>> > &&
>> > + !strncmp(scmd->device->model,
>> > "ETERNUS_DXM", 11) &&

Is DXM the S3 family?

>> Blacklist, please.
> 
> To make sure I understand correctly:
> 
> You'd like to spend a precious BLIST bit for this single device which
> uses vendor-specific ASC/Q?


A similar patch for SYMMETRIX was rejected recently:
https://marc.info/?t=15082243347


BTW, a BLIST patch for ETERNUS DXL (S2???) is also needed:
http://kernel.suse.com/cgit/kernel-source/plain/patches.fixes/scsi_scan-Send-TEST-UNIT-READY-to-LUN0-before-LUN-sc.patch?h=SLE15

[PATCH] scsi: devinfo: fix format of the device list

2018-01-15 Thread Xose Vazquez Perez

Replace "" with NULL for product revision level, and
merge TEXEL duplicate entries.

Cc: Hannes Reinecke <h...@suse.de>
Cc: Martin K. Petersen <martin.peter...@oracle.com>
Cc: James E.J. Bottomley <j...@linux.vnet.ibm.com>
Cc: SCSI ML <linux-scsi@vger.kernel.org>
Signed-off-by: Xose Vazquez Perez <xose.vazq...@gmail.com>
---
 drivers/scsi/scsi_devinfo.c | 7 +++
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/scsi/scsi_devinfo.c b/drivers/scsi/scsi_devinfo.c
index a15eb4d15114..769fdcba61df 100644
--- a/drivers/scsi/scsi_devinfo.c
+++ b/drivers/scsi/scsi_devinfo.c
@@ -109,8 +109,8 @@ static struct {
 * seagate controller, which causes SCSI code to reset bus.
 */
{"HP", "C1750A", "3226", BLIST_NOLUN},  /* scanjet iic */
-   {"HP", "C1790A", "", BLIST_NOLUN},  /* scanjet iip */
-   {"HP", "C2500A", "", BLIST_NOLUN},  /* scanjet iicx */
+   {"HP", "C1790A", NULL, BLIST_NOLUN},/* scanjet iip */
+   {"HP", "C2500A", NULL, BLIST_NOLUN},/* scanjet iicx */
{"MEDIAVIS", "CDR-H93MV", "1.31", BLIST_NOLUN}, /* locks up */
{"MICROTEK", "ScanMaker II", "5.61", BLIST_NOLUN},  /* responds to 
all lun */
{"MITSUMI", "CD-R CR-2201CS", "6119", BLIST_NOLUN}, /* locks up */
@@ -120,7 +120,7 @@ static struct {
{"QUANTUM", "FIREBALL ST4.3S", "0F0C", BLIST_NOLUN},/* locks up */
{"RELISYS", "Scorpio", NULL, BLIST_NOLUN},  /* responds to all lun 
*/
{"SANKYO", "CP525", "6.64", BLIST_NOLUN},   /* causes failed REQ 
SENSE, extra reset */
-   {"TEXEL", "CD-ROM", "1.06", BLIST_NOLUN},
+   {"TEXEL", "CD-ROM", "1.06", BLIST_NOLUN | BLIST_BORKEN},
{"transtec", "T5008", "0001", BLIST_NOREPORTLUN },
{"YAMAHA", "CDR100", "1.00", BLIST_NOLUN},  /* locks up */
{"YAMAHA", "CDR102", "1.00", BLIST_NOLUN},  /* locks up */
@@ -255,7 +255,6 @@ static struct {
{"ST650211", "CF", NULL, BLIST_RETRY_HWERROR},
{"SUN", "T300", "*", BLIST_SPARSELUN},
{"SUN", "T4", "*", BLIST_SPARSELUN},
-   {"TEXEL", "CD-ROM", "1.06", BLIST_BORKEN},
{"Tornado-", "F4", "*", BLIST_NOREPORTLUN},
{"TOSHIBA", "CDROM", NULL, BLIST_ISROM},
{"TOSHIBA", "CD-ROM", NULL, BLIST_ISROM},
-- 
2.14.3

Re: scsi: Always retry internal target error

2018-01-10 Thread Xose Vazquez Perez

> On 10/17/2017 09:11 AM, Hannes Reinecke wrote:
>> EMC Symmetrix is returning 'internal target error' for a variety
>> of conditions, most of which will be transient.
>> So we should always retry it, even with failfast set.
>> Otherwise we'd get spurious path flaps with multipath.
>> 
>> Signed-off-by: Hannes Reinecke 
>> ---
>>  drivers/scsi/scsi_error.c | 13 +
>>  1 file changed, 13 insertions(+)
>> 
>> diff --git a/drivers/scsi/scsi_error.c b/drivers/scsi/scsi_error.c
>> index 5086489..5722c2e 100644
>> --- a/drivers/scsi/scsi_error.c
>> +++ b/drivers/scsi/scsi_error.c
>> @@ -497,6 +497,16 @@ int scsi_check_sense(struct scsi_cmnd *scmd)
>>  if (sshdr.asc == 0x10) /* DIF */
>>  return SUCCESS;
>>  
>> +if (!strncmp(scmd->device->vendor, "EMC", 3) &&
>> +!strncmp(scmd->device->model, "SYMMETRIX", 9) &&
>> +(sshdr.asc == 0x44) && (sshdr.ascq == 0x0)) {
>> +/*
>> + * EMC Symmetrix returns 'Internal target failure'
>> + * for a variety of internal issues, all of which
>> + * can be recovered by retry.
>> + */
>> +return ADD_TO_MLQUEUE;
>> +}
>>  return NEEDS_RETRY;
>>  case NOT_READY:
>>  case UNIT_ATTENTION:
>> @@ -1846,6 +1856,9 @@ int scsi_decide_disposition(struct scsi_cmnd *scmd)
>>  rtn = scsi_check_sense(scmd);
>>  if (rtn == NEEDS_RETRY)
>>  goto maybe_retry;
>> +else if (rtn == ADD_TO_MLQUEUE)
>> +/* Always enforce a retry for ADD_TO_MLQUEUE */
>> +rtn = NEEDS_RETRY;
>>  /* if rtn == FAILED, we have no sense information;
>>   * returning FAILED will wake the error handler thread
>>   * to collect the sense and redo the decide
>> 

On 10/18/2017 07:27 AM, Hannes Reinecke wrote:
>> Yeah, you are right.
>> Will be adding a blacklist entry for this.


Is there a new patch ongoing?

[PATCH] scsi_dh: fix format of struct members

2017-12-16 Thread Xose Vazquez Perez

Remove useless trailing comma and space.

Cc: Hannes Reinecke <h...@suse.de>
Cc: Martin K. Petersen <martin.peter...@oracle.com>
Cc: James E.J. Bottomley <j...@linux.vnet.ibm.com>
Cc: SCSI ML <linux-scsi@vger.kernel.org>
Signed-off-by: Xose Vazquez Perez <xose.vazq...@gmail.com>
---
 drivers/scsi/scsi_dh.c | 66 +-
 1 file changed, 33 insertions(+), 33 deletions(-)

diff --git a/drivers/scsi/scsi_dh.c b/drivers/scsi/scsi_dh.c
index b88b5dbbc444..bbbe279970e4 100644
--- a/drivers/scsi/scsi_dh.c
+++ b/drivers/scsi/scsi_dh.c
@@ -36,43 +36,43 @@ struct scsi_dh_blist {
 };
 
 static const struct scsi_dh_blist scsi_dh_blist[] = {
-   {"DGC", "RAID", "emc" },
-   {"DGC", "DISK", "emc" },
-   {"DGC", "VRAID","emc" },
+   {"DGC", "RAID", "emc"},
+   {"DGC", "DISK", "emc"},
+   {"DGC", "VRAID","emc"},
 
-   {"COMPAQ", "MSA1000 VOLUME","hp_sw" },
-   {"COMPAQ", "HSV110","hp_sw" },
+   {"COMPAQ", "MSA1000 VOLUME","hp_sw"},
+   {"COMPAQ", "HSV110","hp_sw"},
{"HP", "HSV100","hp_sw"},
{"DEC", "HSG80","hp_sw"},
 
-   {"IBM", "1722", "rdac", },
-   {"IBM", "1724", "rdac", },
-   {"IBM", "1726", "rdac", },
-   {"IBM", "1742", "rdac", },
-   {"IBM", "1745", "rdac", },
-   {"IBM", "1746", "rdac", },
-   {"IBM", "1813", "rdac", },
-   {"IBM", "1814", "rdac", },
-   {"IBM", "1815", "rdac", },
-   {"IBM", "1818", "rdac", },
-   {"IBM", "3526", "rdac", },
-   {"IBM", "3542", "rdac", },
-   {"IBM", "3552", "rdac", },
-   {"SGI", "TP9",  "rdac", },
-   {"SGI", "IS",   "rdac", },
-   {"STK", "OPENstorage",  "rdac", },
-   {"STK", "FLEXLINE 380", "rdac", },
-   {"STK", "BladeCtlr","rdac", },
-   {"SUN", "CSM",  "rdac", },
-   {"SUN", "LCSM100",  "rdac", },
-   {"SUN", "STK6580_6780", "rdac", },
-   {"SUN", "SUN_6180", "rdac", },
-   {"SUN", "ArrayStorage", "rdac", },
-   {"DELL", "MD3", "rdac", },
-   {"NETAPP", "INF-01-00", "rdac", },
-   {"LSI", "INF-01-00","rdac", },
-   {"ENGENIO", "INF-01-00","rdac", },
-   {NULL, NULL,NULL },
+   {"IBM", "1722", "rdac"},
+   {"IBM", "1724", "rdac"},
+   {"IBM", "1726", "rdac"},
+   {"IBM", "1742", "rdac"},
+   {"IBM", "1745", "rdac"},
+   {"IBM", "1746", "rdac"},
+   {"IBM", "1813", "rdac"},
+   {"IBM", "1814", "rdac"},
+   {"IBM", "1815", "rdac"},
+   {"IBM", "1818", "rdac"},
+   {"IBM", "3526", "rdac"},
+   {"IBM", "3542", "rdac"},
+   {"IBM", "3552", "rdac"},
+   {"SGI", "TP9",  "rdac"},
+   {"SGI", "IS",   "rdac"},
+   {"STK", "OPENstorage",  "rdac"},
+   {"STK", "FLEXLINE 380", "rdac"},
+   {"STK", "BladeCtlr","rdac"},
+   {"SUN", "CSM",  "rdac"},
+   {"SUN", "LCSM100",  "rdac"},
+   {"SUN", "STK6580_6780", "rdac"},
+   {"SUN", "SUN_6180", "rdac"},
+   {"SUN", "ArrayStorage", "rdac"},
+   {"DELL", "MD3", "rdac"},
+   {"NETAPP", "INF-01-00", "rdac"},
+   {"LSI", "INF-01-00","rdac"},
+   {"ENGENIO", "INF-01-00","rdac"},
+   {NULL, NULL,NULL},
 };
 
 static const char *
-- 
2.14.3

scsi_devinfo: devices and pattern matching

2017-12-16 Thread Xose Vazquez Perez

Hi,

After last pattern matching changes, maybe some entries should be revised:


Empty strings(current meaning?):
{"", "Scanner", "1.80", BLIST_NOLUN},   /* responds to all lun */
{"Promise", "", NULL, BLIST_SPARSELUN},
{"HP", "C1790A", "", BLIST_NOLUN},  /* scanjet iip */
{"HP", "C2500A", "", BLIST_NOLUN},  /* scanjet iicx */


Overlapping(?) strings(remove one???):
{"DELL", "PV660F", NULL, BLIST_SPARSELUN},
{"DELL", "PV660F   PSEUDO", NULL, BLIST_SPARSELUN},

{"NRC", "MBR-7", NULL, BLIST_FORCELUN | BLIST_SINGLELUN},
{"NRC", "MBR-7.4", NULL, BLIST_FORCELUN | BLIST_SINGLELUN},

{"Promise", "", NULL, BLIST_SPARSELUN},
{"Promise", "VTrak E610f", NULL, BLIST_SPARSELUN | BLIST_NO_RSOC},


Odd "revision level" string(is it right? EOT?):
{"SEAGATE", "ST157N", "\004|j", BLIST_NOLUN},


Duplicate strings(They should be merged):
{"TEXEL", "CD-ROM", "1.06", BLIST_BORKEN},
{"TEXEL", "CD-ROM", "1.06", BLIST_NOLUN},


Keep in mind, for future patches, that there are regex metacharacters(!!):
{"IOMEGA", "Io20S *F", NULL, BLIST_KEY},
{"INSITE", "Floptical   F*8I", NULL, BLIST_KEY},
{"DELL", "PSEUDO DEVICE .", NULL, BLIST_SPARSELUN}, /* Dell PV 530F 
*/


For homogeneity reasons, should "*" revision level be replaced by NULL?


And the current pattern matching algorithm should be described clearer, right
now it's a bit confused.


Thank you.

[PATCH] scsi: scsi_devinfo: replace "Dell PV 650F" with "EMC CLARiiON"

2017-11-23 Thread Xose Vazquez Perez

The Dell PV650F is a re-branded CLARiiON FC5700.
And DGC/RAID,DISK identifies all CLARiiON family.

Cc: Martin K. Petersen <martin.peter...@oracle.com>
Cc: James E.J. Bottomley <j...@linux.vnet.ibm.com>
Cc: SCSI ML <linux-scsi@vger.kernel.org>
Signed-off-by: Xose Vazquez Perez <xose.vazq...@gmail.com>
---
 drivers/scsi/scsi_devinfo.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/scsi/scsi_devinfo.c b/drivers/scsi/scsi_devinfo.c
index fe5a9ea27b5e..97f0e24341c9 100644
--- a/drivers/scsi/scsi_devinfo.c
+++ b/drivers/scsi/scsi_devinfo.c
@@ -159,8 +159,8 @@ static struct {
{"DELL", "PSEUDO DEVICE .", NULL, BLIST_SPARSELUN}, /* Dell PV 530F 
*/
{"DELL", "PV530F", NULL, BLIST_SPARSELUN},
{"DELL", "PERCRAID", NULL, BLIST_FORCELUN},
-   {"DGC", "RAID", NULL, BLIST_SPARSELUN}, /* Dell PV 650F, storage on LUN 
0 */
-   {"DGC", "DISK", NULL, BLIST_SPARSELUN}, /* Dell PV 650F, no storage on 
LUN 0 */
+   {"DGC", "RAID", NULL, BLIST_SPARSELUN}, /* EMC CLARiiON, storage on LUN 
0 */
+   {"DGC", "DISK", NULL, BLIST_SPARSELUN}, /* EMC CLARiiON, no storage on 
LUN 0 */
{"EMC",  "Invista", "*", BLIST_SPARSELUN | BLIST_LARGELUN},
{"EMC", "SYMMETRIX", NULL, BLIST_SPARSELUN | BLIST_LARGELUN | 
BLIST_REPORTLUN2},
{"EMULEX", "MD21/S2 ESDI", NULL, BLIST_SINGLELUN},
-- 
2.14.3

[PATCH] scsi_dh: add new rdac devices

2017-11-17 Thread Xose Vazquez Perez

Add IBM 3542 and 3552, arrays: FAStT200 and FAStT500.
Add full STK OPENstorage family, arrays: 9176, D173, D178, D210, D220, D240 and 
D280.
Add STK BladeCtlr family, arrays: B210, B220, B240 and B280.

These changes were done in multipath-tools time ago.

Cc: NetApp RDAC team <ng-eseries-upstream-maintain...@netapp.com>
Cc: Hannes Reinecke <h...@suse.de>
Cc: Christophe Varoqui <christophe.varo...@opensvc.com>
Cc: Martin K. Petersen <martin.peter...@oracle.com>
Cc: James E.J. Bottomley <j...@linux.vnet.ibm.com>
Cc: SCSI ML <linux-scsi@vger.kernel.org>
Cc: device-mapper development <dm-de...@redhat.com>
Signed-off-by: Xose Vazquez Perez <xose.vazq...@gmail.com>
---
 drivers/scsi/scsi_dh.c | 5 -
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/scsi/scsi_dh.c b/drivers/scsi/scsi_dh.c
index 2b785d09d5bd..b88b5dbbc444 100644
--- a/drivers/scsi/scsi_dh.c
+++ b/drivers/scsi/scsi_dh.c
@@ -56,10 +56,13 @@ static const struct scsi_dh_blist scsi_dh_blist[] = {
{"IBM", "1815", "rdac", },
{"IBM", "1818", "rdac", },
{"IBM", "3526", "rdac", },
+   {"IBM", "3542", "rdac", },
+   {"IBM", "3552", "rdac", },
{"SGI", "TP9",  "rdac", },
{"SGI", "IS",   "rdac", },
-   {"STK", "OPENstorage D280", "rdac", },
+   {"STK", "OPENstorage",  "rdac", },
{"STK", "FLEXLINE 380", "rdac", },
+   {"STK", "BladeCtlr","rdac", },
{"SUN", "CSM",  "rdac", },
{"SUN", "LCSM100",  "rdac", },
{"SUN", "STK6580_6780", "rdac", },
-- 
2.14.3

[PATCH try #2] scsi_devinfo: apply to HP-rebranded the same flags as Hitachi

2017-11-17 Thread Xose Vazquez Perez

627511e3e modified some Hitachi entries:

Four models, OPEN-/DF400/DF500/DISK-SUBSYSTEM, can handle REPORT_LUN,
and the BLIST_REPORTLUN2 flag needs to be set. And DF600 doesn't require
any flags because it returns ANSI 03h (SPC).
~~~

The same should have been done also for HP counterparts.

Cc: Takahiro Yasui <takahiro.ya...@hds.com>
Cc: Mike Christie <micha...@cs.wisc.edu>
Cc: Matthias Rudolph <matthias.rudo...@hds.com>
Cc: Martin K. Petersen <martin.peter...@oracle.com>
Cc: James E.J. Bottomley <j...@linux.vnet.ibm.com>
Cc: SCSI ML <linux-scsi@vger.kernel.org>
Signed-off-by: Xose Vazquez Perez <xose.vazq...@gmail.com>
---
 drivers/scsi/scsi_devinfo.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/scsi/scsi_devinfo.c b/drivers/scsi/scsi_devinfo.c
index 2464569..44d8cfb 100644
--- a/drivers/scsi/scsi_devinfo.c
+++ b/drivers/scsi/scsi_devinfo.c
@@ -186,9 +186,8 @@ static struct {
{"HP", "C1557A", NULL, BLIST_FORCELUN},
{"HP", "C3323-300", "4269", BLIST_NOTQ},
{"HP", "C5713A", NULL, BLIST_NOREPORTLUN},
-   {"HP", "DF400", "*", BLIST_SPARSELUN | BLIST_LARGELUN},
-   {"HP", "DF500", "*", BLIST_SPARSELUN | BLIST_LARGELUN},
-   {"HP", "DF600", "*", BLIST_SPARSELUN | BLIST_LARGELUN},
+   {"HP", "DF400", "*", BLIST_REPORTLUN2},
+   {"HP", "DF500", "*", BLIST_REPORTLUN2},
{"HP", "OP-C-", "*", BLIST_SPARSELUN | BLIST_LARGELUN},
{"HP", "3380-", "*", BLIST_SPARSELUN | BLIST_LARGELUN},
{"HP", "3390-", "*", BLIST_SPARSELUN | BLIST_LARGELUN},
-- 
2.10.1

[PATCH] scsi_devinfo: apply to HP XP the same flags as Hitachi VSP

2017-11-17 Thread Xose Vazquez Perez

56f3d383f modified some Hitachi entries:

   HITACHI is always supporting VPD pages, even though it's claiming to
   support SCSI Revision 3 only.
~~~

The same should have been done also for HP-rebranded.

Cc: Hannes Reinecke <h...@suse.de>
Cc: Takahiro Yasui <takahiro.ya...@hds.com>
Cc: Matthias Rudolph <matthias.rudo...@hitachivantara.com>
Cc: Martin K. Petersen <martin.peter...@oracle.com>
Cc: James E.J. Bottomley <j...@linux.vnet.ibm.com>
Cc: SCSI ML <linux-scsi@vger.kernel.org>
Signed-off-by: Xose Vazquez Perez <xose.vazq...@gmail.com>
---
 drivers/scsi/scsi_devinfo.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/scsi_devinfo.c b/drivers/scsi/scsi_devinfo.c
index 320d0a81358d..3ab4d337bf55 100644
--- a/drivers/scsi/scsi_devinfo.c
+++ b/drivers/scsi/scsi_devinfo.c
@@ -182,7 +182,7 @@ static struct {
{"HITACHI", "6586-", "*", BLIST_SPARSELUN | BLIST_LARGELUN},
{"HITACHI", "6588-", "*", BLIST_SPARSELUN | BLIST_LARGELUN},
{"HP", "A6189A", NULL, BLIST_SPARSELUN | BLIST_LARGELUN},   /* HP 
VA7400 */
-   {"HP", "OPEN-", "*", BLIST_REPORTLUN2}, /* HP XP Arrays */
+   {"HP", "OPEN-", "*", BLIST_REPORTLUN2 | BLIST_TRY_VPD_PAGES}, /* HP XP 
Arrays */
{"HP", "NetRAID-4M", NULL, BLIST_FORCELUN},
{"HP", "HSV100", NULL, BLIST_REPORTLUN2 | BLIST_NOSTARTONADD},
{"HP", "C1557A", NULL, BLIST_FORCELUN},
-- 
2.14.3

Re: scsi: Add TRY_VPD_PAGES to HITACHI OPEN-V blacklist entry

2017-10-17 Thread Xose Vazquez Perez

On 10/17/2017 09:10 AM, Hannes Reinecke wrote:

> HITACHI is always supporting VPD pages, even though it's claiming
> to support SCSI Revision 3 only.


"HP/OPEN-" is also affected. HP XP is a rebrand of HITACHI VSP.

{"HP", "OPEN-", "*", BLIST_REPORTLUN2}, /* HP XP Arrays */


> Signed-off-by: Hannes Reinecke 
> ---
>  drivers/scsi/scsi_devinfo.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/scsi_devinfo.c b/drivers/scsi/scsi_devinfo.c
> index ae2ad84..a998585 100644
> --- a/drivers/scsi/scsi_devinfo.c
> +++ b/drivers/scsi/scsi_devinfo.c
> @@ -174,7 +174,7 @@ struct scsi_dev_info_list_table {
>   {"HITACHI", "DF500", "*", BLIST_REPORTLUN2},
>   {"HITACHI", "DISK-SUBSYSTEM", "*", BLIST_REPORTLUN2},
>   {"HITACHI", "HUS1530", "*", BLIST_NO_DIF},
> - {"HITACHI", "OPEN-", "*", BLIST_REPORTLUN2},
> + {"HITACHI", "OPEN-", "*", BLIST_REPORTLUN2 | BLIST_TRY_VPD_PAGES},
>   {"HITACHI", "OP-C-", "*", BLIST_SPARSELUN | BLIST_LARGELUN},
>   {"HITACHI", "3380-", "*", BLIST_SPARSELUN | BLIST_LARGELUN},
>   {"HITACHI", "3390-", "*", BLIST_SPARSELUN | BLIST_LARGELUN},
>

Re: iscsi (?): Unknown VPD Code: 0xc7

2017-03-24 Thread Xose Vazquez Perez

On 03/24/2017 09:16 PM, Xose Vazquez Perez wrote:

> Try to add "scsi_dev_flags=AIX:VDASD:0x1000" to the kernel
> command line in grub.

# echo "AIX:VDASD:0x1000" > /proc/scsi/device_info
should also work.

Re: iscsi (?): Unknown VPD Code: 0xc7

2017-03-24 Thread Xose Vazquez Perez

Harald Dunkel wrote:

> I am trying to use LIO on amd64 to provide block devices to some
> AIX 6.1 and 7.1 hosts. It works pretty well, except that I cannot
> create rootvg wpars on AIX 7.1. (rootvg wpars are containers
> running on their own volume group.)
> 
> The error message on AIX is
> 
> bash-4.3# mkwpar -O -D rootvg=yes devname=hdisk3 -n sample
> **
> ERROR
> mkwpar: 0960-587 hdisk3 has un-supported subclass type.
> 
> **


> Kernel is 4.9.13 (Debian backports). It shows several (maybe unrelated)
> lines in kernel.log
> 
> :
> Mar 23 08:46:05 nasl003b kernel: [ 1172.226643] Unknown VPD Code: 0xc7
> Mar 23 08:46:05 nasl003b kernel: [ 1172.279368] Unknown VPD Code: 0xc7
> Mar 23 08:46:06 nasl003b kernel: [ 1172.331243] Unknown VPD Code: 0xc7
> Mar 23 08:46:06 nasl003b kernel: [ 1172.380074] Unknown VPD Code: 0xc7
> Mar 23 08:47:02 nasl003b kernel: [ 1229.106384] Unknown VPD Code: 0xc7
> Mar 23 19:06:30 nasl003b kernel: [38396.514881] Unknown VPD Code: 0xc7
> Mar 23 19:06:30 nasl003b kernel: [38396.576499] Unknown VPD Code: 0xc7
> Mar 23 19:06:30 nasl003b kernel: [38396.624678] Unknown VPD Code: 0xc7
> :
> 
> What is it trying to tell me?

Maybe related to this SUSE patch(missing upstream):

>From 09040ffe64b67a66453c7cc7bf2d645a0b27aeaf Mon Sep 17 00:00:00 2001
From: Hannes Reinecke 
Date: Thu, 27 Oct 2016 09:20:23 +0200
Subject: [PATCH] scsi: Add 'AIX VDASD' to blacklist
References: bsc#1006469
Patch-Mainline: submitted to linux-scsi 2016/10/27

The AIX VDASD devices do support VPD pages, but implement
only SPC. So set BLIST_TRY_VPD_PAGS to correctly display
the VPD information in sysfs.

Signed-off-by: Hannes Reinecke 
---
 drivers/scsi/scsi_devinfo.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/scsi/scsi_devinfo.c b/drivers/scsi/scsi_devinfo.c
index cab178f..8d66051 100644
--- a/drivers/scsi/scsi_devinfo.c
+++ b/drivers/scsi/scsi_devinfo.c
@@ -136,6 +136,7 @@ static struct {
{"3PARdata", "VV", NULL, BLIST_REPORTLUN2},
{"ADAPTEC", "AACRAID", NULL, BLIST_FORCELUN},
{"ADAPTEC", "Adaptec 5400S", NULL, BLIST_FORCELUN},
+   {"AIX", "VDASD", NULL, BLIST_TRY_VPD_PAGES},
{"AFT PRO", "-IX CF", "0.0>", BLIST_FORCELUN},
{"BELKIN", "USB 2 HS-CF", "1.95",  BLIST_FORCELUN | BLIST_INQUIRY_36},
{"BROWNIE", "1200U3P", NULL, BLIST_NOREPORTLUN},
-- 
1.8.5.6


Try to add "scsi_dev_flags=AIX:VDASD:0x1000" to the kernel command
line in grub.

Re: [PATCH] scsi_devinfo: remove synchronous ALUA for NETAPP/RDAC devices

2016-11-11 Thread Xose Vazquez Perez

On 11/09/2016 08:38 AM, George, Martin wrote:

Drop this one.

> As discussed with Hannes, this is not required for ONTAP's LUN C-Mode
> as well. So the ALUA blacklisting may be removed here as well, and
> not just for NetApp RDAC.

OK, done in v2.

Thank you.

> -Original Message-
> From: Hannes Reinecke [mailto:h...@suse.de] 
> Sent: Wednesday, November 9, 2016 12:20 PM
> To: Xose Vazquez Perez <xose.vazq...@gmail.com>
> Cc: George, Martin <martin.geo...@netapp.com>; Stankey, Robert 
> <robert.stan...@netapp.com>; Schremmer, Steven <steve.schrem...@netapp.com>; 
> Stewart, Sean <sean.stew...@netapp.com>; Christophe Varoqui 
> <christophe.varo...@opensvc.com>; James E . J . Bottomley 
> <j...@linux.vnet.ibm.com>; Martin K . Petersen <martin.peter...@oracle.com>; 
> SCSI ML <linux-scsi@vger.kernel.org>; device-mapper development 
> <dm-de...@redhat.com>
> Subject: Re: [PATCH] scsi_devinfo: remove synchronous ALUA for NETAPP/RDAC 
> devices
> 
> On 11/08/2016 08:32 PM, Xose Vazquez Perez wrote:
>> NetApp did confirm this is only required for ONTAP(LUN C-Mode).
>>
>> Cc: Martin George <martin.geo...@netapp.com>
>> Cc: Robert Stankey <robert.stan...@netapp.com>
>> Cc: Steven Schremmer <steven.schrem...@netapp.com>
>> Cc: Sean Stewart <sean.stew...@netapp.com>
>> Cc: Hannes Reinecke <h...@suse.de>
>> Cc: Christophe Varoqui <christophe.varo...@opensvc.com>
>> Cc: James E.J. Bottomley <j...@linux.vnet.ibm.com>
>> Cc: Martin K. Petersen <martin.peter...@oracle.com>
>> Cc: SCSI ML <linux-scsi@vger.kernel.org>
>> Cc: device-mapper development <dm-de...@redhat.com>
>> Signed-off-by: Xose Vazquez Perez <xose.vazq...@gmail.com>
>> ---
>>  drivers/scsi/scsi_devinfo.c | 1 -
>>  1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/scsi/scsi_devinfo.c b/drivers/scsi/scsi_devinfo.c 
>> index 2464569..1fb7964 100644
>> --- a/drivers/scsi/scsi_devinfo.c
>> +++ b/drivers/scsi/scsi_devinfo.c
>> @@ -221,7 +221,6 @@ static struct {
>>  {"NEC", "PD-1 ODX654P", NULL, BLIST_FORCELUN | BLIST_SINGLELUN},
>>  {"NEC", "iStorage", NULL, BLIST_REPORTLUN2},
>>  {"NETAPP", "LUN C-Mode", NULL, BLIST_SYNC_ALUA},
>> -{"NETAPP", "INF-01-00", NULL, BLIST_SYNC_ALUA},
>>  {"NRC", "MBR-7", NULL, BLIST_FORCELUN | BLIST_SINGLELUN},
>>  {"NRC", "MBR-7.4", NULL, BLIST_FORCELUN | BLIST_SINGLELUN},
>>  {"PIONEER", "CD-ROM DRM-600", NULL, BLIST_FORCELUN | 
>> BLIST_SINGLELUN},
>>
> 
> Reviewed-by: Hannes Reinecke <h...@suse.com>
> 
> Cheers,
> 
> Hannes
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH v2] scsi_devinfo: remove synchronous ALUA for NETAPP devices

2016-11-11 Thread Xose Vazquez Perez

NetApp did confirm this is not required.

Cc: Martin George <martin.geo...@netapp.com>
Cc: Robert Stankey <robert.stan...@netapp.com>
Cc: Steven Schremmer <steven.schrem...@netapp.com>
Cc: Sean Stewart <sean.stew...@netapp.com>
Cc: Hannes Reinecke <h...@suse.de>
Cc: Christophe Varoqui <christophe.varo...@opensvc.com>
Cc: James E.J. Bottomley <j...@linux.vnet.ibm.com>
Cc: Martin K. Petersen <martin.peter...@oracle.com>
Cc: SCSI ML <linux-scsi@vger.kernel.org>
Cc: device-mapper development <dm-de...@redhat.com>
Signed-off-by: Xose Vazquez Perez <xose.vazq...@gmail.com>
---
 drivers/scsi/scsi_devinfo.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/scsi/scsi_devinfo.c b/drivers/scsi/scsi_devinfo.c
index 2464569..28fea83 100644
--- a/drivers/scsi/scsi_devinfo.c
+++ b/drivers/scsi/scsi_devinfo.c
@@ -220,8 +220,6 @@ static struct {
{"NAKAMICH", "MJ-5.16S", NULL, BLIST_FORCELUN | BLIST_SINGLELUN},
{"NEC", "PD-1 ODX654P", NULL, BLIST_FORCELUN | BLIST_SINGLELUN},
{"NEC", "iStorage", NULL, BLIST_REPORTLUN2},
-   {"NETAPP", "LUN C-Mode", NULL, BLIST_SYNC_ALUA},
-   {"NETAPP", "INF-01-00", NULL, BLIST_SYNC_ALUA},
{"NRC", "MBR-7", NULL, BLIST_FORCELUN | BLIST_SINGLELUN},
{"NRC", "MBR-7.4", NULL, BLIST_FORCELUN | BLIST_SINGLELUN},
{"PIONEER", "CD-ROM DRM-600", NULL, BLIST_FORCELUN | BLIST_SINGLELUN},
-- 
2.10.2

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] scsi_devinfo: remove synchronous ALUA for NETAPP/RDAC devices

2016-11-08 Thread Xose Vazquez Perez

NetApp did confirm this is only required for ONTAP(LUN C-Mode).

Cc: Martin George <martin.geo...@netapp.com>
Cc: Robert Stankey <robert.stan...@netapp.com>
Cc: Steven Schremmer <steven.schrem...@netapp.com>
Cc: Sean Stewart <sean.stew...@netapp.com>
Cc: Hannes Reinecke <h...@suse.de>
Cc: Christophe Varoqui <christophe.varo...@opensvc.com>
Cc: James E.J. Bottomley <j...@linux.vnet.ibm.com>
Cc: Martin K. Petersen <martin.peter...@oracle.com>
Cc: SCSI ML <linux-scsi@vger.kernel.org>
Cc: device-mapper development <dm-de...@redhat.com>
Signed-off-by: Xose Vazquez Perez <xose.vazq...@gmail.com>
---
 drivers/scsi/scsi_devinfo.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/scsi/scsi_devinfo.c b/drivers/scsi/scsi_devinfo.c
index 2464569..1fb7964 100644
--- a/drivers/scsi/scsi_devinfo.c
+++ b/drivers/scsi/scsi_devinfo.c
@@ -221,7 +221,6 @@ static struct {
{"NEC", "PD-1 ODX654P", NULL, BLIST_FORCELUN | BLIST_SINGLELUN},
{"NEC", "iStorage", NULL, BLIST_REPORTLUN2},
{"NETAPP", "LUN C-Mode", NULL, BLIST_SYNC_ALUA},
-   {"NETAPP", "INF-01-00", NULL, BLIST_SYNC_ALUA},
{"NRC", "MBR-7", NULL, BLIST_FORCELUN | BLIST_SINGLELUN},
{"NRC", "MBR-7.4", NULL, BLIST_FORCELUN | BLIST_SINGLELUN},
{"PIONEER", "CD-ROM DRM-600", NULL, BLIST_FORCELUN | BLIST_SINGLELUN},
-- 
2.10.2

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] scsi: update rdac devices at scsi_dh_rdac

2016-10-22 Thread Xose Vazquez Perez

On 10/18/2016 09:47 PM, Babu Moger wrote:

> At this point, I am not the right person to ack this change.

Thank you anyway.

Last chance before this patch is lost in the mailing list noise.

> However, adding new vendor id's is mostly not an issue.

> But, removing could be a problem. Sean has to confirm this.

It already was done, all changes are already included in
multipath-tools. See below.

> On 10/18/2016 10:11 AM, Xose Vazquez Perez wrote:
>> On 10/07/2016 06:55 PM, Xose Vazquez Perez wrote:
>>
>> This patch is pending, ACK is needed!
>> The part of multipath-tools was done time ago.
>>
>> CC: Babu Moger, just in case.

>>> Remove IBM/1745 ghost array.
>>> There is no references nowhere, also removed from multipath-tools
>>> Confirmed by the original manufacturer(NetApp), and Google shows no results.

http://git.opensvc.com/gitweb.cgi?p=multipath-tools/.git;a=commitdiff;h=ae9c385ab793600c3595c1ee513463d8d4ccf885

>>> Replace too wide "TP9" regex with full names.
>>> TP9100 is included, at it is not a RDAC array.
>>> This reverts partially the commit 352047

https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=352047
http://git.opensvc.com/gitweb.cgi?p=multipath-tools/.git;a=commitdiff;h=c6fbd3725c06b3ee240ce0fe4e5eedb97f934e09

>>> Add IBM 3542 and 3552, they are FAStT200 and FAStT500

http://git.opensvc.com/gitweb.cgi?p=multipath-tools/.git;a=commitdiff;h=4080b06683f8045a331631a0b8cb12be2becd0cf
http://git.opensvc.com/gitweb.cgi?p=multipath-tools/.git;a=commitdiff;h=e39610b0d3a4b5da16adcd10f18460dde609c41b

>>> Cc: Sean Stewart <sean.stew...@netapp.com>
>>> Cc: Hannes Reinecke <h...@suse.de>
>>> Cc: Christophe Varoqui <christophe.varo...@opensvc.com>
>>> Cc: James E.J. Bottomley <j...@linux.vnet.ibm.com>
>>> Cc: Martin K. Petersen <martin.peter...@oracle.com>
>>> Cc: SCSI ML <linux-scsi@vger.kernel.org>
>>> Cc: device-mapper development <dm-de...@redhat.com>
>>> Signed-off-by: Xose Vazquez Perez <xose.vazq...@gmail.com>
>>> ---
>>>   drivers/scsi/scsi_dh.c | 8 ++--
>>>   1 file changed, 6 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/scsi/scsi_dh.c b/drivers/scsi/scsi_dh.c
>>> index b8d3b97..a64b5ce 100644
>>> --- a/drivers/scsi/scsi_dh.c
>>> +++ b/drivers/scsi/scsi_dh.c
>>> @@ -49,14 +49,18 @@ static const struct scsi_dh_blist scsi_dh_blist[] = {
>>>   {"IBM", "1724","rdac", },
>>>   {"IBM", "1726","rdac", },
>>>   {"IBM", "1742","rdac", },
>>> -{"IBM", "1745","rdac", },
>>>   {"IBM", "1746","rdac", },
>>>   {"IBM", "1813","rdac", },
>>>   {"IBM", "1814","rdac", },
>>>   {"IBM", "1815","rdac", },
>>>   {"IBM", "1818","rdac", },
>>>   {"IBM", "3526","rdac", },
>>> -{"SGI", "TP9","rdac", },
>>> +{"IBM", "3542","rdac", },
>>> +{"IBM", "3552","rdac", },
>>> +{"SGI", "TP9300","rdac", },
>>> +{"SGI", "TP9400","rdac", },
>>> +{"SGI", "TP9500","rdac", },
>>> +{"SGI", "TP9700","rdac", },
>>>   {"SGI", "IS","rdac", },
>>>   {"STK", "OPENstorage D280","rdac", },
>>>   {"STK", "FLEXLINE 380","rdac", },
>>>
> 
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] scsi_devinfo: apply to HP-rebranded same options as Hitachi

2016-10-18 Thread Xose Vazquez Perez

627511e3e modified some Hitachi entries:

Four models, OPEN-/DF400/DF500/DISK-SUBSYSTEM, can handle REPORT_LUN,
and the BLIST_REPORTLUN2 flag needs to be set. And DF600 doesn't require
any flags because it returns ANSI 03h (SPC).

{"HITACHI", "DF400", "*", BLIST_REPORTLUN2},
{"HITACHI", "DF500", "*", BLIST_REPORTLUN2},


The same should have been done also for HP counterparts.


Cc: Takahiro Yasui <tya...@redhat.com>
Cc: Mike Christie <micha...@cs.wisc.edu>
Cc: Matthias Rudolph <matthias.rudo...@hds.com>
Cc: Christophe Varoqui <christophe.varo...@opensvc.com>
Cc: James E.J. Bottomley <j...@linux.vnet.ibm.com>
Cc: Martin K. Petersen <martin.peter...@oracle.com>
Cc: SCSI ML <linux-scsi@vger.kernel.org>
Cc: device-mapper development <dm-de...@redhat.com>
Signed-off-by: Xose Vazquez Perez <xose.vazq...@gmail.com>
---
 drivers/scsi/scsi_devinfo.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/scsi/scsi_devinfo.c b/drivers/scsi/scsi_devinfo.c
index 2464569..44d8cfb 100644
--- a/drivers/scsi/scsi_devinfo.c
+++ b/drivers/scsi/scsi_devinfo.c
@@ -186,9 +186,8 @@ static struct {
{"HP", "C1557A", NULL, BLIST_FORCELUN},
{"HP", "C3323-300", "4269", BLIST_NOTQ},
{"HP", "C5713A", NULL, BLIST_NOREPORTLUN},
-   {"HP", "DF400", "*", BLIST_SPARSELUN | BLIST_LARGELUN},
-   {"HP", "DF500", "*", BLIST_SPARSELUN | BLIST_LARGELUN},
-   {"HP", "DF600", "*", BLIST_SPARSELUN | BLIST_LARGELUN},
+   {"HP", "DF400", "*", BLIST_REPORTLUN2},
+   {"HP", "DF500", "*", BLIST_REPORTLUN2},
{"HP", "OP-C-", "*", BLIST_SPARSELUN | BLIST_LARGELUN},
{"HP", "3380-", "*", BLIST_SPARSELUN | BLIST_LARGELUN},
{"HP", "3390-", "*", BLIST_SPARSELUN | BLIST_LARGELUN},
-- 
2.10.1

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] scsi: update rdac devices at scsi_dh_rdac

2016-10-18 Thread Xose Vazquez Perez

On 10/07/2016 06:55 PM, Xose Vazquez Perez wrote:

This patch is pending, ACK is needed!
The part of multipath-tools was done time ago.

CC: Babu Moger, just in case.

> Remove IBM/1745 ghost array.
> There is no references nowhere, also removed from multipath-tools
> Confirmed by the original manufacturer(NetApp), and Google shows no results.
>
> Replace too wide "TP9" regex with full names.
> TP9100 is included, at it is not a RDAC array.
> This reverts partially the commit 352047
> 
> Add IBM 3542 and 3552, they are FAStT200 and FAStT500
> 
> Cc: Sean Stewart <sean.stew...@netapp.com>
> Cc: Hannes Reinecke <h...@suse.de>
> Cc: Christophe Varoqui <christophe.varo...@opensvc.com>
> Cc: James E.J. Bottomley <j...@linux.vnet.ibm.com>
> Cc: Martin K. Petersen <martin.peter...@oracle.com>
> Cc: SCSI ML <linux-scsi@vger.kernel.org>
> Cc: device-mapper development <dm-de...@redhat.com>
> Signed-off-by: Xose Vazquez Perez <xose.vazq...@gmail.com>
> ---
>  drivers/scsi/scsi_dh.c | 8 ++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/scsi/scsi_dh.c b/drivers/scsi/scsi_dh.c
> index b8d3b97..a64b5ce 100644
> --- a/drivers/scsi/scsi_dh.c
> +++ b/drivers/scsi/scsi_dh.c
> @@ -49,14 +49,18 @@ static const struct scsi_dh_blist scsi_dh_blist[] = {
>   {"IBM", "1724", "rdac", },
>   {"IBM", "1726", "rdac", },
>   {"IBM", "1742", "rdac", },
> - {"IBM", "1745", "rdac", },
>   {"IBM", "1746", "rdac", },
>   {"IBM", "1813", "rdac", },
>   {"IBM", "1814", "rdac", },
>   {"IBM", "1815", "rdac", },
>   {"IBM", "1818", "rdac", },
>   {"IBM", "3526", "rdac", },
> - {"SGI", "TP9",  "rdac", },
> + {"IBM", "3542", "rdac", },
> + {"IBM", "3552", "rdac", },
> + {"SGI", "TP9300",   "rdac", },
> + {"SGI", "TP9400",   "rdac", },
> + {"SGI", "TP9500",   "rdac", },
> + {"SGI", "TP9700",   "rdac", },
>   {"SGI", "IS",   "rdac", },
>   {"STK", "OPENstorage D280", "rdac", },
>   {"STK", "FLEXLINE 380", "rdac", },
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 15/23] scsi_dh_alua: Add new blacklist flag 'BLIST_SYNC_ALUA'

2016-10-10 Thread Xose Vazquez Perez

Hi Hannes,

Try #2.
Is this needed for RDAC(INF-01-00) devices?


Thank you.

---cut---
commit 851cde9909dd8b6fb90fab7f4e815c8f86c85a0d
Author: Hannes Reinecke 
Date:   Fri Feb 19 09:17:12 2016 +0100

scsi_dh_alua: Add new blacklist flag 'BLIST_SYNC_ALUA'

Add a new blacklist flag BLIST_SYNC_ALUA to instruct the
alua device handler to use synchronous command submission
for ALUA commands.

Reviewed-by: Bart Van Assche 
Reviewed-by: Christoph Hellwig 
Signed-off-by: Hannes Reinecke 
Signed-off-by: Martin K. Petersen 

diff --git a/drivers/scsi/device_handler/scsi_dh_alua.c 
b/drivers/scsi/device_handler/scsi_dh_alua.c
index a3cb069..fbbe85e 100644
--- a/drivers/scsi/device_handler/scsi_dh_alua.c
+++ b/drivers/scsi/device_handler/scsi_dh_alua.c
@@ -366,6 +366,8 @@ static int alua_check_vpd(struct scsi_device *sdev, struct 
alua_dh_data *h,
/* port group has changed. Update to new port group */
rcu_assign_pointer(h->pg, pg);
}
+   if (sdev->synchronous_alua)
+   pg->flags |= ALUA_SYNC_STPG;
alua_rtpg_queue(h->pg, sdev, NULL);
spin_unlock(>pg_lock);

diff --git a/drivers/scsi/scsi_devinfo.c b/drivers/scsi/scsi_devinfo.c
index bbfbfd9..3408578 100644
--- a/drivers/scsi/scsi_devinfo.c
+++ b/drivers/scsi/scsi_devinfo.c
@@ -220,6 +220,8 @@ static struct {
{"NAKAMICH", "MJ-5.16S", NULL, BLIST_FORCELUN | BLIST_SINGLELUN},
{"NEC", "PD-1 ODX654P", NULL, BLIST_FORCELUN | BLIST_SINGLELUN},
{"NEC", "iStorage", NULL, BLIST_REPORTLUN2},
+   {"NETAPP", "LUN C-Mode", NULL, BLIST_SYNC_ALUA},
+   {"NETAPP", "INF-01-00", NULL, BLIST_SYNC_ALUA},
{"NRC", "MBR-7", NULL, BLIST_FORCELUN | BLIST_SINGLELUN},
{"NRC", "MBR-7.4", NULL, BLIST_FORCELUN | BLIST_SINGLELUN},
{"PIONEER", "CD-ROM DRM-600", NULL, BLIST_FORCELUN | BLIST_SINGLELUN},
diff --git a/drivers/scsi/scsi_scan.c b/drivers/scsi/scsi_scan.c
index 1f02e84..420239c 100644
--- a/drivers/scsi/scsi_scan.c
+++ b/drivers/scsi/scsi_scan.c
@@ -964,6 +964,9 @@ static int scsi_add_lun(struct scsi_device *sdev, unsigned 
char *inq_result,
if (*bflags & BLIST_NO_DIF)
sdev->no_dif = 1;

+   if (*bflags & BLIST_SYNC_ALUA)
+   sdev->synchronous_alua = 1;
+
sdev->eh_timeout = SCSI_DEFAULT_EH_TIMEOUT;

if (*bflags & BLIST_TRY_VPD_PAGES)
diff --git a/include/scsi/scsi_device.h b/include/scsi/scsi_device.h
index 9173ab5a..4af2b24 100644
--- a/include/scsi/scsi_device.h
+++ b/include/scsi/scsi_device.h
@@ -176,6 +176,7 @@ struct scsi_device {
unsigned no_dif:1;  /* T10 PI (DIF) should be disabled */
unsigned broken_fua:1;  /* Don't set FUA bit */
unsigned lun_in_cdb:1;  /* Store LUN bits in CDB[1] */
+   unsigned synchronous_alua:1;/* Synchronous ALUA commands */

atomic_t disk_events_disable_depth; /* disable depth for disk events */

diff --git a/include/scsi/scsi_devinfo.h b/include/scsi/scsi_devinfo.h
index 96e3f56..9f750cb 100644
--- a/include/scsi/scsi_devinfo.h
+++ b/include/scsi/scsi_devinfo.h
@@ -37,5 +37,6 @@
 #define BLIST_TRY_VPD_PAGES0x1000 /* Attempt to read VPD pages */
 #define BLIST_NO_RSOC  0x2000 /* don't try to issue RSOC */
 #define BLIST_MAX_1024 0x4000 /* maximum 1024 sector cdb length */
+#define BLIST_SYNC_ALUA0x8000 /* Synchronous ALUA commands 
*/

 #endif
---
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] scsi: update rdac devices at scsi_dh_rdac

2016-10-07 Thread Xose Vazquez Perez

Remove IBM/1745 ghost array.
There is no references nowhere, also removed from multipath-tools
Confirmed by the original manufacturer(NetApp), and Google shows no results.

Replace too wide "TP9" regex with full names.
TP9100 is included, at it is not a RDAC array.
This reverts partially the commit 352047

Add IBM 3542 and 3552, they are FAStT200 and FAStT500

Cc: Sean Stewart <sean.stew...@netapp.com>
Cc: Hannes Reinecke <h...@suse.de>
Cc: Christophe Varoqui <christophe.varo...@opensvc.com>
Cc: James E.J. Bottomley <j...@linux.vnet.ibm.com>
Cc: Martin K. Petersen <martin.peter...@oracle.com>
Cc: SCSI ML <linux-scsi@vger.kernel.org>
Cc: device-mapper development <dm-de...@redhat.com>
Signed-off-by: Xose Vazquez Perez <xose.vazq...@gmail.com>
---
 drivers/scsi/scsi_dh.c | 8 ++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/drivers/scsi/scsi_dh.c b/drivers/scsi/scsi_dh.c
index b8d3b97..a64b5ce 100644
--- a/drivers/scsi/scsi_dh.c
+++ b/drivers/scsi/scsi_dh.c
@@ -49,14 +49,18 @@ static const struct scsi_dh_blist scsi_dh_blist[] = {
{"IBM", "1724", "rdac", },
{"IBM", "1726", "rdac", },
{"IBM", "1742", "rdac", },
-   {"IBM", "1745", "rdac", },
{"IBM", "1746", "rdac", },
{"IBM", "1813", "rdac", },
{"IBM", "1814", "rdac", },
{"IBM", "1815", "rdac", },
{"IBM", "1818", "rdac", },
{"IBM", "3526", "rdac", },
-   {"SGI", "TP9",  "rdac", },
+   {"IBM", "3542", "rdac", },
+   {"IBM", "3552", "rdac", },
+   {"SGI", "TP9300",   "rdac", },
+   {"SGI", "TP9400",   "rdac", },
+   {"SGI", "TP9500",   "rdac", },
+   {"SGI", "TP9700",   "rdac", },
{"SGI", "IS",   "rdac", },
{"STK", "OPENstorage D280", "rdac", },
{"STK", "FLEXLINE 380", "rdac", },
-- 
2.10.1

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] scsi: replace wrong device handler name for CLARiiON arrays

2016-10-07 Thread Xose Vazquez Perez

At drivers/scsi/device_handler/scsi_dh_emc.c it was defined as:
#define CLARIION_NAME   "emc"

Cc: Christoph Hellwig <h...@lst.de>
Cc: Hannes Reinecke <h...@suse.de>
Cc: Christophe Varoqui <christophe.varo...@opensvc.com>
Cc: James E.J. Bottomley <j...@linux.vnet.ibm.com>
Cc: Martin K. Petersen <martin.peter...@oracle.com>
Cc: SCSI ML <linux-scsi@vger.kernel.org>
Cc: device-mapper development <dm-de...@redhat.com>
Signed-off-by: Xose Vazquez Perez <xose.vazq...@gmail.com>
---
 drivers/scsi/scsi_dh.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/scsi/scsi_dh.c b/drivers/scsi/scsi_dh.c
index 54d446c..b8d3b97 100644
--- a/drivers/scsi/scsi_dh.c
+++ b/drivers/scsi/scsi_dh.c
@@ -36,9 +36,9 @@ struct scsi_dh_blist {
 };
 
 static const struct scsi_dh_blist scsi_dh_blist[] = {
-   {"DGC", "RAID", "clariion" },
-   {"DGC", "DISK", "clariion" },
-   {"DGC", "VRAID","clariion" },
+   {"DGC", "RAID", "emc" },
+   {"DGC", "DISK", "emc" },
+   {"DGC", "VRAID","emc" },
 
{"COMPAQ", "MSA1000 VOLUME","hp_sw" },
{"COMPAQ", "HSV110","hp_sw" },
-- 
2.10.1

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 1/5] multipath-tools: document how to add devices that need special flags in the SCSI subsystem

2016-08-16 Thread Xose Vazquez Perez

Full flags list at include/scsi/scsi_devinfo.h

Arrays controllers included currently:

 {"3PARdata", "VV", NULL, BLIST_REPORTLUN2},

 {"DEC", "HSG80", NULL, BLIST_REPORTLUN2 | BLIST_NOSTARTONADD},
 {"HP", "A6189A", NULL, BLIST_SPARSELUN | BLIST_LARGELUN},
 {"COMPAQ", "MSA1000", NULL, BLIST_SPARSELUN | BLIST_NOSTARTONADD},
 {"COMPAQ", "MSA1000 VOLUME", NULL, BLIST_SPARSELUN | BLIST_NOSTARTONADD},
 {"COMPAQ", "HSV110", NULL, BLIST_REPORTLUN2 | BLIST_NOSTARTONADD},
 {"HP", "HSV100", NULL, BLIST_REPORTLUN2 | BLIST_NOSTARTONADD},
 {"COMPAQ", "LOGICAL VOLUME", NULL, BLIST_FORCELUN | BLIST_MAX_512},

 {"DDN", "SAN DataDirector", "*", BLIST_SPARSELUN},

 {"DGC", "RAID", NULL, BLIST_SPARSELUN},
 {"DGC", "DISK", NULL, BLIST_SPARSELUN},
<-- mising VDISK ??
 {"EMC", "SYMMETRIX", NULL, BLIST_SPARSELUN | BLIST_LARGELUN | BLIST_FORCELUN},
 {"EMC",  "Invista", "*", BLIST_SPARSELUN | BLIST_LARGELUN},

 {"FSC", "CentricStor", "*", BLIST_SPARSELUN | BLIST_LARGELUN},

 {"HITACHI", "OPEN-", "*", BLIST_REPORTLUN2},
 {"HP", "OPEN-", "*", BLIST_REPORTLUN2},

 {"HITACHI", "DF400", "*", BLIST_REPORTLUN2},
 {"HITACHI", "DF500", "*", BLIST_REPORTLUN2},
 {"HP", "DF400", "*", BLIST_SPARSELUN | BLIST_LARGELUN},
 {"HP", "DF500", "*", BLIST_SPARSELUN | BLIST_LARGELUN},
 {"HP", "DF600", "*", BLIST_SPARSELUN | BLIST_LARGELUN},
<-- bug, also apply: 627511e3e

 {"IBM", "ProFibre 4000R", "*", BLIST_SPARSELUN | BLIST_LARGELUN},

 {"NETAPP", "LUN C-Mode", NULL, BLIST_SYNC_ALUA},   
<-- ontap

 {"NETAPP", "INF-01-00", NULL, BLIST_SYNC_ALUA},    
<-- rdac!!

 {"SGI", "TP9100", "*", BLIST_REPORTLUN2},

 {"Intel", "Multi-Flex", NULL, BLIST_NO_RSOC},

 {"SGI", "Universal Xport", "*", BLIST_NO_ULD_ATTACH},
 {"IBM", "Universal Xport", "*", BLIST_NO_ULD_ATTACH},
 {"SUN", "Universal Xport", "*", BLIST_NO_ULD_ATTACH},
 {"DELL", "Universal Xport", "*", BLIST_NO_ULD_ATTACH},

Cc: Christophe Varoqui <christophe.varo...@opensvc.com>
Cc: James E.J. Bottomley <j...@linux.vnet.ibm.com>
Cc: Martin K. Petersen <martin.peter...@oracle.com>
Cc: SCSI ML <linux-scsi@vger.kernel.org>
Cc: device-mapper development <dm-de...@redhat.com>
Signed-off-by: Xose Vazquez Perez <xose.vazq...@gmail.com>
---
 libmultipath/hwtable.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
index 1bc6f2c..4e1740a 100644
--- a/libmultipath/hwtable.c
+++ b/libmultipath/hwtable.c
@@ -22,6 +22,9 @@
  *
  * Devices with a proprietary handler must also be included in
  * the kernel side. Currently at drivers/scsi/scsi_dh.c
+ *
+ * Moreover, if a device needs a special treatment by the SCSI
+ * subsystem it should be included in drivers/scsi/scsi_devinfo.c
  */
 static struct hwentry default_hw[] = {
/*
-- 
2.7.4

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] multipath-tools: document how to add devices that need special flags in the SCSI subsystem

2016-08-14 Thread Xose Vazquez Perez

Full flags list at include/scsi/scsi_devinfo.h


Arrays controllers included currently:

 {"3PARdata", "VV", NULL, BLIST_REPORTLUN2},

 {"DEC", "HSG80", NULL, BLIST_REPORTLUN2 | BLIST_NOSTARTONADD},
 {"HP", "A6189A", NULL, BLIST_SPARSELUN | BLIST_LARGELUN},
 {"COMPAQ", "MSA1000", NULL, BLIST_SPARSELUN | BLIST_NOSTARTONADD},
 {"COMPAQ", "MSA1000 VOLUME", NULL, BLIST_SPARSELUN | BLIST_NOSTARTONADD},
 {"COMPAQ", "HSV110", NULL, BLIST_REPORTLUN2 | BLIST_NOSTARTONADD},
 {"HP", "HSV100", NULL, BLIST_REPORTLUN2 | BLIST_NOSTARTONADD},
 {"COMPAQ", "LOGICAL VOLUME", NULL, BLIST_FORCELUN | BLIST_MAX_512},

 {"DDN", "SAN DataDirector", "*", BLIST_SPARSELUN},

 {"DGC", "RAID", NULL, BLIST_SPARSELUN},
 {"DGC", "DISK", NULL, BLIST_SPARSELUN},
<-- mising VDISK ??
 {"EMC", "SYMMETRIX", NULL, BLIST_SPARSELUN | BLIST_LARGELUN | BLIST_FORCELUN},
 {"EMC",  "Invista", "*", BLIST_SPARSELUN | BLIST_LARGELUN},

 {"FSC", "CentricStor", "*", BLIST_SPARSELUN | BLIST_LARGELUN},

 {"HITACHI", "OPEN-", "*", BLIST_REPORTLUN2},
 {"HP", "OPEN-", "*", BLIST_REPORTLUN2},

 {"HITACHI", "DF400", "*", BLIST_REPORTLUN2},
 {"HITACHI", "DF500", "*", BLIST_REPORTLUN2},
 {"HP", "DF400", "*", BLIST_SPARSELUN | BLIST_LARGELUN},
 {"HP", "DF500", "*", BLIST_SPARSELUN | BLIST_LARGELUN},
 {"HP", "DF600", "*", BLIST_SPARSELUN | BLIST_LARGELUN},
<-- bug, also apply: 627511e3e

 {"IBM", "ProFibre 4000R", "*", BLIST_SPARSELUN | BLIST_LARGELUN},

 {"NETAPP", "LUN C-Mode", NULL, BLIST_SYNC_ALUA},   
<-- ontap

 {"NETAPP", "INF-01-00", NULL, BLIST_SYNC_ALUA},
<-- rdac!!

 {"SGI", "TP9100", "*", BLIST_REPORTLUN2},

 {"Intel", "Multi-Flex", NULL, BLIST_NO_RSOC},

 {"SGI", "Universal Xport", "*", BLIST_NO_ULD_ATTACH},
 {"IBM", "Universal Xport", "*", BLIST_NO_ULD_ATTACH},
 {"SUN", "Universal Xport", "*", BLIST_NO_ULD_ATTACH},
 {"DELL", "Universal Xport", "*", BLIST_NO_ULD_ATTACH},


Cc: Christophe Varoqui <christophe.varo...@opensvc.com>
Cc: James E.J. Bottomley <j...@linux.vnet.ibm.com>
Cc: Martin K. Petersen <martin.peter...@oracle.com>
Cc: SCSI ML <linux-scsi@vger.kernel.org>
Cc: device-mapper development <dm-de...@redhat.com>
Signed-off-by: Xose Vazquez Perez <xose.vazq...@gmail.com>
---
 libmultipath/hwtable.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
index a69002f..a489d6c 100644
--- a/libmultipath/hwtable.c
+++ b/libmultipath/hwtable.c
@@ -22,6 +22,9 @@
  *
  * Devices with a proprietary handler must also be included in
  * the kernel side. Currently at drivers/scsi/scsi_dh.c
+ *
+ * Moreover, if a device needs a special treatment by the SCSI
+ * subsystem it should be included in drivers/scsi/scsi_devinfo.c
  */
 static struct hwentry default_hw[] = {
/*
-- 
2.7.4

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] scsi: remove obsolete comment in scsi_devinfo.c

2016-08-13 Thread Xose Vazquez Perez

Unrealistic wish, maybe for next Christmas with the pony.
And highlight "unused" comment at revision.

Cc: James E.J. Bottomley <j...@linux.vnet.ibm.com>
Cc: Martin K. Petersen <martin.peter...@oracle.com>
Cc: SCSI ML <linux-scsi@vger.kernel.org>
Signed-off-by: Xose Vazquez Perez <xose.vazq...@gmail.com>
---
 drivers/scsi/scsi_devinfo.c | 5 +
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/scsi/scsi_devinfo.c b/drivers/scsi/scsi_devinfo.c
index 2464569..2d4bd7b 100644
--- a/drivers/scsi/scsi_devinfo.c
+++ b/drivers/scsi/scsi_devinfo.c
@@ -43,14 +43,11 @@ static char scsi_dev_flags[256];
  * settings that differ from the default, includes black-listed (broken)
  * devices. The entries here are added to the tail of scsi_dev_info_list
  * via scsi_dev_info_list_init.
- *
- * Do not add to this list, use the command line or proc interface to add
- * to the scsi_dev_info_list. This table will eventually go away.
  */
 static struct {
char *vendor;
char *model;
-   char *revision; /* revision known to be bad, unused */
+   char *revision; /* XXX revision known to be bad, unused XXX */
unsigned flags;
 } scsi_static_device_list[] __initdata = {
/*
-- 
2.7.4

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] scsi: blacklist all RDAC devices for BLIST_NO_ULD_ATTACH

2016-08-12 Thread Xose Vazquez Perez

"Universal Xport" LUN is used for in-band storage array management.

Cc: Sean Stewart <sean.stew...@netapp.com>
Cc: Christophe Varoqui <christophe.varo...@opensvc.com>
Cc: James E.J. Bottomley <j...@linux.vnet.ibm.com>
Cc: Martin K. Petersen <martin.peter...@oracle.com>
Cc: SCSI ML <linux-scsi@vger.kernel.org>
Cc: device-mapper development <dm-de...@redhat.com>
Signed-off-by: Xose Vazquez Perez <xose.vazq...@gmail.com>
---
 drivers/scsi/scsi_devinfo.c | 4 
 1 file changed, 4 insertions(+)

diff --git a/drivers/scsi/scsi_devinfo.c b/drivers/scsi/scsi_devinfo.c
index eaccd65..2464569 100644
--- a/drivers/scsi/scsi_devinfo.c
+++ b/drivers/scsi/scsi_devinfo.c
@@ -246,6 +246,10 @@ static struct {
{"IBM", "Universal Xport", "*", BLIST_NO_ULD_ATTACH},
{"SUN", "Universal Xport", "*", BLIST_NO_ULD_ATTACH},
{"DELL", "Universal Xport", "*", BLIST_NO_ULD_ATTACH},
+   {"STK", "Universal Xport", "*", BLIST_NO_ULD_ATTACH},
+   {"NETAPP", "Universal Xport", "*", BLIST_NO_ULD_ATTACH},
+   {"LSI", "Universal Xport", "*", BLIST_NO_ULD_ATTACH},
+   {"ENGENIO", "Universal Xport", "*", BLIST_NO_ULD_ATTACH},
{"SMSC", "USB 2 HS-CF", NULL, BLIST_SPARSELUN | BLIST_INQUIRY_36},
{"SONY", "CD-ROM CDU-8001", NULL, BLIST_BORKEN},
{"SONY", "TSL", NULL, BLIST_FORCELUN},  /* DDS3 & DDS4 
autoloaders */
-- 
2.7.4

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/2] qla2xxx: Remove unavailable firmware files

2015-11-17 Thread Xose Vazquez Perez

On 10/14/2015 05:57 PM, Himanshu Madhani wrote:

> Remove firmware binary names for the ISPs, which
> are not submitted to linux-firmware
> 
> Signed-off-by: Himanshu Madhani <himanshu.madh...@qlogic.com>
> Signed-off-by: Giridhar Malavali <giridhar.malav...@qlogic.com>
> ---
>  drivers/scsi/qla2xxx/qla_os.c |   29 -
>  1 files changed, 0 insertions(+), 29 deletions(-)
> 
> diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c
> index c2dd17b..41aca16 100644
> --- a/drivers/scsi/qla2xxx/qla_os.c
> +++ b/drivers/scsi/qla2xxx/qla_os.c
> @@ -5293,11 +5293,6 @@ qla2x00_timer(scsi_qla_host_t *vha)
>  #define FW_ISP2322   3
>  #define FW_ISP24XX   4
>  #define FW_ISP25XX   5
> -#define FW_ISP81XX   6
> -#define FW_ISP82XX   7
> -#define FW_ISP2031   8
> -#define FW_ISP8031   9
> -#define FW_ISP27XX   10
>  
>  #define FW_FILE_ISP21XX  "ql2100_fw.bin"
>  #define FW_FILE_ISP22XX  "ql2200_fw.bin"
> @@ -5305,12 +5300,6 @@ qla2x00_timer(scsi_qla_host_t *vha)
>  #define FW_FILE_ISP2322  "ql2322_fw.bin"
>  #define FW_FILE_ISP24XX  "ql2400_fw.bin"
>  #define FW_FILE_ISP25XX  "ql2500_fw.bin"
> -#define FW_FILE_ISP81XX  "ql8100_fw.bin"
> -#define FW_FILE_ISP82XX  "ql8200_fw.bin"
> -#define FW_FILE_ISP2031  "ql2600_fw.bin"
> -#define FW_FILE_ISP8031  "ql8300_fw.bin"
> -#define FW_FILE_ISP27XX  "ql2700_fw.bin"
> -
>  
>  static DEFINE_MUTEX(qla_fw_lock);
>  
> @@ -5321,11 +5310,6 @@ static struct fw_blob qla_fw_blobs[FW_BLOBS] = {
>   { .name = FW_FILE_ISP2322, .segs = { 0x800, 0x1c000, 0x1e000, 0 }, },
>   { .name = FW_FILE_ISP24XX, },
>   { .name = FW_FILE_ISP25XX, },
> - { .name = FW_FILE_ISP81XX, },
> - { .name = FW_FILE_ISP82XX, },
> - { .name = FW_FILE_ISP2031, },
> - { .name = FW_FILE_ISP8031, },
> - { .name = FW_FILE_ISP27XX, },
>  };
>  
>  struct fw_blob *
> @@ -5346,16 +5330,6 @@ qla2x00_request_firmware(scsi_qla_host_t *vha)
>   blob = _fw_blobs[FW_ISP24XX];
>   } else if (IS_QLA25XX(ha)) {
>   blob = _fw_blobs[FW_ISP25XX];
> - } else if (IS_QLA81XX(ha)) {
> - blob = _fw_blobs[FW_ISP81XX];
> - } else if (IS_QLA82XX(ha)) {
> - blob = _fw_blobs[FW_ISP82XX];
> - } else if (IS_QLA2031(ha)) {
> - blob = _fw_blobs[FW_ISP2031];
> - } else if (IS_QLA8031(ha)) {
> - blob = _fw_blobs[FW_ISP8031];
> - } else if (IS_QLA27XX(ha)) {
> - blob = _fw_blobs[FW_ISP27XX];
>   } else {
>   return NULL;
>   }
> @@ -5844,6 +5818,3 @@ MODULE_FIRMWARE(FW_FILE_ISP2300);
>  MODULE_FIRMWARE(FW_FILE_ISP2322);
>  MODULE_FIRMWARE(FW_FILE_ISP24XX);
>  MODULE_FIRMWARE(FW_FILE_ISP25XX);
> -MODULE_FIRMWARE(FW_FILE_ISP2031);
> -MODULE_FIRMWARE(FW_FILE_ISP8031);
> -MODULE_FIRMWARE(FW_FILE_ISP27XX);
> -- 
> 1.7.7

You should remove this info also from Kconfig:
  2031  ql2600_fw.bin
  8031  ql8300_fw.bin
  27xx  ql2700_fw.bin

Anyway,

Reviewed-by: Xose Vazquez Perez <xose.vazq...@gmail.com>


BTW, linux-firmware still contains release 7.03.00 of ql2400_fw.bin and 
ql2500_fw.bin .
SLES-11_SP4 already brings 8.00.00. And I did test 8.01.00 time ago and it 
worked flawlessly.

So, please *regularly* send latest FW releases to linux-firmware.git

-thanks-
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/2] qla2xxx: fix rwlock recursion

2015-11-16 Thread Xose Vazquez Perez

Bart Van Assche wrote:

> [PATCH] qla2xxx: Fix rwlock recursion
> 
> Fixes: 8dfa4b5a9b44 ("qla2xxx: Fix sparse annotation")
> Signed-off-by: Bart Van Assche 
> Reported-by: Himanshu Madhani 
> Cc: Giridhar Malavali 
> ---
>   drivers/scsi/qla2xxx/qla_nx.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/qla2xxx/qla_nx.c b/drivers/scsi/qla2xxx/qla_nx.c
> index eb0cc54..b6b4cfd 100644
> --- a/drivers/scsi/qla2xxx/qla_nx.c
> +++ b/drivers/scsi/qla2xxx/qla_nx.c
> @@ -433,7 +433,7 @@ qla82xx_pci_get_crb_addr_2M(struct qla_hw_data *ha, 
> ulong off_in,
>   if (off_in < QLA82XX_PCI_CRBSPACE)
>   return -1;
> 
> - *off_out = (void __iomem *)(off_in - QLA82XX_PCI_CRBSPACE);
> + off_in -= QLA82XX_PCI_CRBSPACE;
> 
>   /* Try direct map */
>   m = _128M_2M_map[CRB_BLK(off_in)].sub_block[CRB_SUBBLK(off_in)];
> @@ -443,6 +443,7 @@ qla82xx_pci_get_crb_addr_2M(struct qla_hw_data *ha, 
> ulong off_in,
>   return 0;
>   }
>   /* Not in direct map, use crb window */
> + *off_out = (void __iomem *)off_in;
>   return 1;
>   }
> 
> -- 
> 2.1.4

This patch is still pending or it was lost, could you please resend it ?

-thanks-
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH for-next] scsi: qla2xxx: Hide unavailable firmware

2015-10-09 Thread Xose Vazquez Perez

On 10/09/2015 02:26 AM, Giridhar Malavali wrote:

> We will send a patch to remove such references in our driver.

Could you please send latest(8.01.00 or better) firmware to linux-firmware.git ?
Right now it brings 7.03.00, and some enterprise distributions already have 
8.00.00

-thanks-
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH for-next] scsi: qla2xxx: Hide unavailable firmware

2015-10-07 Thread Xose Vazquez Perez

On Fri, May 22, 2015 at 10:00 AM, Julian Calaby  wrote:

> Some qla2xxx devices have firmware stored in flash on the device,
> however for debugging and triage purposes, Qlogic staff like to
> be able to load known-good versions of these firmwares through
> request_firmware().
>
> These firmware files were never distributed and are unlikely to ever
> be released publically, so to hide these missing firmware files from
> scripts which check such things, (e.g. Debian's initramfs-tools) put
> them behind a new EXPERT Kconfig option.


What is state of this patch ?


> Cc: 
> Cc: James E.J. Bottomley 
> Cc: Linux Firmware Maintainers 
> Signed-off-by: Julian Calaby 
> ---
>  drivers/scsi/qla2xxx/Kconfig  | 25 +
>  drivers/scsi/qla2xxx/qla_os.c | 40 +++-
>  2 files changed, 52 insertions(+), 13 deletions(-)
>
> This is against linux-next @next-20150520 and has been compile
> tested only.
>
> diff --git a/drivers/scsi/qla2xxx/Kconfig b/drivers/scsi/qla2xxx/Kconfig
> index 33f60c9..31e9db4 100644
> --- a/drivers/scsi/qla2xxx/Kconfig
> +++ b/drivers/scsi/qla2xxx/Kconfig
> @@ -31,6 +31,31 @@ config SCSI_QLA_FC
>
> They are also included in the linux-firmware tree as well.
>
> +   This driver also supports some adapters with firmware stored
> +   onboard in flash.
> +
> +config SCSI_QLA_FC_TRIAGE
> +   bool "Firmware loading support for flash based adapters"
> +   depends on SCSI_QLA_FC
> +   depends on EXPERT
> +   default n
> +   ---help---
> +   Add firmware definitions for adapters with firmware stored
> +   onboard in flash.
> +
> +   This requires the following firmware files which are not
> +   distributed:
> +
> +   ISP   Firmware Filename
> +   ---
> +   81xx  ql8100_fw.bin
> +   82xx  ql8200_fw.bin
> +
> +   This option should only be enabled by Qlogic support staff
> +   as these firmware files are not available publically.
> +
> +   If unsure say N.
> +
>  config TCM_QLA2XXX
> tristate "TCM_QLA2XXX fabric module for Qlogic 2xxx series target 
> mode HBAs"
> depends on SCSI_QLA_FC && TARGET_CORE
> diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c
> index 7462dd7..da98d83 100644
> --- a/drivers/scsi/qla2xxx/qla_os.c
> +++ b/drivers/scsi/qla2xxx/qla_os.c
> @@ -5284,11 +5284,14 @@ qla2x00_timer(scsi_qla_host_t *vha)
>  #define FW_ISP2322 3
>  #define FW_ISP24XX 4
>  #define FW_ISP25XX 5
> -#define FW_ISP81XX 6
> -#define FW_ISP82XX 7
> -#define FW_ISP2031 8
> -#define FW_ISP8031 9
> -#define FW_ISP27XX 10
> +#define FW_ISP2031 6
> +#define FW_ISP8031 7
> +#define FW_ISP27XX 8
> +
> +#ifdef CONFIG_SCSI_QLA_FC_TRIAGE
> +#define FW_ISP81XX 9
> +#define FW_ISP82XX 10
> +#endif
>
>  #define FW_FILE_ISP21XX"ql2100_fw.bin"
>  #define FW_FILE_ISP22XX"ql2200_fw.bin"
> @@ -5296,12 +5299,14 @@ qla2x00_timer(scsi_qla_host_t *vha)
>  #define FW_FILE_ISP2322"ql2322_fw.bin"
>  #define FW_FILE_ISP24XX"ql2400_fw.bin"
>  #define FW_FILE_ISP25XX"ql2500_fw.bin"
> -#define FW_FILE_ISP81XX"ql8100_fw.bin"
> -#define FW_FILE_ISP82XX"ql8200_fw.bin"
>  #define FW_FILE_ISP2031"ql2600_fw.bin"
>  #define FW_FILE_ISP8031"ql8300_fw.bin"
>  #define FW_FILE_ISP27XX"ql2700_fw.bin"
>
> +#ifdef CONFIG_SCSI_QLA_FC_TRIAGE
> +#define FW_FILE_ISP81XX"ql8100_fw.bin"
> +#define FW_FILE_ISP82XX"ql8200_fw.bin"
> +#endif
>
>  static DEFINE_MUTEX(qla_fw_lock);
>
> @@ -5312,11 +5317,13 @@ static struct fw_blob qla_fw_blobs[FW_BLOBS] = {
> { .name = FW_FILE_ISP2322, .segs = { 0x800, 0x1c000, 0x1e000, 0 }, },
> { .name = FW_FILE_ISP24XX, },
> { .name = FW_FILE_ISP25XX, },
> -   { .name = FW_FILE_ISP81XX, },
> -   { .name = FW_FILE_ISP82XX, },
> { .name = FW_FILE_ISP2031, },
> { .name = FW_FILE_ISP8031, },
> { .name = FW_FILE_ISP27XX, },
> +#ifdef CONFIG_SCSI_QLA_FC_TRIAGE
> +   { .name = FW_FILE_ISP81XX, },
> +   { .name = FW_FILE_ISP82XX, },
> +#endif
>  };
>
>  struct fw_blob *
> @@ -5337,16 +5344,18 @@ qla2x00_request_firmware(scsi_qla_host_t *vha)
> blob = _fw_blobs[FW_ISP24XX];
> } else if (IS_QLA25XX(ha)) {
> blob = _fw_blobs[FW_ISP25XX];
> -   } else if (IS_QLA81XX(ha)) {
> -   blob = _fw_blobs[FW_ISP81XX];
> -   } else if (IS_QLA82XX(ha)) {
> -   blob = _fw_blobs[FW_ISP82XX];
> } else if (IS_QLA2031(ha)) {
> blob = _fw_blobs[FW_ISP2031];
> } else if (IS_QLA8031(ha)) {
> blob = _fw_blobs[FW_ISP8031];
> } else if (IS_QLA27XX(ha)) {
>

Re: [PATCH for-next] qla2xxx: delete references to unused firmware files

2015-05-21 Thread Xose Vazquez Perez

On 05/21/2015 12:42 PM, Xose Vazquez Perez wrote:

 ql2400_fw.bin:  COPYRIGHT 2015 QLOGIC CORPORATION   ISP24xx Firmware   
 Version   8.01.00  $
 ql2500_fw.bin:  COPYRIGHT 2015 QLOGIC CORPORATION   ISP24xx Firmware   
 Version   8.01.00  $
 ql2600_fw.bin:  COPYRIGHT 2015 QLOGIC CORPORATION   ISP24xx Firmware   
 Version   8.01.00  $
 ql2700_fw.bin:  COPYRIGHT 2015 QLOGIC CORPORATION   ISP24xx Firmware   
 Version   8.01.00  $
 ql8300_fw.bin:  COPYRIGHT 2015 QLOGIC CORPORATION   ISP24xx Firmware   
 Version   8.01.00  $
  ^^^ wrong
Those should be:
ql2400_fw.bin:  COPYRIGHT 2015 QLOGIC CORPORATION   ISP24xx Firmware   Version  
 8.01.00  $
ql2500_fw.bin:  COPYRIGHT 2015 QLOGIC CORPORATION   ISP25xx Firmware   Version  
 8.01.00  $
ql2600_fw.bin:  COPYRIGHT 2015 QLOGIC CORPORATION   ISP83xx Firmware   Version  
 8.01.00  $
ql2700_fw.bin:  COPYRIGHT 2015 QLOGIC CORPORATION   ISP27xx Firmware   Version  
 8.01.00  $
ql8300_fw.bin:  COPYRIGHT 2015 QLOGIC CORPORATION   ISP83xx Firmware   Version  
 8.01.00  $
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH for-next] qla2xxx: delete references to unused firmware files

2015-05-21 Thread Xose Vazquez Perez

On 05/19/2015 05:51 PM, Himanshu Madhani wrote:

 On 5/18/15, 6:50 PM, Julian Calaby julian.cal...@gmail.com wrote:

 Do the devices these firmware files are for exist and is there any
 chance of the files being released?
 
 Yes. These devices are available and we read firmware from FLASH on these
 adapters. 
 At times when debugging/triaging involves firmware, we use binaries that
 would be useful for quick triaging.

It looks like newer FW files were released on 4/29/2015 in:
http://ldriver.qlogic.com/firmware/rpms/qlogic-firmware-8.01.00-1.noarch.rpm

ql2400_fw.bin:  COPYRIGHT 2015 QLOGIC CORPORATION   ISP24xx Firmware   Version  
 8.01.00  $
ql2500_fw.bin:  COPYRIGHT 2015 QLOGIC CORPORATION   ISP24xx Firmware   Version  
 8.01.00  $
ql2600_fw.bin:  COPYRIGHT 2015 QLOGIC CORPORATION   ISP24xx Firmware   Version  
 8.01.00  $
ql2700_fw.bin:  COPYRIGHT 2015 QLOGIC CORPORATION   ISP24xx Firmware   Version  
 8.01.00  $
ql8300_fw.bin:  COPYRIGHT 2015 QLOGIC CORPORATION   ISP24xx Firmware   Version  
 8.01.00  $


Could you please send meaningful files to linux-firmware.git ?
And remove irrelevant code from qla_os.c/Kconfig

-thank you-
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH v2 linux-scsi-ml] linux-firmware: qla2xxx: Update ql2{4,5}00_fw.bin to version 7.03.00

2014-06-10 Thread Xose Vazquez Perez

resent to linux-scsi-ml, without the binary blob(244K).

Firmwares were taken from http://ldriver.qlogic.com/firmware/

Cc: Chad Dupuis chad.dup...@qlogic.com
Cc: Andrew Vasquez andrew.vasq...@qlogic.com
Cc: Joe Carnuccio joe.carnuc...@qlogic.com
Cc: Saurav Kashyap saurav.kash...@qlogic.com
Cc: Qlogic internal list linux-dri...@qlogic.com
Cc: Linux Firmware Maintainers linux-firmw...@kernel.org
Signed-off-by: Xose Vazquez Perez xose.vazq...@gmail.com
---
 WHENCE|   4 ++--
 ql2400_fw.bin | Bin 259332 - 260656 bytes
 ql2500_fw.bin | Bin 265420 - 266912 bytes
 3 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/WHENCE b/WHENCE
index 6a64fc2..f257a93 100644
--- a/WHENCE
+++ b/WHENCE
@@ -429,9 +429,9 @@ Version: 3.03.28 IPX
 File: ql2322_fw.bin
 Version: 3.03.28 IPX
 File: ql2400_fw.bin
-Version: 7.01.00 MID
+Version: 7.03.00 MID
 File: ql2500_fw.bin
-Version: 7.01.00 MIDQ
+Version: 7.03.00 MIDQ
  Licence: Redistributable. See LICENCE.qla2xxx for details

diff --git a/ql2400_fw.bin b/ql2400_fw.bin
 [...]

diff --git a/ql2500_fw.bin b/ql2500_fw.bin
 [...]
-- 
1.9.3

--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 1/1 linux-scs-ml] qla2xxx: Update ql2{4,5}00_fw.bin to version 7.01.00

2013-11-23 Thread Xose Vazquez Perez

resent to linux-scsi-ml, without the binary blob(316K).

fw and licence were taken from http://ldriver.qlogic.com/firmware/

Cc: Chad Dupuis chad.dup...@qlogic.com
Cc: Andrew Vasquez andrew.vasq...@qlogic.com
Cc: linux-dri...@qlogic.com
Cc: David Woodhouse dw...@infradead.org
Cc: Ben Hutchings b...@decadent.org.uk
Signed-off-by: Xose Vazquez Perez xose.vazq...@gmail.com
---
 LICENCE.qla2xxx |  60 
 WHENCE  |   4 ++--
 ql2400_fw.bin   | Bin 257108 - 259332 bytes
 ql2500_fw.bin   | Bin 260064 - 265420 bytes
 4 files changed, 28 insertions(+), 36 deletions(-)

diff --git a/LICENCE.qla2xxx b/LICENCE.qla2xxx
index f669ae0..df67a9b 100644
--- a/LICENCE.qla2xxx
+++ b/LICENCE.qla2xxx
@@ -1,39 +1,31 @@
-Copyright (c)  2003-2006 QLogic Corporation
-QLogic Linux Fibre Channel HBA Firmware
+Copyright (c) 2003-2010 QLogic Corporation
+QLogic Linux Fibre Channel Adapter Firmware
 -You may redistribute the hardware specific firmware binary file
-under the following terms:
+Redistribution and use in binary form, without modification, for use in 
conjunction
+with QLogic authorized products is permitted provided that the following 
conditions
+are met:
 -  1. Redistribution of source code (only if applicable),
-  must retain the above copyright notice, this list of
-  conditions and the following disclaimer.
+1. Redistribution in binary form must reproduce the above copyright notice, 
this
+   list of conditions and the following disclaimer in the documentation and/or
+   other materials provided with the distribution.
+2. The name of QLogic Corporation may not be used to endorse or promote 
products
+   derived from this software without specific prior written permission.
+3. Reverse engineering, decompilation, or disassembly of this firmware is not
+   permitted.
 -  2. Redistribution in binary form must reproduce the above
-  copyright notice, this list of conditions and the
-  following disclaimer in the documentation and/or other
-  materials provided with the distribution.
+REGARDLESS OF WHAT LICENSING MECHANISM IS USED OR APPLICABLE,THIS PROGRAM IS
+PROVIDED BY QLOGIC CORPORATION AS IS'' AND ANY EXPRESS OR IMPLIED WARRANTIES,
+INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND
+FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE AUTHOR
+BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
+CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE
+GOODS OR SERVICES; LOSS OF USE,DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
+HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
+LIABILITY,OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
+OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH 
DAMAGE.
 -  3. The name of QLogic Corporation may not be used to
-  endorse or promote products derived from this software
-  without specific prior written permission
-
-REGARDLESS OF WHAT LICENSING MECHANISM IS USED OR APPLICABLE,
-THIS PROGRAM IS PROVIDED BY QLOGIC CORPORATION AS IS'' AND ANY
-EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
-IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A
-PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE AUTHOR
-BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
-EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED
-TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
-DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON
-ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
-OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
-OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
-POSSIBILITY OF SUCH DAMAGE.
-
-USER ACKNOWLEDGES AND AGREES THAT USE OF THIS PROGRAM WILL NOT
-CREATE OR GIVE GROUNDS FOR A LICENSE BY IMPLICATION, ESTOPPEL, OR
-OTHERWISE IN ANY INTELLECTUAL PROPERTY RIGHTS (PATENT, COPYRIGHT,
-TRADE SECRET, MASK WORK, OR OTHER PROPRIETARY RIGHT) EMBODIED IN
-ANY OTHER QLOGIC HARDWARE OR SOFTWARE EITHER SOLELY OR IN
+USER ACKNOWLEDGES AND AGREES THAT USE OF THIS PROGRAM WILL NOT CREATE OR GIVE
+GROUNDS FOR A LICENSE BY IMPLICATION, ESTOPPEL, OR OTHERWISE IN ANY 
INTELLECTUAL
+PROPERTY RIGHTS (PATENT, COPYRIGHT, TRADE SECRET, MASK WORK, OR OTHER 
PROPRIETARY
+RIGHT) EMBODIED IN ANY OTHER QLOGIC HARDWARE OR SOFTWARE EITHER SOLELY OR IN
 COMBINATION WITH THIS PROGRAM.
diff --git a/WHENCE b/WHENCE
index 2d52804..94f28a5 100644
--- a/WHENCE
+++ b/WHENCE
@@ -429,9 +429,9 @@ Version: 3.03.28 IPX
 File: ql2322_fw.bin
 Version: 3.03.28 IPX
 File: ql2400_fw.bin
-Version: 5.08.00 MID
+Version: 7.01.00 MID
 File: ql2500_fw.bin
-Version: 5.08.00 MIDQ
+Version: 7.01.00 MIDQ
  Licence: Redistributable. See LICENCE.qla2xxx for details
 diff --git a/ql2400_fw.bin b/ql2400_fw.bin
[...]
 diff --git a/ql2500_fw.bin b/ql2500_fw.bin

Re: [PATCH 06/23] qla2xxx: Update the FTP site references in the driver sources.

2013-02-11 Thread Xose Vazquez Perez

Giridhar Malavali wrote:

 From: Giridhar Malavali giridhar.malav...@qlogic.com
 
 Signed-off-by: Giridhar Malavali giridhar.malav...@qlogic.com
 Signed-off-by: Saurav Kashyap saurav.kash...@qlogic.com
 ---
  drivers/scsi/qla2xxx/qla_init.c |2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)
 
 diff --git a/drivers/scsi/qla2xxx/qla_init.c b/drivers/scsi/qla2xxx/qla_init.c
 index a581c85..bbf5688 100644
 --- a/drivers/scsi/qla2xxx/qla_init.c
 +++ b/drivers/scsi/qla2xxx/qla_init.c
 @@ -5054,7 +5054,7 @@ qla24xx_load_risc_flash(scsi_qla_host_t *vha, uint32_t 
 *srisc_addr,
   return rval;
  }
  
 -#define QLA_FW_URL ftp://ftp.qlogic.com/outgoing/linux/firmware/;
 +#define QLA_FW_URL http://ldriver.qlogic.com/firmware/;
  
  int
  qla2x00_load_risc(scsi_qla_host_t *vha, uint32_t *srisc_addr)
 -- 

qla2xxx/Kconfig should also be changed:

   Firmware images can be retrieved from:

ftp://ftp.qlogic.com/outgoing/linux/firmware/


FYI, they are also included in linux-firmware.
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: qla2xxx firmware

2012-12-14 Thread Xose Vazquez Perez

On 12/07/2012 08:05 PM, Xose Vazquez Perez wrote:

 please qlogic guys, send latest fw to upstream linux-firmware.git
 
 
 linux-firmware brings old releases:
 File: ql2400_fw.bin
 Version: 5.06.05 MID
 File: ql2500_fw.bin
 Version: 5.06.05 MIDQ
 
 qlogic-ftp releases:
 ql2400_fw.bin -- 5.08.00 MID
 ql2500_fw.bin -- 5.08.00 MIDQ

btw,
these URIs should be fixed:
qla2xxx/Kconfig:ftp://ftp.qlogic.com/outgoing/linux/firmware/
qla2xxx/qla_init.c:#define QLA_FW_URL 
ftp://ftp.qlogic.com/outgoing/linux/firmware/;

because ftp.qlogic.com is going to disappear, as stated in:
ftp://ftp.qlogic.com/IMPORTANT.THIS.FTP.SITE.TO.BE.SHUTDOWN

---cut---
QLogic Corporation FTP service - Access is monitored
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
- IMPORTANT NOTICE -
QLogic Corporation will be shutting down this public ftp site by end 
of calendar year 2012.

All users must transition to our replacement service as follows:

QLogic Customers:  Driver downloads are available at
http://driverdownloads.qlogic.com

QLogic Business Partners: Please contact your QLogic counterpart for 
assistance.

QLogic Employees: Please use the new Secure File Transfer service as 
described in the following link. 
http://helpdesk.qlogic.com/AddSolution.do?solID=19288

Please Contact ftp.h...@qlogic.com for further assistance
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
---end---
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

qla2xxx firmware

2012-12-07 Thread Xose Vazquez Perez


hi,

please qlogic guys, send latest fw to upstream linux-firmware.git


linux-firmware brings old releases:
File: ql2400_fw.bin
Version: 5.06.05 MID
File: ql2500_fw.bin
Version: 5.06.05 MIDQ

qlogic-ftp releases:
ql2400_fw.bin -- 5.08.00 MID
ql2500_fw.bin -- 5.08.00 MIDQ


-thank you-
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

44 matches

Mail list logo