[ANNOUNCE] scsi patch queue tree updated
It turnd out while the scsi-queue tree in general worked very well the split into core and drivers branches was rather cumbersome. For the 3.19 merge window updates and the 3.20 window I've switched to a single branch instead: git://git.infradead.org/users/hch/scsi-queue.git scsi-for-3.19 git://git.infradead.org/users/hch/scsi-queue.git scsi-for-3.20 So far there 3.20 tree is still rather small, but there are a couple of series that need a resend or review and should go in. The rules from the original scsi-queue tree have worked well, so they still apply with a minor change. These rules are: - the patch needs at least two positive reviews (non-author signoff, reviewed-by or acked-by tags). In practice this means it had at least one and I added another one. As an exception I also take trivial and important fixes if they only have a Tested-by: instead of a second review. - the patch has no negative review on the mailing list - the patch applies cleanly - the patch compiles (drivers for architectures I can't test excluded) - for core the core branch: the patch survives a full xfstests run -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [ANNOUNCE] scsi patch queue tree updated
On Mon, Sep 15, 2014 at 03:58:18PM -0700, Christoph Hellwig wrote: I've pushed two updates to the core-for-3.17 branch of git://git.infradead.org/users/hch/scsi-queue.git which should go to Linus before the next rc. One is a regression fix for drivers using block layer tagging when not using blk-mq introduced in the blk-mq series, and the other fixes a potential buffer overrun in the iscsi initiator. Updates of the for-3.18 trees will follow soon. core-for-3.17 has grown another fix from Daniel for bidi support. core-for-3.18 has got the autopm fix to balance the calls and thus handle LUNs without attached ULD drivers-for-3.18 has the megaraid, mpt and arcmsr updates as well as a bnx fix -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [ANNOUNCE] scsi patch queue tree updated
On Tue, 2014-09-16 at 14:37 -0700, Christoph Hellwig wrote: On Mon, Sep 15, 2014 at 03:58:18PM -0700, Christoph Hellwig wrote: I've pushed two updates to the core-for-3.17 branch of git://git.infradead.org/users/hch/scsi-queue.git which should go to Linus before the next rc. One is a regression fix for drivers using block layer tagging when not using blk-mq introduced in the blk-mq series, and the other fixes a potential buffer overrun in the iscsi initiator. Updates of the for-3.18 trees will follow soon. core-for-3.17 has grown another fix from Daniel for bidi support. OK, I've pushed this to -next. If nothing bad turns up I'll send it to Linus on Friday. James -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[ANNOUNCE] scsi patch queue tree updated
Hi James, I've pushed two updates to the core-for-3.17 branch of git://git.infradead.org/users/hch/scsi-queue.git which should go to Linus before the next rc. One is a regression fix for drivers using block layer tagging when not using blk-mq introduced in the blk-mq series, and the other fixes a potential buffer overrun in the iscsi initiator. Updates of the for-3.18 trees will follow soon. -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [ANNOUNCE] scsi patch queue tree updated
On Fri, Aug 1, 2014 at 5:20 AM, Christoph Hellwig h...@infradead.org wrote: I've pushed out updates to both the core-for-3.17 and drivers-for-3.17 branches. I think we're in a good shape for the merge window, but I'd still like to get reviewers attention for a few driver updates that I'd love to get in still: - my eata patch to remove the driver_lock - the partially reviewed megaraid series Christoph, Can we get someone to finish reviewing the megaraid_sas patch series ? Or let me know if anything else needs to be corrected ? I know it has been reviewed by yourself and Martin Petersen so far, however, I could not find the patch series in: http://git.infradead.org/users/hch/scsi-queue.git/shortlog/refs/heads/drivers-for-3.18 -Adam -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [ANNOUNCE] scsi patch queue tree updated
On Thu, Aug 21, 2014 at 12:33:17PM -0700, adam radford wrote: Can we get someone to finish reviewing the megaraid_sas patch series ? Or let me know if anything else needs to be corrected ? I know it has been reviewed by yourself and Martin Petersen so far, however, I could not find the patch series in: http://git.infradead.org/users/hch/scsi-queue.git/shortlog/refs/heads/drivers-for-3.18 I think I'm missing an ACK from Martin on one of the patches. -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [ANNOUNCE] scsi patch queue tree updated
Christoph == Christoph Hellwig h...@infradead.org writes: Christoph I think I'm missing an ACK from Martin on one of the patches. Looks like I missed the updated version of these during my vacation. I'll finish reviewing megaraid_sas (and mptNsas) today. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [ANNOUNCE] scsi patch queue tree updated
Christoph == Christoph Hellwig h...@infradead.org writes: Christoph I think I'm missing an ACK from Martin on one of the patches. 3/5 and 4/5 look good to me. Reviewed-by: Martin K. Petersen martin.peter...@oracle.com -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [ANNOUNCE] scsi patch queue tree updated
On Thu, Aug 21, 2014 at 04:26:09PM -0400, Martin K. Petersen wrote: Christoph I think I'm missing an ACK from Martin on one of the patches. 3/5 and 4/5 look good to me. Reviewed-by: Martin K. Petersen martin.peter...@oracle.com Thanks Martin, I'll pull in the megaraid_sas patches for the next branch update. -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [ANNOUNCE] scsi patch queue tree updated
On Thu, Aug 14, 2014 at 10:47:08AM -0700, James Bottomley wrote: So this is a bit late to get through linux-next and into a pull request. I was planning on sending the final pull tomorrow (in case Linus planned a surprise early release). Can we redo some of these as bug fixes and send them in for -rc1? core-for-3.17 is entirely bug fixes, the drivers side is all except for 4 tiny patches, and even Linus isn't that anal I think. -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [ANNOUNCE] scsi patch queue tree updated
On Fri, 2014-08-15 at 12:25 -0700, Christoph Hellwig wrote: On Thu, Aug 14, 2014 at 10:47:08AM -0700, James Bottomley wrote: So this is a bit late to get through linux-next and into a pull request. I was planning on sending the final pull tomorrow (in case Linus planned a surprise early release). Can we redo some of these as bug fixes and send them in for -rc1? core-for-3.17 is entirely bug fixes, the drivers side is all except for 4 tiny patches, and even Linus isn't that anal I think. You rebased the tree before doing it ... that's the one thing that excites his process gene. I can't send a rebased tree in on the last day of merging. I'll send in the unrebased tree which has been sitting in linux-next for the past week. The two additional changes in core-for-3.17 can be picked out and sent as eligible bug fixes for -rc1. The only addition in drivers-for-3.17 is eata: remove driver_lock ... I'm in two minds about whether we treat that as a bug fix or not. James -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [ANNOUNCE] scsi patch queue tree updated
On Thu, 2014-08-14 at 05:54 -0700, Christoph Hellwig wrote: On Mon, Aug 04, 2014 at 07:20:04AM -0700, James Bottomley wrote: The drivers side are a bunch of smaller fixes for iscsi and pm8001 which never have been a problem to put in near the end of the merge window, especially if they have a few more days linux-next exposure in Linux-next even after the 3.16 release. They absolutely would be candidates for a second pull even if they'd miss the first pull. OK, since I have to do a second pull anyway we might as well follow the rules. Ok, new tree is out, the core-for-3.17 has the one 64-bit lun format string fix that didn't make it into the first pull request, the queuecommand device busy regression fix, and the cmd_pool fix. The drivers-for-3.17 just has the driver updates I pushed earlier that didn't make the cut. So this is a bit late to get through linux-next and into a pull request. I was planning on sending the final pull tomorrow (in case Linus planned a surprise early release). Can we redo some of these as bug fixes and send them in for -rc1? James -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [ANNOUNCE] scsi patch queue tree updated
On Fri, Aug 01, 2014 at 04:32:01PM -0400, James Bottomley wrote: On Fri, 2014-08-01 at 05:20 -0700, Christoph Hellwig wrote: I've pushed out updates to both the core-for-3.17 and drivers-for-3.17 branches. So I'm afraid we missed the last -next build on these, so they can't go in with the early SCSI pull. I'm open to doing one mid merge window, but Linus tends not to like that. I don't think there are any hard and fast rules. The core-for-3.17 commit is a trivial printk specifier regression fix for something introduced in the 3.17 merge window, so pulling it in is an absolute non-brainer. The drivers side are a bunch of smaller fixes for iscsi and pm8001 which never have been a problem to put in near the end of the merge window, especially if they have a few more days linux-next exposure in Linux-next even after the 3.16 release. They absolutely would be candidates for a second pull even if they'd miss the first pull. -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [ANNOUNCE] scsi patch queue tree updated
Hi Christoph, On Mon, 4 Aug 2014 04:11:47 -0700 Christoph Hellwig h...@infradead.org wrote: On Fri, Aug 01, 2014 at 04:32:01PM -0400, James Bottomley wrote: On Fri, 2014-08-01 at 05:20 -0700, Christoph Hellwig wrote: I've pushed out updates to both the core-for-3.17 and drivers-for-3.17 branches. So I'm afraid we missed the last -next build on these, so they can't go in with the early SCSI pull. I'm open to doing one mid merge window, but Linus tends not to like that. You realise that neither of these in linux-next as the scsi-core and scsi-drivers trees had for-3.16 branches in the last round. I assume I should just drop these trees completely from linux-next? -- Cheers, Stephen Rothwells...@canb.auug.org.au signature.asc Description: PGP signature
Re: [ANNOUNCE] scsi patch queue tree updated
On Mon, Aug 04, 2014 at 09:30:59PM +1000, Stephen Rothwell wrote: You realise that neither of these in linux-next as the scsi-core and scsi-drivers trees had for-3.16 branches in the last round. I assume I should just drop these trees completely from linux-next? Well, they get pulled in through James, so you can drop them for now. I mostly put you on Cc so you could comment wether there are any hard rules on how long even those simple fixes should be in linux-next. I know you've put up stats for a few of the last merge windows about patches that weren't in linux-next, so there's been some tracking of it for sure. -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [ANNOUNCE] scsi patch queue tree updated
Hi Christoph, On Mon, 4 Aug 2014 04:34:04 -0700 Christoph Hellwig h...@infradead.org wrote: On Mon, Aug 04, 2014 at 09:30:59PM +1000, Stephen Rothwell wrote: You realise that neither of these in linux-next as the scsi-core and scsi-drivers trees had for-3.16 branches in the last round. I assume I should just drop these trees completely from linux-next? Well, they get pulled in through James, so you can drop them for now. Will do. I mostly put you on Cc so you could comment wether there are any hard rules on how long even those simple fixes should be in linux-next. I know you've put up stats for a few of the last merge windows about patches that weren't in linux-next, so there's been some tracking of it for sure. If they are simple, clear fixes, then maybe a day or two just for build coverage, but it is very much up to the maintainer. There are always a few poatches that get through late (quote a few of which I suspect have been in train, just not yet published in the maintainer's tree). And, of course, real fixes go in just about anytime ... I don't think we believe in hard rules for anything :-) -- Cheers, Stephen Rothwells...@canb.auug.org.au signature.asc Description: PGP signature
Re: [ANNOUNCE] scsi patch queue tree updated
On Mon, 2014-08-04 at 04:11 -0700, Christoph Hellwig wrote: On Fri, Aug 01, 2014 at 04:32:01PM -0400, James Bottomley wrote: On Fri, 2014-08-01 at 05:20 -0700, Christoph Hellwig wrote: I've pushed out updates to both the core-for-3.17 and drivers-for-3.17 branches. So I'm afraid we missed the last -next build on these, so they can't go in with the early SCSI pull. I'm open to doing one mid merge window, but Linus tends not to like that. I don't think there are any hard and fast rules. True, but the hardest of our semi-liquid rules is nothing in the merge window that wasn't in -next first. The core-for-3.17 commit is a trivial printk specifier regression fix for something introduced in the 3.17 merge window, so pulling it in is an absolute non-brainer. The drivers side are a bunch of smaller fixes for iscsi and pm8001 which never have been a problem to put in near the end of the merge window, especially if they have a few more days linux-next exposure in Linux-next even after the 3.16 release. They absolutely would be candidates for a second pull even if they'd miss the first pull. OK, since I have to do a second pull anyway we might as well follow the rules. James -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [ANNOUNCE] scsi patch queue tree updated
I've pushed out updates to both the core-for-3.17 and drivers-for-3.17 branches. I think we're in a good shape for the merge window, but I'd still like to get reviewers attention for a few driver updates that I'd love to get in still: - my eata patch to remove the driver_lock - the partially reviewed megaraid series - the arcmsr series -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [ANNOUNCE] scsi patch queue tree updated
On Fri, 2014-08-01 at 05:20 -0700, Christoph Hellwig wrote: I've pushed out updates to both the core-for-3.17 and drivers-for-3.17 branches. So I'm afraid we missed the last -next build on these, so they can't go in with the early SCSI pull. I'm open to doing one mid merge window, but Linus tends not to like that. James -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[ANNOUNCE] scsi patch queue tree updated
I've pushed out new version of the for-3.17 core and drivers trees: git://git.infradead.org/users/hch/scsi-queue.git core-for-3.17 git://git.infradead.org/users/hch/scsi-queue.git drivers-for-3.17 In the core tree the biggest update is the merge of the blk-mq support, but various smaller updates also made it. On the drivers side I have only merged minor updates for the ufs and hyperv drivers. We're fairly late in the cycle but I really would like to not miss the scsi_debug and megaraid updates that have been out for a while but need another review. -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [ANNOUNCE] scsi patch queue tree updated
I've pushed out new version of the for-3.17 core and drivers trees: git://git.infradead.org/users/hch/scsi-queue.git core-for-3.17 git://git.infradead.org/users/hch/scsi-queue.git drivers-for-3.17 In the core tree the biggest update is the merge of the I/O path cleanups, in addition various individual patches were merged, and the a few fixes for the 64-bit LUN series were squashed into the patches. The drivers side gained various updates, but there's still lots of driver work on the list that needs more reviews. I did a rebase to Linus' latest tree to pick up the fix for the aio regression to help people doing IOPS testing. Note that I've also pushed out a core-for-3.16 tree with James' flush fix in case James wants to push this for 3.16 still; but this late in the release cycles it might be better to wait for 3.17 for this as well. -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[ANNOUNCE] scsi patch queue tree updated
I've pushed out new version of the for-3.17 core and drivers trees: git://git.infradead.org/users/hch/scsi-queue.git core-for-3.17 git://git.infradead.org/users/hch/scsi-queue.git drivers-for-3.17 In the core tree the biggest news is the old target infrastructure removal, in addition a few warnings due to 64-bit LUNs have been fixed, and the tree has been rebased to 3.16-rc4 to pick up all updates that went into the Linux 3.16 release candidates. The drivers-for-3.17 tree is new, and I should have picked up all properly reviewed patches. Most notably missing from the drivers tree are the mpt2sas and mpt3sas series and the scsi_debug update which need a review, and the megaraid and pm8001 uptdates which need a resend. Missing from the core tree is the scsi-mq work that still needs a proper review. Also notably absent is the flush error handling fix, which still needs a signoff from James and a proper review. As far as I'm concerned that fix should still go into 3.16. -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [ANNOUNCE] scsi patch queue tree
And here are the for-3.16 driver changes: Brian King (2): ibmvscsi: Abort init sequence during error recovery ibmvscsi: Add memory barriers for send / receive Maurizio Lombardi (2): pm8001: Fix potential null pointer dereference and memory leak. bnx2fc: do not scan uninitialized lists in case of error. Neil Horman (2): fc: ensure scan_work isn't active when freeing fc_rport bnx2fc: Improve stats update mechanism Paolo Bonzini (2): virtio-scsi: avoid cancelling uninitialized work items virtio-scsi: fix various bad behavior on aborted requests Quinn Tran (1): qla2xxx: Fix sparse warning in qla_target.c. Reddy, Sreekanth (1): MAINTAINERS: Update LSILOGIC MPT FUSION DRIVERS (FC/SAS/SPI) maintainers Email IDs Tomas Henzl (2): be2iscsi: add an missing goto in error path be2iscsi: remove potential junk pointer free MAINTAINERS |9 + drivers/scsi/be2iscsi/be_main.c |2 ++ drivers/scsi/be2iscsi/be_mgmt.c |4 +--- drivers/scsi/bnx2fc/bnx2fc_fcoe.c | 16 drivers/scsi/bnx2fc/bnx2fc_io.c |2 ++ drivers/scsi/ibmvscsi/ibmvscsi.c | 13 - drivers/scsi/pm8001/pm8001_init.c | 13 ++--- drivers/scsi/qla2xxx/qla_target.c | 17 +++-- drivers/scsi/qla2xxx/qla_target.h |4 ++-- drivers/scsi/scsi_transport_fc.c |1 + drivers/scsi/virtio_scsi.c| 26 +- 11 files changed, 75 insertions(+), 32 deletions(-) -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [ANNOUNCE] scsi patch queue tree
I'm also going to put together driver fixes tomorrow, as a gentle reminder to patch author: please try to look for reviewer, as I want a second pair of eyes veriying each patch. -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [ANNOUNCE] scsi patch queue tree
I've pushed another update to the core-for-3.16 branch. This includes the two error handling fixes (Ewan verified that Hannes patch fixes the issues he was seeing), and the fix for the iscsi regression: Hannes Reinecke (1): scsi_error: set DID_TIME_OUT correctly Martin K. Petersen (1): scsi: use the scsi data buffer length to extract transfer size Ulrich Obergfell (1): scsi_error: fix invalid setting of host byte drivers/scsi/scsi_error.c | 20 ++-- include/scsi/scsi_cmnd.h |2 +- 2 files changed, 11 insertions(+), 11 deletions(-) -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [ANNOUNCE] scsi patch queue tree
After this first pull for the 3.16 merge window it seems like this worked out fairly well - we got a large number of patches in, and all reviewed by a second pair of eyes. How should we go on from this? The drivers-for-3.16-2 branch, which had the late lpfs and hpsa updates didn't make it into the pull request for Linus, do you intend to skip them for this window? If not do you still want to have another branch for the other pending smaller updates? -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [ANNOUNCE] scsi patch queue tree
On Wed, 2014-06-11 at 05:01 -0700, Christoph Hellwig wrote: After this first pull for the 3.16 merge window it seems like this worked out fairly well - we got a large number of patches in, and all reviewed by a second pair of eyes. How should we go on from this? The drivers-for-3.16-2 branch, which had the late lpfs and hpsa updates didn't make it into the pull request for Linus, do you intend to skip them for this window? If not do you still want to have another branch for the other pending smaller updates? No, I was waiting to check if there was any reason to have them split, but I think we've scope today or tomorrow. The only other outstanding thing is the fsync bug fix, which is waiting Jens' investigation of the block issues it may cause, but I'm inclined to send it anyway and fix up block later if there's a problem. James -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [ANNOUNCE] scsi patch queue tree
On Wed, Jun 11, 2014 at 07:17:34AM -0700, James Bottomley wrote: No, I was waiting to check if there was any reason to have them split, but I think we've scope today or tomorrow. The only other outstanding thing is the fsync bug fix, which is waiting Jens' investigation of the block issues it may cause, but I'm inclined to send it anyway and fix up block later if there's a problem. There's various fixes marked for stable from Paolos virtio_scsi update, which he asked to be considered for 3.16, including a core one: [PATCH v3 4/6] scsi_error: fix invalid setting of host byte also [PATCH] sd: bad return code of init_sd seems like another candidate for 3.16. -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [ANNOUNCE] scsi patch queue tree
With Linus opening the merge window things should calm down now. I've pushed the mvsas pciid update, and a revert of the be2scsi patch that wasn't quite ready to the drivers-for-3.16 branch. I've also created a new drivers-for-3.16-2 branch that contains the remaining hpsa updates that might be too big for Linus taste that late but should probably be fine. I also expect to add the relatively small lpfc update to it once I get second review in proper form. -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [ANNOUNCE] scsi patch queue tree
On 06/02/2014 10:58 AM, Christoph Hellwig wrote: With Linus opening the merge window things should calm down now. I've pushed the mvsas pciid update, and a revert of the be2scsi patch that wasn't quite ready to the drivers-for-3.16 branch. I've also created a new drivers-for-3.16-2 branch that contains the remaining hpsa updates that might be too big for Linus taste that late but should probably be fine. I also expect to add the relatively small lpfc update to it once I get second review in proper form. Hi Christoph Could you please add this very trivial patch for this merge window? http://www.spinics.net/lists/linux-scsi/msg74774.html my hack here: http://www.spinics.net/lists/linux-scsi/msg74775.html Forgot to CC you sorry Thanks Boaz -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [ANNOUNCE] scsi patch queue tree
On Mon, Jun 02, 2014 at 11:25:00AM +0300, Boaz Harrosh wrote: Hi Christoph Could you please add this very trivial patch for this merge window? http://www.spinics.net/lists/linux-scsi/msg74774.html my hack here: http://www.spinics.net/lists/linux-scsi/msg74775.html Looks more like an ack than a hack :) I'll apply it and push it to the core-for-3.16 branch in a minute. -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [ANNOUNCE] scsi patch queue tree
Looks more like an ack than a hack :) Oops so I do need that coffee ;0) -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [ANNOUNCE] scsi patch queue tree
I've pushed the following changes to the drivers-for-3.16 tree. I've there's anyting matching the rules that I did forget please resend and/or ping me. Benoit Taine (2): qla4xxx: Use kmemdup instead of kmalloc + memcpy qla2xxx: Use kmemdup instead of kmalloc + memcpy Dan Carpenter (1): qla2xxx: fix incorrect debug printk Dolev Raviv (4): scsi: ufs: query descriptor API scsi: ufs: device query status and size check scsi: ufs: Logical Unit (LU) command queue depth scsi: ufs: Fix queue depth handling for best effort cases Finn Thain (12): scsi/NCR5380: remove unused BOARD_NORMAL and BOARD_NCR53C400 scsi/NCR5380: remove redundant HOSTS_C macro tests scsi/NCR5380: remove old CVS keywords scsi/NCR5380: use NCR5380_dprint() instead of NCR5380_print() scsi/NCR5380: fix build failures when debugging is enabled scsi/NCR5380: fix dprintk macro usage and definition scsi/NCR5380: adopt NCR5380_dprint() and NCR5380_dprint_phase() scsi/NCR5380: adopt dprintk() scsi/NCR5380: fix and standardize NDEBUG macros scsi/NCR5380: remove unused macro definitions scsi/NCR5380: reduce depth of sun3_scsi nested includes scsi/NCR5380: merge sun3_scsi_vme.c into sun3_scsi.c Jayamohan Kallickal (8): be2iscsi: Fix retrieving MCCQ_WRB in non-embedded Mbox path be2iscsi: Fix exposing Host in sysfs after adapter initialization is complete be2iscsi: Fix interrupt Coalescing mechanism. be2iscsi: Fix TCP parameters while connection offloading. be2iscsi: Fix memory corruption in MBX path be2iscsi: Fix destroy MCC-CQ before MCC-EQ is destroyed be2iscsi: Fix processing cqe for cxn whose endpoint is freed be2iscsi: Bump the driver version Joe Handzik (1): hpsa: fix bad comparison of signed with unsigned in hpsa_update_scsi_devices Matthew Wilcox (7): mpt3sas: Remove uses of serial_number mpt3sas: Remove use of DEF_SCSI_QCMD mpt2sas: Remove uses of serial_number mpt2sas: Remove use of DEF_SCSI_QCMD mpt2sas: Add free smids to the head, not tail of list fusion: Add free msg frames to the head, not tail of list fusion: Remove use of DEF_SCSI_QCMD Sujit Reddy Thumma (6): scsi: ufs: fix endianness sparse warnings scsi: ufs: make undeclared functions static scsi: ufs: Fix broken task management command implementation scsi: ufs: Fix hardware race conditions while aborting a command scsi: ufs: Fix device and host reset methods scsi: ufs: Improve UFS fatal error handling drivers/message/fusion/mptbase.c |2 +- drivers/message/fusion/mptfc.c | 12 +- drivers/message/fusion/mptsas.c | 10 +- drivers/message/fusion/mptscsih.c|8 +- drivers/message/fusion/mptscsih.h|2 +- drivers/message/fusion/mptspi.c | 12 +- drivers/scsi/NCR5380.c | 137 +++-- drivers/scsi/NCR5380.h | 32 +- drivers/scsi/arm/cumana_1.c |3 - drivers/scsi/arm/oak.c |3 - drivers/scsi/atari_NCR5380.c | 162 +++--- drivers/scsi/atari_scsi.c| 22 +- drivers/scsi/atari_scsi.h| 93 --- drivers/scsi/be2iscsi/be.h | 11 + drivers/scsi/be2iscsi/be_cmds.h | 31 +- drivers/scsi/be2iscsi/be_iscsi.c | 12 +- drivers/scsi/be2iscsi/be_main.c | 93 ++- drivers/scsi/be2iscsi/be_main.h |7 +- drivers/scsi/be2iscsi/be_mgmt.c | 64 ++- drivers/scsi/be2iscsi/be_mgmt.h |2 + drivers/scsi/dtc.c |2 - drivers/scsi/g_NCR5380.c |4 - drivers/scsi/g_NCR5380.h |7 - drivers/scsi/hpsa.c |2 +- drivers/scsi/mac_scsi.c | 10 - drivers/scsi/mac_scsi.h | 10 - drivers/scsi/mpt2sas/mpt2sas_base.c |8 +- drivers/scsi/mpt2sas/mpt2sas_base.h |2 +- drivers/scsi/mpt2sas/mpt2sas_ctl.c |2 +- drivers/scsi/mpt2sas/mpt2sas_scsih.c | 24 +- drivers/scsi/mpt3sas/mpt3sas_base.h |2 +- drivers/scsi/mpt3sas/mpt3sas_ctl.c |2 +- drivers/scsi/mpt3sas/mpt3sas_scsih.c | 24 +- drivers/scsi/pas16.h |3 - drivers/scsi/qla2xxx/qla_mbx.c |3 +- drivers/scsi/qla2xxx/qla_os.c|3 +- drivers/scsi/qla4xxx/ql4_os.c|7 +- drivers/scsi/sun3_NCR5380.c | 156 +++-- drivers/scsi/sun3_scsi.c | 238 +--- drivers/scsi/sun3_scsi.h | 199 +-- drivers/scsi/sun3_scsi_vme.c | 588 +-- drivers/scsi/t128.c |4 - drivers/scsi/t128.h |7 - drivers/scsi/ufs/ufs.h | 74 ++- drivers/scsi/ufs/ufshcd.c| 1032 +++--- drivers/scsi/ufs/ufshcd.h| 22 +- drivers/scsi/ufs/ufshci.h|
Re: [ANNOUNCE] scsi patch queue tree
On Wed, May 28, 2014 at 10:37:31AM -0500, Mike Christie wrote: On 05/28/2014 05:54 AM, Christoph Hellwig wrote: be2iscsi: Fix processing cqe for cxn whose endpoint is freed I didn't look at your tree, but when this patch was posted on the list I think it had a bug. http://www.spinics.net/lists/linux-scsi/msg74191.html I read through it and saw your comment, but so far it seems the patch and especially the series does more good than harm. I'll ping the author again to get a fix for the issue you pointed out - I was planning to do that anwyay. -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [ANNOUNCE] scsi patch queue tree
On 5/28/2014 4:24 PM, Christoph Hellwig wrote: I've pushed the following changes to the drivers-for-3.16 tree. I've there's anyting matching the rules that I did forget please resend and/or ping me. Benoit Taine (2): qla4xxx: Use kmemdup instead of kmalloc + memcpy qla2xxx: Use kmemdup instead of kmalloc + memcpy Dan Carpenter (1): qla2xxx: fix incorrect debug printk Dolev Raviv (4): scsi: ufs: query descriptor API scsi: ufs: device query status and size check scsi: ufs: Logical Unit (LU) command queue depth scsi: ufs: Fix queue depth handling for best effort cases The above 4 patches are just posted to mailing lists with no review/ack's yet. I believe it still went in because the sender has modified the author name to himself and signed-off by is present by the original author which worked as a positive review for your rules. I have asked the sender to check why the original author name is changed. Meanwhile, I believe these patches should get some more time for review. -- Regards, Sujit -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [ANNOUNCE] scsi patch queue tree
On Wed, May 28, 2014 at 09:31:14PM +0530, Sujit Reddy Thumma wrote: The above 4 patches are just posted to mailing lists with no review/ack's yet. I believe it still went in because the sender has modified the author name to himself and signed-off by is present by the original author which worked as a positive review for your rules. I have asked the sender to check why the original author name is changed. Meanwhile, I believe these patches should get some more time for review. Yes, I did count this as a positive review for now. I can drop the patches for now. -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [ANNOUNCE] scsi patch queue tree
On 05/28/2014 10:50 AM, Christoph Hellwig wrote: On Wed, May 28, 2014 at 10:37:31AM -0500, Mike Christie wrote: On 05/28/2014 05:54 AM, Christoph Hellwig wrote: be2iscsi: Fix processing cqe for cxn whose endpoint is freed I didn't look at your tree, but when this patch was posted on the list I think it had a bug. http://www.spinics.net/lists/linux-scsi/msg74191.html I read through it and saw your comment, but so far it seems the patch and especially the series does more good than harm. Did you see these patchsets: [PATCH 00/10] qla4xxx: 5.04.00-k5: Updates for scsi misc branch and [PATCH 0/6] qla4xxx: 5.04.00-k6: Updates for scsi misc branch ? I think they should be ok for your tree if you did not see any issues with them. -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [ANNOUNCE] scsi patch queue tree
On Wed, May 28, 2014 at 11:04:31AM -0500, Mike Christie wrote: Did you see these patchsets: [PATCH 00/10] qla4xxx: 5.04.00-k5: Updates for scsi misc branch and [PATCH 0/6] qla4xxx: 5.04.00-k6: Updates for scsi misc branch ? I think they should be ok for your tree if you did not see any issues with them. I did merge them 10 days ago. -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [ANNOUNCE] scsi patch queue tree
Hi Christoph, On Mon, 19 May 2014 22:39:28 -0700 Christoph Hellwig h...@infradead.org wrote: On Tue, May 20, 2014 at 10:03:43AM +1000, Stephen Rothwell wrote: Is this a request for inclusion of those branches into linux-next separately from the scsi tree itself? James said he wants to include it in the scsi tree, but given how late we are in the cycle I'd love to see separate exposure until that happens on a temporary basis. OK, I have added them from today (called scsi-core and scsi-drivers). James, feel free to yell if that is not OK. If these are to stay longer term (and I have no objections given your list of requirements), then you should rename the branches (maybe to -next instead of -3.16). These will be merged after the scsi tree so that they effectively disappear from my radar when they have been merged into James' tree. Currently you are the only contact for problems - let me know if I should add someone else (or a list). Thanks for adding your subsystem tree as a participant of linux-next. As you may know, this is not a judgment of your code. The purpose of linux-next is for integration testing and to lower the impact of conflicts between subsystems in the next merge window. You will need to ensure that the patches/commits in your branches have been: * submitted under GPL v2 (or later) and include the Contributor's Signed-off-by, * posted to the relevant mailing list, * reviewed by you (or another maintainer of your subsystem tree), * successfully unit tested, and * destined for the current or next Linux merge window. Basically, this should be just what you would send to James (or ask him to fetch). They are allowed to be rebased if you deem it necessary. -- Cheers, Stephen Rothwell s...@canb.auug.org.au signature.asc Description: PGP signature
Re: [ANNOUNCE] scsi patch queue tree
On Wed, 2014-05-21 at 09:46 +1000, Stephen Rothwell wrote: Hi Christoph, On Mon, 19 May 2014 22:39:28 -0700 Christoph Hellwig h...@infradead.org wrote: On Tue, May 20, 2014 at 10:03:43AM +1000, Stephen Rothwell wrote: Is this a request for inclusion of those branches into linux-next separately from the scsi tree itself? James said he wants to include it in the scsi tree, but given how late we are in the cycle I'd love to see separate exposure until that happens on a temporary basis. OK, I have added them from today (called scsi-core and scsi-drivers). James, feel free to yell if that is not OK. Let's try the process. If these are to stay longer term (and I have no objections given your list of requirements), then you should rename the branches (maybe to -next instead of -3.16). I'll merge it into for-next in SCSI to make it easier. These will be merged after the scsi tree so that they effectively disappear from my radar when they have been merged into James' tree. Currently you are the only contact for problems - let me know if I should add someone else (or a list). Also cc the scsi mailing list for merge problems, just in case. Thanks, James -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[ANNOUNCE] scsi patch queue tree
I'd like to announce the new scsi patch queue tree, which will pick up any scsi core or driver patches promptly to allow easy integration and feedback that contributors might be used to from other kernel subsystems. There are two branches, one for the SCSI core and upper level drivers, and one for low-level (hardware) drivers: git://git.infradead.org/users/hch/scsi-queue.git core-for-3.16 git://git.infradead.org/users/hch/scsi-queue.git drivers-for-3.16 The rules for the tree are: - it has at least two positive reviews (non-author signoff, reviewed-by or acked-by tags). In practice this means it had at least one and I added another one. - no negative review on the mailing list - it applies cleanly - it compiles cleanly (drivers for architectures I can't test excluded) - for core the core branch: survives a full xfstests run I went through the linux-scsi archives for March, April and May and applied all patches that clearly fit the above criteria, but it's fairly like I missed some. If I'm missing your patch(es): - resend it unless it was sent in the last few weeks - make sure all reviews are recorded in the most recent post of the patch(es) - ping the list for additional reviewers For now the prime intent of the tree is to feed it to James, although I'd welcome everyone interested to pull and test it. If the scheme proves successful I'd love to invite more core scsi contributors to help with it and move to a shared kernel.org tree. -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [ANNOUNCE] scsi patch queue tree
Hi Christoph, On Mon, 19 May 2014 07:06:14 -0700 Christoph Hellwig h...@infradead.org wrote: I'd like to announce the new scsi patch queue tree, which will pick up any scsi core or driver patches promptly to allow easy integration and feedback that contributors might be used to from other kernel subsystems. There are two branches, one for the SCSI core and upper level drivers, and one for low-level (hardware) drivers: git://git.infradead.org/users/hch/scsi-queue.git core-for-3.16 git://git.infradead.org/users/hch/scsi-queue.git drivers-for-3.16 The rules for the tree are: - it has at least two positive reviews (non-author signoff, reviewed-by or acked-by tags). In practice this means it had at least one and I added another one. - no negative review on the mailing list - it applies cleanly - it compiles cleanly (drivers for architectures I can't test excluded) - for core the core branch: survives a full xfstests run I went through the linux-scsi archives for March, April and May and applied all patches that clearly fit the above criteria, but it's fairly like I missed some. If I'm missing your patch(es): - resend it unless it was sent in the last few weeks - make sure all reviews are recorded in the most recent post of the patch(es) - ping the list for additional reviewers For now the prime intent of the tree is to feed it to James, although I'd welcome everyone interested to pull and test it. If the scheme proves successful I'd love to invite more core scsi contributors to help with it and move to a shared kernel.org tree. Is this a request for inclusion of those branches into linux-next separately from the scsi tree itself? -- Cheers, Stephen Rothwells...@canb.auug.org.au signature.asc Description: PGP signature
Re: [ANNOUNCE] scsi patch queue tree
On Tue, May 20, 2014 at 10:03:43AM +1000, Stephen Rothwell wrote: Is this a request for inclusion of those branches into linux-next separately from the scsi tree itself? James said he wants to include it in the scsi tree, but given how late we are in the cycle I'd love to see separate exposure until that happens on a temporary basis. -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
