Re: [PATCH] aacraid: Fix typo in blink status

2017-03-06 Thread Martin K. Petersen 
> "Raghava" == Raghava Aditya Renukunta 
>  writes:

Raghava> The return status of the adapter check on KERNEL_PANIC is
Raghava> supposed to be the upper 16 bits of the OMR status register.

Applied to 4.11/scsi-fixes.

-- 
Martin K. Petersen  Oracle Linux Engineering

RE: [PATCH] aacraid: Fix typo in blink status

2017-03-03 Thread Dave Carroll 
> Subject: [PATCH] aacraid: Fix typo in blink status
> 
> The return status of the adapter check on KERNEL_PANIC is supposed to be
> the upper 16 bits of the OMR status register.
> 
> Fixes: c421530bf848604e (scsi: aacraid: Reorder Adpater status check)
> Reported-by: Dan Carpenter <dan.carpen...@oracle.com>
> Signed-off-by: Raghava Aditya Renukunta
> <raghavaaditya.renuku...@microsemi.com>
> ---
>  drivers/scsi/aacraid/src.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Dave Carroll <david.carr...@microsemi.com>

[PATCH] aacraid: Fix typo in blink status

2017-03-02 Thread Raghava Aditya Renukunta 
The return status of the adapter check on KERNEL_PANIC is supposed
to be the upper 16 bits of the OMR status register.

Fixes: c421530bf848604e (scsi: aacraid: Reorder Adpater status check)
Reported-by: Dan Carpenter 
Signed-off-by: Raghava Aditya Renukunta 
---
 drivers/scsi/aacraid/src.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/aacraid/src.c b/drivers/scsi/aacraid/src.c
index 2e5338d..7b0410e 100644
--- a/drivers/scsi/aacraid/src.c
+++ b/drivers/scsi/aacraid/src.c
@@ -468,7 +468,7 @@ static int aac_src_check_health(struct aac_dev *dev)
return -1;
 
 err_blink:
-   return (status > 16) & 0xFF;
+   return (status >> 16) & 0xFF;
 }
 
 static inline u32 aac_get_vector(struct aac_dev *dev)
-- 
1.8.3.1