Re: [PATCH] aacraid: remove bogus GFP_DMA32 specifies

2018-06-05 Thread Martin K. Petersen


Christoph,

> For one GFP_DMA32 does not actually work with kmalloc, as we only
> have GFP_DMA and GFP_KERNEL caches, but not GFP_DMA32.  Second the
> memory is mapped using the proper DMA API anyway, which would include
> proper bounce buffering if needed by the device.

Applied to 4.18/scsi-fixes. Thanks!

-- 
Martin K. Petersen  Oracle Linux Engineering


Re: [PATCH] aacraid: remove bogus GFP_DMA32 specifies

2018-05-30 Thread Johannes Thumshirn
Looks good,
Reviewed-by: Johannes Thumshirn 
-- 
Johannes Thumshirn  Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850


[PATCH] aacraid: remove bogus GFP_DMA32 specifies

2018-05-30 Thread Christoph Hellwig
For one GFP_DMA32 does not actually work with kmalloc, as we only
have GFP_DMA and GFP_KERNEL caches, but not GFP_DMA32.  Second the
memory is mapped using the proper DMA API anyway, which would include
proper bounce buffering if needed by the device.

Signed-off-by: Christoph Hellwig 
---
 drivers/scsi/aacraid/commctrl.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/scsi/aacraid/commctrl.c b/drivers/scsi/aacraid/commctrl.c
index a2b3430072c7..25f6600d6c09 100644
--- a/drivers/scsi/aacraid/commctrl.c
+++ b/drivers/scsi/aacraid/commctrl.c
@@ -845,7 +845,7 @@ static int aac_send_raw_srb(struct aac_dev* dev, void 
__user * arg)
rcode = -EINVAL;
goto cleanup;
}
-   p = kmalloc(sg_count[i], GFP_KERNEL|GFP_DMA32);
+   p = kmalloc(sg_count[i], GFP_KERNEL);
if (!p) {
dprintk((KERN_DEBUG"aacraid: Could not 
allocate SG buffer - size = %d buffer number %d of %d\n",
sg_count[i], i, usg->count));
@@ -886,7 +886,7 @@ static int aac_send_raw_srb(struct aac_dev* dev, void 
__user * arg)
rcode = -EINVAL;
goto cleanup;
}
-   p = kmalloc(sg_count[i], GFP_KERNEL|GFP_DMA32);
+   p = kmalloc(sg_count[i], GFP_KERNEL);
if (!p) {
dprintk((KERN_DEBUG"aacraid: Could not 
allocate SG buffer - size = %d buffer number %d of %d\n",
  sg_count[i], i, upsg->count));
-- 
2.17.0