Re: [PATCH] beiscsi: the custom_length field has been set to a wrong value.
Oops, I just noticed that bnx2i, be2iscsi: fix custom stats length included this one liner change. Sorry for the stir! -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] beiscsi: the custom_length field has been set to a wrong value.
On 06/26/2014 11:16 AM, Maurizio Lombardi wrote: > In the beiscsi_conn_get_stats() function, custom_length should be set > to 1 to take into account the "eh_abort_cnt" field at custom[0]. > > Signed-off-by: Maurizio Lombardi > --- > drivers/scsi/be2iscsi/be_iscsi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/be2iscsi/be_iscsi.c > b/drivers/scsi/be2iscsi/be_iscsi.c > index fd284ff..8616281 100644 > --- a/drivers/scsi/be2iscsi/be_iscsi.c > +++ b/drivers/scsi/be2iscsi/be_iscsi.c > @@ -914,7 +914,7 @@ void beiscsi_conn_get_stats(struct iscsi_cls_conn > *cls_conn, > stats->r2t_pdus = conn->r2t_pdus_cnt; > stats->digest_err = 0; > stats->timeout_err = 0; > - stats->custom_length = 0; > + stats->custom_length = 1; > strcpy(stats->custom[0].desc, "eh_abort_cnt"); > stats->custom[0].value = conn->eh_abort_cnt; > } Reviewed-by: Tomas Henzl -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] beiscsi: the custom_length field has been set to a wrong value.
On Thu, Jun 26, 2014 at 11:16:26AM +0200, Maurizio Lombardi wrote: > In the beiscsi_conn_get_stats() function, custom_length should be set > to 1 to take into account the "eh_abort_cnt" field at custom[0]. > > Signed-off-by: Maurizio Lombardi Any chance to get a review on this one? > --- > drivers/scsi/be2iscsi/be_iscsi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/be2iscsi/be_iscsi.c > b/drivers/scsi/be2iscsi/be_iscsi.c > index fd284ff..8616281 100644 > --- a/drivers/scsi/be2iscsi/be_iscsi.c > +++ b/drivers/scsi/be2iscsi/be_iscsi.c > @@ -914,7 +914,7 @@ void beiscsi_conn_get_stats(struct iscsi_cls_conn > *cls_conn, > stats->r2t_pdus = conn->r2t_pdus_cnt; > stats->digest_err = 0; > stats->timeout_err = 0; > - stats->custom_length = 0; > + stats->custom_length = 1; > strcpy(stats->custom[0].desc, "eh_abort_cnt"); > stats->custom[0].value = conn->eh_abort_cnt; > } > -- > Maurizio Lombardi > > -- > To unsubscribe from this list: send the line "unsubscribe linux-scsi" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html ---end quoted text--- -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] beiscsi: the custom_length field has been set to a wrong value.
In the beiscsi_conn_get_stats() function, custom_length should be set to 1 to take into account the "eh_abort_cnt" field at custom[0]. Signed-off-by: Maurizio Lombardi --- drivers/scsi/be2iscsi/be_iscsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/be2iscsi/be_iscsi.c b/drivers/scsi/be2iscsi/be_iscsi.c index fd284ff..8616281 100644 --- a/drivers/scsi/be2iscsi/be_iscsi.c +++ b/drivers/scsi/be2iscsi/be_iscsi.c @@ -914,7 +914,7 @@ void beiscsi_conn_get_stats(struct iscsi_cls_conn *cls_conn, stats->r2t_pdus = conn->r2t_pdus_cnt; stats->digest_err = 0; stats->timeout_err = 0; - stats->custom_length = 0; + stats->custom_length = 1; strcpy(stats->custom[0].desc, "eh_abort_cnt"); stats->custom[0].value = conn->eh_abort_cnt; } -- Maurizio Lombardi -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
