Re: [PATCH] drivers/scsi/advansys.c: fix advansys_board_found compile error
Matthew Wilcox wrote: > On Wed, Aug 01, 2007 at 04:27:15PM +0200, Gabriel C wrote: >> Matthew Wilcox wrote: >>> I'd be interested in seeing the results of the randconfig trials on the >>> driver with those 23 patches applied, but not particularly interested in >>> the intermediate result. >> I can do that on weekend. > > Thanks > >> Are the patches meant for -mm or git head ? > > They were developed against git head as of a few days ago. Here's a git > tree, if that's easier for you: > > http://git.kernel.org/?p=linux/kernel/git/willy/advansys.git;a=shortlog > Ach nice , yes is a lot easier to work with git. - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] drivers/scsi/advansys.c: fix advansys_board_found compile error
On Wed, Aug 01, 2007 at 04:27:15PM +0200, Gabriel C wrote: > Matthew Wilcox wrote: > > I'd be interested in seeing the results of the randconfig trials on the > > driver with those 23 patches applied, but not particularly interested in > > the intermediate result. > > I can do that on weekend. Thanks > Are the patches meant for -mm or git head ? They were developed against git head as of a few days ago. Here's a git tree, if that's easier for you: http://git.kernel.org/?p=linux/kernel/git/willy/advansys.git;a=shortlog -- "Bill, look, we understand that you're interested in selling us this operating system, but compare it to ours. We can't possibly take such a retrograde step." - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] drivers/scsi/advansys.c: fix advansys_board_found compile error
Matthew Wilcox wrote: > On Wed, Aug 01, 2007 at 09:39:12PM +0800, Eugene Teo wrote: >> This patch fixes the following compile error: >> >> drivers/scsi/advansys.c: In function 'advansys_board_found': >> drivers/scsi/advansys.c:17781: error: implicit declaration of function >> 'to_pci_dev' > > Or just remove the ifdefs around the include ... which is done in this > patch: > > http://www.kernel.org/pub/linux/kernel/people/willy/advansys-2007-07-30/0001-advansys-version-copyright-etc.txt > > I'd be interested in seeing the results of the randconfig trials on the > driver with those 23 patches applied, but not particularly interested in > the intermediate result. > I can do that on weekend. Are the patches meant for -mm or git head ? - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] drivers/scsi/advansys.c: fix advansys_board_found compile error
Eugene Teo wrote: > Hi Gabriel, Hi Eugene, > Hope the following trivial patch helps. Yes it does , thx. > > >> Getting this with a randconfig ( >> http://194.231.229.228/MM/randconfig-auto-10 ) >> > [...] >> drivers/scsi/advansys.c:794:2: warning: #warning this driver is still not >> properly converted to the DMA API >> drivers/scsi/advansys.c: In function 'advansys_board_found': >> drivers/scsi/advansys.c:17781: error: implicit declaration of function >> 'to_pci_dev' > [...] > > This patch fixes the following compile error: > > drivers/scsi/advansys.c: In function 'advansys_board_found': > drivers/scsi/advansys.c:17781: error: implicit declaration of function > 'to_pci_dev' > > Signed-off-by: Eugene Teo <[EMAIL PROTECTED]> > --- > drivers/scsi/advansys.c |1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/drivers/scsi/advansys.c b/drivers/scsi/advansys.c > index 79c0b6e..908f02b 100644 > --- a/drivers/scsi/advansys.c > +++ b/drivers/scsi/advansys.c > @@ -774,6 +774,7 @@ > #include > #include > #include > +#include > > #include > #include > > - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] drivers/scsi/advansys.c: fix advansys_board_found compile error
On Wed, Aug 01, 2007 at 09:39:12PM +0800, Eugene Teo wrote: > This patch fixes the following compile error: > > drivers/scsi/advansys.c: In function 'advansys_board_found': > drivers/scsi/advansys.c:17781: error: implicit declaration of function > 'to_pci_dev' Or just remove the ifdefs around the include ... which is done in this patch: http://www.kernel.org/pub/linux/kernel/people/willy/advansys-2007-07-30/0001-advansys-version-copyright-etc.txt I'd be interested in seeing the results of the randconfig trials on the driver with those 23 patches applied, but not particularly interested in the intermediate result. -- "Bill, look, we understand that you're interested in selling us this operating system, but compare it to ours. We can't possibly take such a retrograde step." - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] drivers/scsi/advansys.c: fix advansys_board_found compile error
Hi Gabriel, Hope the following trivial patch helps. > Getting this with a randconfig ( http://194.231.229.228/MM/randconfig-auto-10 > ) > [...] > drivers/scsi/advansys.c:794:2: warning: #warning this driver is still not > properly converted to the DMA API > drivers/scsi/advansys.c: In function 'advansys_board_found': > drivers/scsi/advansys.c:17781: error: implicit declaration of function > 'to_pci_dev' [...] This patch fixes the following compile error: drivers/scsi/advansys.c: In function 'advansys_board_found': drivers/scsi/advansys.c:17781: error: implicit declaration of function 'to_pci_dev' Signed-off-by: Eugene Teo <[EMAIL PROTECTED]> --- drivers/scsi/advansys.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/scsi/advansys.c b/drivers/scsi/advansys.c index 79c0b6e..908f02b 100644 --- a/drivers/scsi/advansys.c +++ b/drivers/scsi/advansys.c @@ -774,6 +774,7 @@ #include #include #include +#include #include #include - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
