Re: [PATCH] dtc: Coding police and printk levels

2007-07-11 Thread MikeW 
Alan Cox  lxorguk.ukuu.org.uk> writes:

> 
> On Fri, 22 Jun 2007 11:00:06 -0700
> "Darrick J. Wong"  us.ibm.com> wrote:
> 
> > On Fri, Jun 22, 2007 at 02:26:29PM +0100, Alan Cox wrote:
> > >  -244,7 +242,7 
> > >   if (check_signature(base + 
> > > signatures[sig].offset,
signatures[sig].string,
> strlen(signatures[sig].string))) {
> > >   addr = 
> > > bases[current_base].address;
> > >  #if (DTCDEBUG & DTCDEBUG_INIT)
> > > - printk("scsi-dtc : detected 
> > > board.\n");
> > > + printk(KERB_DEBUG "scsi-dtc : 
> > > detected board.\n");
> > 
> > I think you meant KERN_DEBUG ?
> 
> Thanks - thats a path thats not compiled and I missed that. Will fix it.
> -

I guess we should always test-compile all edited build paths to ensure
we have not broken someone else's build. That's going into my checklist !

Thanks,
MikeW




-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] dtc: Coding police and printk levels

2007-06-22 Thread Alan Cox 
On Fri, 22 Jun 2007 11:00:06 -0700
"Darrick J. Wong" <[EMAIL PROTECTED]> wrote:

> On Fri, Jun 22, 2007 at 02:26:29PM +0100, Alan Cox wrote:
> > @@ -244,7 +242,7 @@
> > if (check_signature(base + 
> > signatures[sig].offset, signatures[sig].string, 
> > strlen(signatures[sig].string))) {
> > addr = 
> > bases[current_base].address;
> >  #if (DTCDEBUG & DTCDEBUG_INIT)
> > -   printk("scsi-dtc : detected 
> > board.\n");
> > +   printk(KERB_DEBUG "scsi-dtc : 
> > detected board.\n");
> 
> I think you meant KERN_DEBUG ?

Thanks - thats a path thats not compiled and I missed that. Will fix it.
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] dtc: Coding police and printk levels

2007-06-22 Thread Darrick J. Wong 
On Fri, Jun 22, 2007 at 02:26:29PM +0100, Alan Cox wrote:
> @@ -244,7 +242,7 @@
>   if (check_signature(base + 
> signatures[sig].offset, signatures[sig].string, 
> strlen(signatures[sig].string))) {
>   addr = 
> bases[current_base].address;
>  #if (DTCDEBUG & DTCDEBUG_INIT)
> - printk("scsi-dtc : detected 
> board.\n");
> + printk(KERB_DEBUG "scsi-dtc : 
> detected board.\n");

I think you meant KERN_DEBUG ?

--D
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] dtc: Coding police and printk levels

2007-06-22 Thread Alan Cox 
Seems printk levels hadn't been invented last time this driver was tidied
up.

Signed-off-by: Alan Cox <[EMAIL PROTECTED]>

diff -u --new-file --recursive --exclude-from /usr/src/exclude 
linux.vanilla-2.6.22-rc4-mm2/drivers/scsi/dtc.c 
linux-2.6.22-rc4-mm2/drivers/scsi/dtc.c
--- linux.vanilla-2.6.22-rc4-mm2/drivers/scsi/dtc.c 2007-06-07 
14:24:28.0 +0100
+++ linux-2.6.22-rc4-mm2/drivers/scsi/dtc.c 2007-06-14 13:43:37.0 
+0100
@@ -137,11 +137,9 @@
 #ifdef OVERRIDE
 [] __initdata = OVERRIDE;
 #else
-[4] __initdata = { {
-0, IRQ_AUTO}, {
-0, IRQ_AUTO}, {
-0, IRQ_AUTO}, {
-0, IRQ_AUTO}};
+[4] __initdata = { 
+   { 0, IRQ_AUTO }, { 0, IRQ_AUTO }, { 0, IRQ_AUTO }, { 0, IRQ_AUTO }
+};
 #endif
 
 #define NO_OVERRIDES ARRAY_SIZE(overrides)
@@ -176,7 +174,7 @@
  * Inputs : str - unused, ints - array of integer parameters with ints[0]
  * equal to the number of ints.
  *
-*/
+ */
 
 static void __init dtc_setup(char *str, int *ints)
 {
@@ -233,7 +231,7 @@
} else
for (; !addr && (current_base < NO_BASES); 
++current_base) {
 #if (DTCDEBUG & DTCDEBUG_INIT)
-   printk("scsi-dtc : probing address %08x\n", 
bases[current_base].address);
+   printk(KERN_DEBUG "scsi-dtc : probing address 
%08x\n", bases[current_base].address);
 #endif
if (bases[current_base].noauto)
continue;
@@ -244,7 +242,7 @@
if (check_signature(base + 
signatures[sig].offset, signatures[sig].string, 
strlen(signatures[sig].string))) {
addr = 
bases[current_base].address;
 #if (DTCDEBUG & DTCDEBUG_INIT)
-   printk("scsi-dtc : detected 
board.\n");
+   printk(KERB_DEBUG "scsi-dtc : 
detected board.\n");
 #endif
goto found;
}
@@ -253,7 +251,7 @@
}
 
 #if defined(DTCDEBUG) && (DTCDEBUG & DTCDEBUG_INIT)
-   printk("scsi-dtc : base = %08x\n", addr);
+   printk(KERN_DEBUG "scsi-dtc : base = %08x\n", addr);
 #endif
 
if (!addr)
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html