Re: [PATCH] iscsi-target: Fix CmdSN comparison (use cmd-cmd_sn instead of cmd-stat_sn)

2013-01-10 Thread Nicholas A. Bellinger 
On Mon, 2013-01-07 at 11:45 -0800, Roland Dreier wrote:
 From: Roland Dreier rol...@purestorage.com
 
 Commit 64c13330a389 (iscsi-target: Fix bug in handling of ExpStatSN
 ACK during u32 wrap-around) introduced a bug where we compare the
 wrong SN against our ExpCmdSN.
 
 Reported-by: Ben Hutchings b...@decadent.org.uk
 Signed-off-by: Roland Dreier rol...@purestorage.com
 ---
  drivers/target/iscsi/iscsi_target_erl2.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
 
 diff --git a/drivers/target/iscsi/iscsi_target_erl2.c 
 b/drivers/target/iscsi/iscsi_target_erl2.c
 index 9ac4c151..ba6091b 100644
 --- a/drivers/target/iscsi/iscsi_target_erl2.c
 +++ b/drivers/target/iscsi/iscsi_target_erl2.c
 @@ -372,7 +372,7 @@ int iscsit_prepare_cmds_for_realligance(struct iscsi_conn 
 *conn)
* made generic here.
*/
   if (!(cmd-cmd_flags  ICF_OOO_CMDSN)  !cmd-immediate_cmd 
 -  iscsi_sna_gte(cmd-stat_sn, conn-sess-exp_cmd_sn)) {
 +  iscsi_sna_gte(cmd-cmd_sn, conn-sess-exp_cmd_sn)) {
   list_del(cmd-i_conn_node);
   spin_unlock_bh(conn-cmd_lock);
   iscsit_free_cmd(cmd);

Thanks for fixing this up.  Applied with another 'CC to stable for Ben 
Co. to pick this up..

--nab


--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] iscsi-target: Fix CmdSN comparison (use cmd-cmd_sn instead of cmd-stat_sn)

2013-01-07 Thread Roland Dreier 
From: Roland Dreier rol...@purestorage.com

Commit 64c13330a389 (iscsi-target: Fix bug in handling of ExpStatSN
ACK during u32 wrap-around) introduced a bug where we compare the
wrong SN against our ExpCmdSN.

Reported-by: Ben Hutchings b...@decadent.org.uk
Signed-off-by: Roland Dreier rol...@purestorage.com
---
 drivers/target/iscsi/iscsi_target_erl2.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/target/iscsi/iscsi_target_erl2.c 
b/drivers/target/iscsi/iscsi_target_erl2.c
index 9ac4c151..ba6091b 100644
--- a/drivers/target/iscsi/iscsi_target_erl2.c
+++ b/drivers/target/iscsi/iscsi_target_erl2.c
@@ -372,7 +372,7 @@ int iscsit_prepare_cmds_for_realligance(struct iscsi_conn 
*conn)
 * made generic here.
 */
if (!(cmd-cmd_flags  ICF_OOO_CMDSN)  !cmd-immediate_cmd 
-iscsi_sna_gte(cmd-stat_sn, conn-sess-exp_cmd_sn)) {
+iscsi_sna_gte(cmd-cmd_sn, conn-sess-exp_cmd_sn)) {
list_del(cmd-i_conn_node);
spin_unlock_bh(conn-cmd_lock);
iscsit_free_cmd(cmd);
-- 
1.8.0

--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html