Re: [PATCH] iser: set sector for ambiguous mr status errors

[Jason Gunthorpe]

On Wed, Nov 14, 2018 at 10:17:01AM -0800, Sagi Grimberg wrote:
> If for some reason we failed to query the mr status, we need to make sure
> to provide sufficient information for an ambiguous error (guard error on
> sector 0).
> 
> Fixes: 0a7a08ad6f5f ("IB/iser: Implement check_protection")
> Cc: 
> Reported-by: Dan Carpenter 
> Signed-off-by: Sagi Grimberg 
> ---
>  drivers/infiniband/ulp/iser/iser_verbs.c | 7 +++
>  1 file changed, 3 insertions(+), 4 deletions(-)

Applied to for-rc

Thanks,
Jason

[PATCH] iser: set sector for ambiguous mr status errors

[Sagi Grimberg]

If for some reason we failed to query the mr status, we need to make sure
to provide sufficient information for an ambiguous error (guard error on
sector 0).

Fixes: 0a7a08ad6f5f ("IB/iser: Implement check_protection")
Cc: 
Reported-by: Dan Carpenter 
Signed-off-by: Sagi Grimberg 
---
 drivers/infiniband/ulp/iser/iser_verbs.c | 7 +++
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/infiniband/ulp/iser/iser_verbs.c 
b/drivers/infiniband/ulp/iser/iser_verbs.c
index 946b623ba5eb..ab137bafa8a8 100644
--- a/drivers/infiniband/ulp/iser/iser_verbs.c
+++ b/drivers/infiniband/ulp/iser/iser_verbs.c
@@ -1124,7 +1124,9 @@ u8 iser_check_task_pi_status(struct iscsi_iser_task 
*iser_task,
 IB_MR_CHECK_SIG_STATUS, _status);
if (ret) {
pr_err("ib_check_mr_status failed, ret %d\n", ret);
-   goto err;
+   /* Not alot we can do, return ambiguous guard error */
+   *sector = 0;
+   return 0x1;
}
 
if (mr_status.fail_status & IB_MR_CHECK_SIG_STATUS) {
@@ -1152,9 +1154,6 @@ u8 iser_check_task_pi_status(struct iscsi_iser_task 
*iser_task,
}
 
return 0;
-err:
-   /* Not alot we can do here, return ambiguous guard error */
-   return 0x1;
 }
 
 void iser_err_comp(struct ib_wc *wc, const char *type)
-- 
2.17.1