Re: [PATCH] lpfc: correct sg_seg_cnt attribute min vs default

[Martin K. Petersen]

James,

> Prior patch mixed up what argument in the macro was what, so min
> value was placed as the "default" argument, and the default value
> was placed as the "min" argument. Thus, when the default was applied,
> it looked like the default was smaller than the allowed min.
>
> swap argument postions to correct.

Applied to 4.16/scsi-queue (after fixing whitespace error). Thanks!

-- 
Martin K. Petersen  Oracle Linux Engineering

Re: [PATCH] lpfc: correct sg_seg_cnt attribute min vs default

[Johannes Thumshirn]

Thanks a lot,
Reviewed-by: Johannes Thumshirn 
-- 
Johannes Thumshirn  Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850

[PATCH] lpfc: correct sg_seg_cnt attribute min vs default

[James Smart]

Prior patch mixed up what argument in the macro was what, so min
value was placed as the "default" argument, and the default value
was placed as the "min" argument. Thus, when the default was applied,
it looked like the default was smaller than the allowed min.

swap argument postions to correct.

Signed-off-by: James Smart 
---
 drivers/scsi/lpfc/lpfc_attr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/lpfc/lpfc_attr.c b/drivers/scsi/lpfc/lpfc_attr.c
index 797bb42a6306..8938c867ed2c 100644
--- a/drivers/scsi/lpfc/lpfc_attr.c
+++ b/drivers/scsi/lpfc/lpfc_attr.c
@@ -5174,7 +5174,7 @@ LPFC_ATTR(delay_discovery, 0, 0, 1,
  * this parameter will be limited to 128 if BlockGuard is enabled under SLI4
  * and will be limited to 512 if BlockGuard is enabled under SLI3.
  */
-LPFC_ATTR_R(sg_seg_cnt, LPFC_MIN_SG_SEG_CNT, LPFC_DEFAULT_SG_SEG_CNT,
+LPFC_ATTR_R(sg_seg_cnt, LPFC_DEFAULT_SG_SEG_CNT, LPFC_MIN_SG_SEG_CNT, 
LPFC_MAX_SG_SEG_CNT, "Max Scatter Gather Segment Count");
 
 /*
-- 
2.13.1