Re: [PATCH] megaraid_sas: fix macro MEGASAS_IS_LOGICAL to avoid regression caused by commit 1e793f6fc0db920400574211c48f9157a37e3945
> "Sumit" == Sumit Saxena writes: Sumit> This patch will fix regression caused by below commit- 1e793f6 Sumit> scsi: megaraid_sas: Fix data integrity failure for JBOD Sumit> (passthrough) devices Sumit> The problem was MEGASAS_IS_LOGICAL macro does not have braces and Sumit> because of above commit using this macro was exposing lot of Sumit> non-existing SCSI devices(all SCSI commands to channels-1,2,3 was Sumit> returned as SUCCESS-DID_OK by driver). Applied to 4.9/scsi-fixes. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] megaraid_sas: fix macro MEGASAS_IS_LOGICAL to avoid regression caused by commit 1e793f6fc0db920400574211c48f9157a37e3945
On 11/09/2016 03:59 AM, Sumit Saxena wrote: This patch will fix regression caused by below commit- 1e793f6 scsi: megaraid_sas: Fix data integrity failure for JBOD (passthrough) devices The problem was MEGASAS_IS_LOGICAL macro does not have braces and because of above commit using this macro was exposing lot of non-existing SCSI devices(all SCSI commands to channels-1,2,3 was returned as SUCCESS-DID_OK by driver). Fixes: 1e793f6fc0db920400574211c48f9157a37e3945 Reported-by: Jens Axboe CC: sta...@vger.kernel.org Signed-off-by: Kashyap Desai Signed-off-by: Sumit Saxena Tested-by: Sumit Saxena Tested-by: Jens Axboe -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] megaraid_sas: fix macro MEGASAS_IS_LOGICAL to avoid regression caused by commit 1e793f6fc0db920400574211c48f9157a37e3945
On 9.11.2016 11:59, Sumit Saxena wrote: > This patch will fix regression caused by below commit- > 1e793f6 scsi: megaraid_sas: Fix data integrity failure for JBOD (passthrough) > devices > > The problem was MEGASAS_IS_LOGICAL macro does not have braces and because of > above commit > using this macro was exposing lot of non-existing SCSI devices(all SCSI > commands to channels-1,2,3 was > returned as SUCCESS-DID_OK by driver). > > Fixes: 1e793f6fc0db920400574211c48f9157a37e3945 > Reported-by: Jens Axboe > CC: sta...@vger.kernel.org > Signed-off-by: Kashyap Desai > Signed-off-by: Sumit Saxena > Tested-by: Sumit Saxena Reviewed-by: Tomas Henzl Tomas -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] megaraid_sas: fix macro MEGASAS_IS_LOGICAL to avoid regression caused by commit 1e793f6fc0db920400574211c48f9157a37e3945
This patch will fix regression caused by below commit- 1e793f6 scsi: megaraid_sas: Fix data integrity failure for JBOD (passthrough) devices The problem was MEGASAS_IS_LOGICAL macro does not have braces and because of above commit using this macro was exposing lot of non-existing SCSI devices(all SCSI commands to channels-1,2,3 was returned as SUCCESS-DID_OK by driver). Fixes: 1e793f6fc0db920400574211c48f9157a37e3945 Reported-by: Jens Axboe CC: sta...@vger.kernel.org Signed-off-by: Kashyap Desai Signed-off-by: Sumit Saxena Tested-by: Sumit Saxena --- drivers/scsi/megaraid/megaraid_sas.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/megaraid/megaraid_sas.h b/drivers/scsi/megaraid/megaraid_sas.h index ca86c88..3aaea71 100644 --- a/drivers/scsi/megaraid/megaraid_sas.h +++ b/drivers/scsi/megaraid/megaraid_sas.h @@ -2233,7 +2233,7 @@ struct megasas_instance_template { }; #define MEGASAS_IS_LOGICAL(scp) \ - (scp->device->channel < MEGASAS_MAX_PD_CHANNELS) ? 0 : 1 + ((scp->device->channel < MEGASAS_MAX_PD_CHANNELS) ? 0 : 1) #define MEGASAS_DEV_INDEX(scp) \ (((scp->device->channel % 2) * MEGASAS_MAX_DEV_PER_CHANNEL) + \ -- 1.8.3.1 -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html