Re: [PATCH] scsi: Remove use of struct timeval

[Arnd Bergmann]

On Wednesday 04 February 2015 08:34:48 Tina Ruchandani wrote:
 Function stex_gettime uses 'struct timeval' whose tv_sec value
 will overflow on 32-bit systems in year 2038 and beyond. This patch
 replaces the use of struct timeval and do_gettimeofday with
 ktime_get_real_seconds, which returns a 64-bit seconds value.
 
 Signed-off-by: Tina Ruchandani ruchandani.t...@gmail.com
 

Acked-by: Arnd Bergmann a...@arndb.de

The patch looks good, but please send it again with a proper
subject that mentions the name of the driver.

Arnd
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] scsi: Remove use of struct timeval

[Tina Ruchandani]

Function stex_gettime uses 'struct timeval' whose tv_sec value
will overflow on 32-bit systems in year 2038 and beyond. This patch
replaces the use of struct timeval and do_gettimeofday with
ktime_get_real_seconds, which returns a 64-bit seconds value.

Signed-off-by: Tina Ruchandani ruchandani.t...@gmail.com
---
 drivers/scsi/stex.c | 6 ++
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/scsi/stex.c b/drivers/scsi/stex.c
index 98a62bc..40b6290 100644
--- a/drivers/scsi/stex.c
+++ b/drivers/scsi/stex.c
@@ -25,6 +25,7 @@
 #include linux/types.h
 #include linux/module.h
 #include linux/spinlock.h
+#include linux/ktime.h
 #include asm/io.h
 #include asm/irq.h
 #include asm/byteorder.h
@@ -364,10 +365,7 @@ MODULE_VERSION(ST_DRIVER_VERSION);
 
 static void stex_gettime(__le64 *time)
 {
-   struct timeval tv;
-
-   do_gettimeofday(tv);
-   *time = cpu_to_le64(tv.tv_sec);
+   *time = cpu_to_le64(ktime_get_real_seconds());
 }
 
 static struct status_msg *stex_get_status(struct st_hba *hba)
-- 
2.2.0.rc0.207.ga3a616c

--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html