Re: [PATCH] scsi: stex: make S6flag static

2017-04-26 Thread Martin K. Petersen 

Colin,

> This module specific flag can be made static as it does not need to be
> in global scope.

Applied to 4.12/scsi-queue.

-- 
Martin K. Petersen  Oracle Linux Engineering

Re: [PATCH] scsi: stex: make S6flag static

2017-04-25 Thread Charles Chiou 

Looks good to me.
Thanks for the improvement.

On 4/26/2017 1:36 AM, Colin King wrote:

From: Colin Ian King 

This module specific flag can be made static as it does
not need to be in global scope.


> Reviewed-by: Charles Chiou 

Signed-off-by: Colin Ian King 
---
  drivers/scsi/stex.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/stex.c b/drivers/scsi/stex.c
index 0751561b59da..9b20643ab49d 100644
--- a/drivers/scsi/stex.c
+++ b/drivers/scsi/stex.c
@@ -363,7 +363,7 @@ struct st_card_info {
u16 sts_count;
  };
  
-int S6flag;

+static int S6flag;
  static int stex_halt(struct notifier_block *nb, ulong event, void *buf);
  static struct notifier_block stex_notifier = {
stex_halt, NULL, 0

[PATCH] scsi: stex: make S6flag static

2017-04-25 Thread Colin King 
From: Colin Ian King 

This module specific flag can be made static as it does
not need to be in global scope.

Signed-off-by: Colin Ian King 
---
 drivers/scsi/stex.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/stex.c b/drivers/scsi/stex.c
index 0751561b59da..9b20643ab49d 100644
--- a/drivers/scsi/stex.c
+++ b/drivers/scsi/stex.c
@@ -363,7 +363,7 @@ struct st_card_info {
u16 sts_count;
 };
 
-int S6flag;
+static int S6flag;
 static int stex_halt(struct notifier_block *nb, ulong event, void *buf);
 static struct notifier_block stex_notifier = {
stex_halt, NULL, 0
-- 
2.11.0