Re: [PATCH] sd: Fix discard granularity when LBPRZ=1

2016-03-08 Thread Martin K. Petersen 
> "Bart" == Bart Van Assche  writes:

Bart> Please fix the spelling of "deterministic" in the patch
Bart> description. With or without that change:

Bart> Reviewed-by: Bart Van Assche 

Fixed, thanks!

-- 
Martin K. Petersen  Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] sd: Fix discard granularity when LBPRZ=1

2016-03-08 Thread Bart Van Assche 

On 03/05/2016 03:10 PM, Martin K. Petersen wrote:

Commit 397737223c59 ("sd: Make discard granularity match logical block
size when LBPRZ=1") accidentally set the granularity to one byte instead
of one logical block on devices that provide determistic zeroes after
UNMAP.

Signed-off-by: Martin K. Petersen 
Reported-by: Mike Snitzer 
Fixes: 397737223c59e89dca7305feb6528caef8fbef84
Cc:  # 4.4+
---
  drivers/scsi/sd.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
index d749da765df1..5a5457ac9cdb 100644
--- a/drivers/scsi/sd.c
+++ b/drivers/scsi/sd.c
@@ -648,7 +648,7 @@ static void sd_config_discard(struct scsi_disk *sdkp, 
unsigned int mode)
 */
if (sdkp->lbprz) {
q->limits.discard_alignment = 0;
-   q->limits.discard_granularity = 1;
+   q->limits.discard_granularity = logical_block_size;
} else {
q->limits.discard_alignment = sdkp->unmap_alignment *
logical_block_size;


Please fix the spelling of "deterministic" in the patch description. 
With or without that change:


Reviewed-by: Bart Van Assche 
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] sd: Fix discard granularity when LBPRZ=1

2016-03-07 Thread Martin K. Petersen 
> "Ewan" == Ewan Milne  writes:
>> Commit 397737223c59 ("sd: Make discard granularity match logical
>> block size when LBPRZ=1") accidentally set the granularity to one
>> byte instead of one logical block on devices that provide determistic
>> zeroes after UNMAP.

Ewan> Reviewed-by: Ewan D. Milne 

I'll need another reviewer for this.

Thanks!

-- 
Martin K. Petersen  Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] sd: Fix discard granularity when LBPRZ=1

2016-03-07 Thread Ewan Milne 
On Sat, 2016-03-05 at 18:10 -0500, Martin K. Petersen wrote:
> Commit 397737223c59 ("sd: Make discard granularity match logical block
> size when LBPRZ=1") accidentally set the granularity to one byte instead
> of one logical block on devices that provide determistic zeroes after
> UNMAP.
> 
> Signed-off-by: Martin K. Petersen 
> Reported-by: Mike Snitzer 
> Fixes: 397737223c59e89dca7305feb6528caef8fbef84
> Cc:  # 4.4+
> ---
>  drivers/scsi/sd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
> index d749da765df1..5a5457ac9cdb 100644
> --- a/drivers/scsi/sd.c
> +++ b/drivers/scsi/sd.c
> @@ -648,7 +648,7 @@ static void sd_config_discard(struct scsi_disk *sdkp, 
> unsigned int mode)
>*/
>   if (sdkp->lbprz) {
>   q->limits.discard_alignment = 0;
> - q->limits.discard_granularity = 1;
> + q->limits.discard_granularity = logical_block_size;
>   } else {
>   q->limits.discard_alignment = sdkp->unmap_alignment *
>   logical_block_size;

Reviewed-by: Ewan D. Milne 


--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] sd: Fix discard granularity when LBPRZ=1

2016-03-05 Thread Martin K. Petersen 
Commit 397737223c59 ("sd: Make discard granularity match logical block
size when LBPRZ=1") accidentally set the granularity to one byte instead
of one logical block on devices that provide determistic zeroes after
UNMAP.

Signed-off-by: Martin K. Petersen 
Reported-by: Mike Snitzer 
Fixes: 397737223c59e89dca7305feb6528caef8fbef84
Cc:  # 4.4+
---
 drivers/scsi/sd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
index d749da765df1..5a5457ac9cdb 100644
--- a/drivers/scsi/sd.c
+++ b/drivers/scsi/sd.c
@@ -648,7 +648,7 @@ static void sd_config_discard(struct scsi_disk *sdkp, 
unsigned int mode)
 */
if (sdkp->lbprz) {
q->limits.discard_alignment = 0;
-   q->limits.discard_granularity = 1;
+   q->limits.discard_granularity = logical_block_size;
} else {
q->limits.discard_alignment = sdkp->unmap_alignment *
logical_block_size;
-- 
2.7.0

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html