Re: [PATCH -next] scsi: libfc: Remove set but not used variable 'disc'

2018-11-21 Thread YueHaibing 
On 2018/11/22 11:15, Martin K. Petersen wrote:
> 
> YueHaibing,
> 
>> From: Yue Haibing 
>>
>> Fixes gcc '-Wunused-but-set-variable' warning:
>>
>> drivers/scsi/libfc/fc_rport.c: In function 'fc_rport_recv_flogi_req':
>> drivers/scsi/libfc/fc_rport.c:866:18: warning:
>>  variable 'disc' set but not used [-Wunused-but-set-variable]
>>
>> It no used any more after
>> commit baa6719f902a （"libfc: Update rport reference counting")
>   ^^^
> 
> Please run checkpatch. Fixed it up and applied to 4.21/scsi-queue.

Sorry for this， I will remember to do it next time.

>

Re: [PATCH -next] scsi: libfc: Remove set but not used variable 'disc'

2018-11-21 Thread Martin K. Petersen 


YueHaibing,

> From: Yue Haibing 
>
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/scsi/libfc/fc_rport.c: In function 'fc_rport_recv_flogi_req':
> drivers/scsi/libfc/fc_rport.c:866:18: warning:
>  variable 'disc' set but not used [-Wunused-but-set-variable]
>
> It no used any more after
> commit baa6719f902a （"libfc: Update rport reference counting")
  ^^^

Please run checkpatch. Fixed it up and applied to 4.21/scsi-queue.

-- 
Martin K. Petersen  Oracle Linux Engineering

Re: [PATCH -next] scsi: libfc: Remove set but not used variable 'disc'

2018-11-16 Thread Johannes Thumshirn 
Looks good,

Reviewed-by: Johannes Thumshirn