Re: [PATCH 0/2] Include protection information in iscsi header
On 6/3/2014 9:16 AM, Roland Dreier wrote: On Sun, Jun 1, 2014 at 9:19 AM, Sagi Grimberg sa...@mellanox.com wrote: Although these patches involve 3 subsystems with different maintainers (scsi, iser, target) I would prefer seeing these patches included together. Why? Because they break wire compatibility? I hate to say it but even if they're merged at the same time, you can't guarantee that targets and initiators will be updated together. Yes that's true, but still I would like to avoid a kernel release that the target and initiator can't talk to one another... Sagi. -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/2] Include protection information in iscsi header
On Sun, Jun 1, 2014 at 9:19 AM, Sagi Grimberg sa...@mellanox.com wrote: Although these patches involve 3 subsystems with different maintainers (scsi, iser, target) I would prefer seeing these patches included together. Why? Because they break wire compatibility? I hate to say it but even if they're merged at the same time, you can't guarantee that targets and initiators will be updated together. -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/2] Include protection information in iscsi header
On Tue, Jun 3, 2014 at 9:16 AM, Roland Dreier rol...@purestorage.com wrote: On Sun, Jun 1, 2014 at 9:19 AM, Sagi Grimberg sa...@mellanox.com wrote: Although these patches involve 3 subsystems with different maintainers (scsi, iser, target) I would prefer seeing these patches included together. Why? Because they break wire compatibility? I hate to say it but even if they're merged at the same time, you can't guarantee that targets and initiators will be updated together. Guys, this all deals with code merged in 3.15-rc1, and (thanks god and linus that -rc8 took place this cycle) 3.15 isn't out yet!! -- so we just need to act quickly and this (having the fix in 3.15 or if too late in 3.15.1) would be OK -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 0/2] Include protection information in iscsi header
At the SCSI transport level, there is no distinction between user data and protection information. Thus, iscsi header field expected data transfer length should include protection information. This set modifies both the iscsi initiator (patch #1), and target (patch #2) to expect data length which includes protection information. Although these patches involve 3 subsystems with different maintainers (scsi, iser, target) I would prefer seeing these patches included together. Sagi Grimberg (2): libiscsi, iser: Adjust data_length to include protection information TARGET/sbc,loopback: Adjust command data length in case pi exists on the wire drivers/infiniband/ulp/iser/iser_initiator.c | 34 +++- drivers/scsi/libiscsi.c | 35 +- drivers/target/loopback/tcm_loop.c | 35 +++--- drivers/target/target_core_sbc.c | 15 +- include/scsi/libiscsi.h | 19 ++ 5 files changed, 107 insertions(+), 31 deletions(-) -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
