RE: [PATCH 0/2] hpsa: fix rmmod issues
From: Martin Wilck [mwi...@suse.de] Sent: Friday, December 02, 2016 12:58 AM To: Don Brace Cc: dl-esc-Team ESD Storage Dev Support; iss_storage...@hp.com; linux-scsi@vger.kernel.org; James Bottomley; h...@lst.de; h...@suse.de; jthumsh...@suse.com Subject: Re: [PATCH 0/2] hpsa: fix rmmod issues EXTERNAL EMAIL On Thu, 2016-12-01 at 23:22 +, Don Brace wrote: > > -Original Message- > > From: Martin Wilck [mailto:mwi...@suse.de] > > Sent: Monday, November 21, 2016 8:04 AM > > To: Don Brace > > Cc: dl-esc-Team ESD Storage Dev Support; iss_storage...@hp.com; > > linux- > > s...@vger.kernel.org; jbottom...@odin.com; h...@lst.de; h...@suse.de > > ; > > Martin Wilck > > Subject: [PATCH 0/2] hpsa: fix rmmod issues > > > > EXTERNAL EMAIL > > > > > > This patch set fixes two issues I encountered when removing the > > hpsa modules with rmmod. > > > > Comments and reviews are welcome. > > > > Martin Wilck (2): > > hpsa: cleanup sas_phy structures in sysfs when unloading > > hpsa: destroy sas transport properties before scsi_host > > > > drivers/scsi/hpsa.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > -- > > 2.10.1 > > I have both patches applied and I still get stack traces. Hm, there must be a difference between 4.9.0 and the SUSE kernel that I tested with, then. To be certain, you did NOT see a stack trace at rmmod before applying my patches? I can see that your trace occurs in a different code path (bsg_unregister_queue()) than the ones I observed (sas_port_delete()/sas_phy_delete()). CC'ing Johannes who alluded to a generic problem in the SCSI stack during our internal discussion. Anyway, I'll have another look. Regards Martin I do see a stack trace before your patches. You patches have made a difference. I am not yet sure when they started,. Will have to start doing some more investigation also, Appreciate the help. Thanks, Don > > > > [252338.604903] [ cut here ] > [252338.627899] WARNING: CPU: 69 PID: 23977 at fs/sysfs/group.c:237 > sysfs_remove_group+0x8e/0x90 > [252338.668726] sysfs group 'power' not found for kobject '5:0:0:0' > [252338.697526] Modules linked in: hpsa(OE-) scsi_transport_sas(OE) > ip6t_rpfilter ip6t_REJECT nf_reject_ipv6 nf_conntrack_ipv6 > nf_defrag_ipv6 ipt_REJECT nf_reject_ipv4 nf_conntrack_ipv4 > nf_defrag_ipv4 xt_conntrack nf_conntrack cfg80211 rfkill ebtable_nat > ebtable_broute bridge stp llc ebtable_filter ebtables ip6table_mangle > ip6table_security ip6table_raw ip6table_filter ip6_tables > iptable_mangle iptable_security iptable_raw iptable_filter ip_tables > osst ch st sb_edac edac_core x86_pkg_temp_thermal coretemp > crct10dif_pclmul crc32_pclmul ghash_clmulni_intel aesni_intel lrw > iTCO_wdt gf128mul glue_helper iTCO_vendor_support ablk_helper cryptd > pcspkr ioatdma lpc_ich hpwdt hpilo mfd_core dca ipmi_si wmi > ipmi_msghandler pcc_cpufreq acpi_cpufreq acpi_power_meter uinput > mgag200 i2c_algo_bit drm_kms_helper syscopyarea > [252339.038528] sysfillrect sysimgblt fb_sys_fops ttm drm > crc32c_intel serio_raw tg3 ptp usb_storage i2c_core pps_core > dm_mirror dm_region_hash dm_log dm_mod [last unloaded: > scsi_transport_sas] > [252339.113923] CPU: 69 PID: 23977 Comm: rmmod Tainted: > GW OE 4.9.0-rc71+ #24 > [252339.151296] Hardware name: HP ProLiant DL580 Gen8, BIOS P79 > 08/18/2016 > [252339.183354] c9000ff1bbf0 815909bd c9000ff1bc40 > > [252339.219046] c9000ff1bc30 81090901 00ed0246 > > [252339.255044] 81f71560 88204584dd38 882051e93670 > 00ae1090 > [252339.290927] Call Trace: > [252339.303968] [] dump_stack+0x85/0xc8 > [252339.329624] [] __warn+0xd1/0xf0 > [252339.354037] [] warn_slowpath_fmt+0x5f/0x80 > [252339.382084] [] ? mutex_unlock+0xe/0x10 > [252339.408515] [] ? > kernfs_find_and_get_ns+0x4a/0x60 > [252339.439571] [] sysfs_remove_group+0x8e/0x90 > [252339.468069] [] dpm_sysfs_remove+0x57/0x60 > [252339.495701] [] device_del+0x58/0x270 > [252339.521474] [] device_unregister+0x1a/0x60 > [252339.549796] [] bsg_unregister_queue+0x60/0xa0 > [252339.578999] [] __scsi_remove_device+0xaa/0xd0 > [252339.608230] [] scsi_forget_host+0x69/0x70 > [252339.635723] [] scsi_remove_host+0x82/0x130 > [252339.663738] [] hpsa_remove_one+0x93/0x190 > [hpsa] > [252339.694960] [] pci_device_remove+0x39/0xc0 > [252339.723128] [] > __device_release_driver+0x9a/0x150 > [252339.753539] [] driver_detach+0xc1/0xd0 > [252339.779784] [] bus_remove_driver+0x58/0xd0 > [252339.807519] [] driver_unregister+0x2c/0x50
Re: [PATCH 0/2] hpsa: fix rmmod issues
On Thu, 2016-12-01 at 23:22 +, Don Brace wrote: > > -Original Message- > > From: Martin Wilck [mailto:mwi...@suse.de] > > Sent: Monday, November 21, 2016 8:04 AM > > To: Don Brace > > Cc: dl-esc-Team ESD Storage Dev Support; iss_storage...@hp.com; > > linux- > > s...@vger.kernel.org; jbottom...@odin.com; h...@lst.de; h...@suse.de > > ; > > Martin Wilck > > Subject: [PATCH 0/2] hpsa: fix rmmod issues > > > > EXTERNAL EMAIL > > > > > > This patch set fixes two issues I encountered when removing the > > hpsa modules with rmmod. > > > > Comments and reviews are welcome. > > > > Martin Wilck (2): > > hpsa: cleanup sas_phy structures in sysfs when unloading > > hpsa: destroy sas transport properties before scsi_host > > > > drivers/scsi/hpsa.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > -- > > 2.10.1 > > I have both patches applied and I still get stack traces. Hm, there must be a difference between 4.9.0 and the SUSE kernel that I tested with, then. To be certain, you did NOT see a stack trace at rmmod before applying my patches? I can see that your trace occurs in a different code path (bsg_unregister_queue()) than the ones I observed (sas_port_delete()/sas_phy_delete()). CC'ing Johannes who alluded to a generic problem in the SCSI stack during our internal discussion. Anyway, I'll have another look. Regards Martin > > > > [252338.604903] [ cut here ] > [252338.627899] WARNING: CPU: 69 PID: 23977 at fs/sysfs/group.c:237 > sysfs_remove_group+0x8e/0x90 > [252338.668726] sysfs group 'power' not found for kobject '5:0:0:0' > [252338.697526] Modules linked in: hpsa(OE-) scsi_transport_sas(OE) > ip6t_rpfilter ip6t_REJECT nf_reject_ipv6 nf_conntrack_ipv6 > nf_defrag_ipv6 ipt_REJECT nf_reject_ipv4 nf_conntrack_ipv4 > nf_defrag_ipv4 xt_conntrack nf_conntrack cfg80211 rfkill ebtable_nat > ebtable_broute bridge stp llc ebtable_filter ebtables ip6table_mangle > ip6table_security ip6table_raw ip6table_filter ip6_tables > iptable_mangle iptable_security iptable_raw iptable_filter ip_tables > osst ch st sb_edac edac_core x86_pkg_temp_thermal coretemp > crct10dif_pclmul crc32_pclmul ghash_clmulni_intel aesni_intel lrw > iTCO_wdt gf128mul glue_helper iTCO_vendor_support ablk_helper cryptd > pcspkr ioatdma lpc_ich hpwdt hpilo mfd_core dca ipmi_si wmi > ipmi_msghandler pcc_cpufreq acpi_cpufreq acpi_power_meter uinput > mgag200 i2c_algo_bit drm_kms_helper syscopyarea > [252339.038528] sysfillrect sysimgblt fb_sys_fops ttm drm > crc32c_intel serio_raw tg3 ptp usb_storage i2c_core pps_core > dm_mirror dm_region_hash dm_log dm_mod [last unloaded: > scsi_transport_sas] > [252339.113923] CPU: 69 PID: 23977 Comm: rmmod Tainted: > GW OE 4.9.0-rc71+ #24 > [252339.151296] Hardware name: HP ProLiant DL580 Gen8, BIOS P79 > 08/18/2016 > [252339.183354] c9000ff1bbf0 815909bd c9000ff1bc40 > > [252339.219046] c9000ff1bc30 81090901 00ed0246 > > [252339.255044] 81f71560 88204584dd38 882051e93670 > 00ae1090 > [252339.290927] Call Trace: > [252339.303968] [] dump_stack+0x85/0xc8 > [252339.329624] [] __warn+0xd1/0xf0 > [252339.354037] [] warn_slowpath_fmt+0x5f/0x80 > [252339.382084] [] ? mutex_unlock+0xe/0x10 > [252339.408515] [] ? > kernfs_find_and_get_ns+0x4a/0x60 > [252339.439571] [] sysfs_remove_group+0x8e/0x90 > [252339.468069] [] dpm_sysfs_remove+0x57/0x60 > [252339.495701] [] device_del+0x58/0x270 > [252339.521474] [] device_unregister+0x1a/0x60 > [252339.549796] [] bsg_unregister_queue+0x60/0xa0 > [252339.578999] [] __scsi_remove_device+0xaa/0xd0 > [252339.608230] [] scsi_forget_host+0x69/0x70 > [252339.635723] [] scsi_remove_host+0x82/0x130 > [252339.663738] [] hpsa_remove_one+0x93/0x190 > [hpsa] > [252339.694960] [] pci_device_remove+0x39/0xc0 > [252339.723128] [] > __device_release_driver+0x9a/0x150 > [252339.753539] [] driver_detach+0xc1/0xd0 > [252339.779784] [] bus_remove_driver+0x58/0xd0 > [252339.807519] [] driver_unregister+0x2c/0x50 > [252339.835948] [] pci_unregister_driver+0x2a/0x80 > [252339.865660] [] hpsa_cleanup+0x10/0x7a7 [hpsa] > [252339.894682] [] SyS_delete_module+0x1bc/0x220 > [252339.924020] [] do_syscall_64+0x6c/0x200 > [252339.950862] [] > entry_SYSCALL64_slow_path+0x25/0x25 > [252339.982292] ---[ end trace 03cf2c42f2f658e5 ]--- -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH 0/2] hpsa: fix rmmod issues
> -Original Message- > From: Martin Wilck [mailto:mwi...@suse.de] > Sent: Monday, November 21, 2016 8:04 AM > To: Don Brace > Cc: dl-esc-Team ESD Storage Dev Support; iss_storage...@hp.com; linux- > s...@vger.kernel.org; jbottom...@odin.com; h...@lst.de; h...@suse.de; > Martin Wilck > Subject: [PATCH 0/2] hpsa: fix rmmod issues > > EXTERNAL EMAIL > > > This patch set fixes two issues I encountered when removing the > hpsa modules with rmmod. > > Comments and reviews are welcome. > > Martin Wilck (2): > hpsa: cleanup sas_phy structures in sysfs when unloading > hpsa: destroy sas transport properties before scsi_host > > drivers/scsi/hpsa.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > -- > 2.10.1 I have both patches applied and I still get stack traces. [252338.604903] [ cut here ] [252338.627899] WARNING: CPU: 69 PID: 23977 at fs/sysfs/group.c:237 sysfs_remove_group+0x8e/0x90 [252338.668726] sysfs group 'power' not found for kobject '5:0:0:0' [252338.697526] Modules linked in: hpsa(OE-) scsi_transport_sas(OE) ip6t_rpfilter ip6t_REJECT nf_reject_ipv6 nf_conntrack_ipv6 nf_defrag_ipv6 ipt_REJECT nf_reject_ipv4 nf_conntrack_ipv4 nf_defrag_ipv4 xt_conntrack nf_conntrack cfg80211 rfkill ebtable_nat ebtable_broute bridge stp llc ebtable_filter ebtables ip6table_mangle ip6table_security ip6table_raw ip6table_filter ip6_tables iptable_mangle iptable_security iptable_raw iptable_filter ip_tables osst ch st sb_edac edac_core x86_pkg_temp_thermal coretemp crct10dif_pclmul crc32_pclmul ghash_clmulni_intel aesni_intel lrw iTCO_wdt gf128mul glue_helper iTCO_vendor_support ablk_helper cryptd pcspkr ioatdma lpc_ich hpwdt hpilo mfd_core dca ipmi_si wmi ipmi_msghandler pcc_cpufreq acpi_cpufreq acpi_power_meter uinput mgag200 i2c_algo_bit drm_kms_helper syscopyarea [252339.038528] sysfillrect sysimgblt fb_sys_fops ttm drm crc32c_intel serio_raw tg3 ptp usb_storage i2c_core pps_core dm_mirror dm_region_hash dm_log dm_mod [last unloaded: scsi_transport_sas] [252339.113923] CPU: 69 PID: 23977 Comm: rmmod Tainted: GW OE 4.9.0-rc71+ #24 [252339.151296] Hardware name: HP ProLiant DL580 Gen8, BIOS P79 08/18/2016 [252339.183354] c9000ff1bbf0 815909bd c9000ff1bc40 [252339.219046] c9000ff1bc30 81090901 00ed0246 [252339.255044] 81f71560 88204584dd38 882051e93670 00ae1090 [252339.290927] Call Trace: [252339.303968] [] dump_stack+0x85/0xc8 [252339.329624] [] __warn+0xd1/0xf0 [252339.354037] [] warn_slowpath_fmt+0x5f/0x80 [252339.382084] [] ? mutex_unlock+0xe/0x10 [252339.408515] [] ? kernfs_find_and_get_ns+0x4a/0x60 [252339.439571] [] sysfs_remove_group+0x8e/0x90 [252339.468069] [] dpm_sysfs_remove+0x57/0x60 [252339.495701] [] device_del+0x58/0x270 [252339.521474] [] device_unregister+0x1a/0x60 [252339.549796] [] bsg_unregister_queue+0x60/0xa0 [252339.578999] [] __scsi_remove_device+0xaa/0xd0 [252339.608230] [] scsi_forget_host+0x69/0x70 [252339.635723] [] scsi_remove_host+0x82/0x130 [252339.663738] [] hpsa_remove_one+0x93/0x190 [hpsa] [252339.694960] [] pci_device_remove+0x39/0xc0 [252339.723128] [] __device_release_driver+0x9a/0x150 [252339.753539] [] driver_detach+0xc1/0xd0 [252339.779784] [] bus_remove_driver+0x58/0xd0 [252339.807519] [] driver_unregister+0x2c/0x50 [252339.835948] [] pci_unregister_driver+0x2a/0x80 [252339.865660] [] hpsa_cleanup+0x10/0x7a7 [hpsa] [252339.894682] [] SyS_delete_module+0x1bc/0x220 [252339.924020] [] do_syscall_64+0x6c/0x200 [252339.950862] [] entry_SYSCALL64_slow_path+0x25/0x25 [252339.982292] ---[ end trace 03cf2c42f2f658e5 ]--- -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 0/2] hpsa: fix rmmod issues
This patch set fixes two issues I encountered when removing the hpsa modules with rmmod. Comments and reviews are welcome. Martin Wilck (2): hpsa: cleanup sas_phy structures in sysfs when unloading hpsa: destroy sas transport properties before scsi_host drivers/scsi/hpsa.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.10.1 -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
