Re: [PATCH 00/15] qla2xxx: Add Target Multiqueue support

2017-06-09 Thread Nicholas A. Bellinger
Hi Himanshu & Quinn,

On Wed, 2017-06-07 at 14:43 -0700, Himanshu Madhani wrote:
> Hi Nic,
> 
> This patch series adds support for multiqueue for qla2xxx target mode driver.
> 
> I've also added patch ("qla2xxx: Include Exchange offload/Extended Login
> into FW dump") which was dropped from earlier series for rework.
> 
> Please apply this series to target-pending for inclusion in 4.13 merge window.

Bart's comments in patch #1 are reasonable to consider, but IMHO not a
blocker to initial merge.

That said, as-is this series doesn't apply (see below) to
target-pending/for-next, presumably due to dependencies on what's in
MKP's tree.

So I'm happy to accept a version that does apply.  ;)

Checking patch drivers/scsi/qla2xxx/qla_def.h...
Hunk #1 succeeded at 435 (offset -2 lines).
Hunk #2 succeeded at 3296 (offset -2 lines).
Hunk #3 succeeded at 4260 (offset -6 lines).
Checking patch drivers/scsi/qla2xxx/qla_gbl.h...
Hunk #1 succeeded at 833 (offset -1 lines).
Checking patch drivers/scsi/qla2xxx/qla_inline.h...
Hunk #1 succeeded at 262 (offset 12 lines).
Checking patch drivers/scsi/qla2xxx/qla_isr.c...
Hunk #2 succeeded at 2263 (offset -17 lines).
Hunk #3 succeeded at 2627 (offset -13 lines).
Hunk #4 succeeded at 2650 (offset -13 lines).
Hunk #5 succeeded at 2759 (offset -13 lines).
Checking patch drivers/scsi/qla2xxx/qla_os.c...
Hunk #1 succeeded at 1637 (offset -12 lines).
error: while searching for:
for (cnt = 1; cnt < req->num_outstanding_cmds; cnt++) {
sp = req->outstanding_cmds[cnt];
if (sp) {
/* Don't abort commands in adapter during EEH
 * recovery as it's not accessible/responding.
 */
if (GET_CMD_SP(sp) && !ha->flags.eeh_busy &&
(sp->type == SRB_SCSI_CMD)) {
/* Get a reference to the sp and drop 
the lock.
 * The reference ensures this 
sp->done() call
 * - and not the call in 
qla2xxx_eh_abort() -
 * ends the SCSI command (with result 
'res').
 */
sp_get(sp);

spin_unlock_irqrestore(>hardware_lock, flags);
status = 
qla2xxx_eh_abort(GET_CMD_SP(sp));
spin_lock_irqsave(>hardware_lock, 
flags);
/* Get rid of extra reference if 
immediate exit
 * from ql2xxx_eh_abort */
if (status == FAILED && 
(qla2x00_isp_reg_stat(ha)))
atomic_dec(>ref_count);
}
req->outstanding_cmds[cnt] = NULL;
sp->done(sp, res);
}
}
}

error: patch failed: drivers/scsi/qla2xxx/qla_os.c:1662
error: drivers/scsi/qla2xxx/qla_os.c: patch does not apply
Checking patch drivers/scsi/qla2xxx/qla_target.c...
Hunk #2 succeeded at 2278 (offset -11 lines).
Hunk #3 succeeded at 2317 (offset -11 lines).
Hunk #4 succeeded at 2336 (offset -11 lines).
Hunk #5 succeeded at 2881 (offset -12 lines).
Hunk #6 succeeded at 2987 (offset -12 lines).
Hunk #7 succeeded at 3675 (offset -6 lines).
Hunk #8 succeeded at 3719 (offset -6 lines).
Hunk #9 succeeded at 3754 (offset -6 lines).
Hunk #10 succeeded at 4035 (offset -6 lines).
Hunk #11 succeeded at 6622 (offset 27 lines).
Checking patch drivers/scsi/qla2xxx/qla_target.h...
Hunk #4 succeeded at 865 (offset 1 line).
Hunk #5 succeeded at 1090 (offset 2 lines).



[PATCH 00/15] qla2xxx: Add Target Multiqueue support

2017-06-07 Thread Himanshu Madhani
Hi Nic,

This patch series adds support for multiqueue for qla2xxx target mode driver.

I've also added patch ("qla2xxx: Include Exchange offload/Extended Login
into FW dump") which was dropped from earlier series for rework.

Please apply this series to target-pending for inclusion in 4.13 merge window.

Thanks,
Himanshu
 
Himanshu Madhani (1):
  qla2xxx: Update driver version to 9.01.00.00-k

Quinn Tran (13):
  qla2xxx: Combine Active command arrays.
  qla2xxx: Preparation for Target MQ.
  qla2xxx: Enable Target Multi Queue
  qla2xxx: Add debug knob for user control workload
  qla2xxx: Add fw_started flags to qpair
  qla2xxx: Move fields from qla_hw_data to qla_qpair
  qla2xxx: Use shadow register for ISP27XX
  qla2xxx: Add function call to qpair for door bell
  qla2xxx: Add debug logging routine for qpair
  qla2xxx: Remove unused tgt_enable_64bit_addr flag
  qla2xxx: Remove datasegs_per_cmd and datasegs_per_cont field
  qla2xxx: Move target stat counters from vha to qpair.
  qla2xxx: Include Exchange offload/Extended Login into FW dump

Sawan Chandak (1):
  qla2xxx: Fix mailbox failure while deleting Queue pairs

 drivers/scsi/qla2xxx/qla_attr.c|4 +-
 drivers/scsi/qla2xxx/qla_dbg.c |  150 ++
 drivers/scsi/qla2xxx/qla_dbg.h |   17 +
 drivers/scsi/qla2xxx/qla_def.h |  119 -
 drivers/scsi/qla2xxx/qla_dfs.c |  137 -
 drivers/scsi/qla2xxx/qla_gbl.h |   19 +-
 drivers/scsi/qla2xxx/qla_init.c|   53 +-
 drivers/scsi/qla2xxx/qla_inline.h  |   44 ++
 drivers/scsi/qla2xxx/qla_iocb.c|   32 +-
 drivers/scsi/qla2xxx/qla_isr.c |   95 +++-
 drivers/scsi/qla2xxx/qla_mid.c |   44 +-
 drivers/scsi/qla2xxx/qla_os.c  |  156 --
 drivers/scsi/qla2xxx/qla_target.c  | 1028 +---
 drivers/scsi/qla2xxx/qla_target.h  |   50 +-
 drivers/scsi/qla2xxx/qla_version.h |4 +-
 drivers/scsi/qla2xxx/tcm_qla2xxx.c |8 +-
 16 files changed, 1349 insertions(+), 611 deletions(-)

-- 
2.12.0