[PATCH 04/11] scsi: remove ordered_tag host template field

2014-11-10 Thread Christoph Hellwig 
Signed-off-by: Christoph Hellwig h...@lst.de
Reviewed-by: Bart Van Assche bvanass...@acm.org
Reviewed-by: Martin K. Petersen martin.peter...@oracle.com
Reviewed-by: Hannes Reinecke h...@suse.de
---
 drivers/scsi/hosts.c  |  1 -
 drivers/usb/storage/uas.c |  1 -
 include/scsi/scsi_host.h  | 10 --
 3 files changed, 12 deletions(-)

diff --git a/drivers/scsi/hosts.c b/drivers/scsi/hosts.c
index 06030e1..8bb173e 100644
--- a/drivers/scsi/hosts.c
+++ b/drivers/scsi/hosts.c
@@ -418,7 +418,6 @@ struct Scsi_Host *scsi_host_alloc(struct scsi_host_template 
*sht, int privsize)
shost-cmd_per_lun = sht-cmd_per_lun;
shost-unchecked_isa_dma = sht-unchecked_isa_dma;
shost-use_clustering = sht-use_clustering;
-   shost-ordered_tag = sht-ordered_tag;
shost-no_write_same = sht-no_write_same;
 
if (shost_eh_deadline == -1 || !sht-eh_host_reset_handler)
diff --git a/drivers/usb/storage/uas.c b/drivers/usb/storage/uas.c
index b38bc13..1bc5df4 100644
--- a/drivers/usb/storage/uas.c
+++ b/drivers/usb/storage/uas.c
@@ -817,7 +817,6 @@ static struct scsi_host_template uas_host_template = {
.sg_tablesize = SG_NONE,
.cmd_per_lun = 1,   /* until we override it */
.skip_settle_delay = 1,
-   .ordered_tag = 1,
 
/*
 * The uas drivers expects tags not to be bigger than the maximum
diff --git a/include/scsi/scsi_host.h b/include/scsi/scsi_host.h
index bb9e278..5b03ba9 100644
--- a/include/scsi/scsi_host.h
+++ b/include/scsi/scsi_host.h
@@ -451,11 +451,6 @@ struct scsi_host_template {
 */
unsigned skip_settle_delay:1;
 
-   /*
-* True if we are using ordered write support.
-*/
-   unsigned ordered_tag:1;
-
/* True if the controller does not support WRITE SAME */
unsigned no_write_same:1;
 
@@ -670,11 +665,6 @@ struct Scsi_Host {
 */
unsigned reverse_ordering:1;
 
-   /*
-* Ordered write support
-*/
-   unsigned ordered_tag:1;
-
/* Task mgmt function in progress */
unsigned tmf_in_progress:1;
 
-- 
1.9.1

--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 04/11] scsi: remove ordered_tag host template field

2014-11-06 Thread Bart Van Assche 

On 11/04/14 08:54, Christoph Hellwig wrote:

Signed-off-by: Christoph Hellwig h...@lst.de


Reviewed-by: Bart Van Assche bvanass...@acm.org
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 04/11] scsi: remove ordered_tag host template field

2014-11-04 Thread Hannes Reinecke 
On 11/04/2014 08:54 AM, Christoph Hellwig wrote:
 Signed-off-by: Christoph Hellwig h...@lst.de
 ---
  drivers/scsi/hosts.c  |  1 -
  drivers/usb/storage/uas.c |  1 -
  include/scsi/scsi_host.h  | 10 --
  3 files changed, 12 deletions(-)
 
 diff --git a/drivers/scsi/hosts.c b/drivers/scsi/hosts.c
 index 06030e1..8bb173e 100644
 --- a/drivers/scsi/hosts.c
 +++ b/drivers/scsi/hosts.c
 @@ -418,7 +418,6 @@ struct Scsi_Host *scsi_host_alloc(struct 
 scsi_host_template *sht, int privsize)
   shost-cmd_per_lun = sht-cmd_per_lun;
   shost-unchecked_isa_dma = sht-unchecked_isa_dma;
   shost-use_clustering = sht-use_clustering;
 - shost-ordered_tag = sht-ordered_tag;
   shost-no_write_same = sht-no_write_same;
  
   if (shost_eh_deadline == -1 || !sht-eh_host_reset_handler)
 diff --git a/drivers/usb/storage/uas.c b/drivers/usb/storage/uas.c
 index b38bc13..1bc5df4 100644
 --- a/drivers/usb/storage/uas.c
 +++ b/drivers/usb/storage/uas.c
 @@ -817,7 +817,6 @@ static struct scsi_host_template uas_host_template = {
   .sg_tablesize = SG_NONE,
   .cmd_per_lun = 1,   /* until we override it */
   .skip_settle_delay = 1,
 - .ordered_tag = 1,
  
   /*
* The uas drivers expects tags not to be bigger than the maximum
 diff --git a/include/scsi/scsi_host.h b/include/scsi/scsi_host.h
 index 5e36248..f62143a 100644
 --- a/include/scsi/scsi_host.h
 +++ b/include/scsi/scsi_host.h
 @@ -451,11 +451,6 @@ struct scsi_host_template {
*/
   unsigned skip_settle_delay:1;
  
 - /*
 -  * True if we are using ordered write support.
 -  */
 - unsigned ordered_tag:1;
 -
   /* True if the controller does not support WRITE SAME */
   unsigned no_write_same:1;
  
 @@ -662,11 +657,6 @@ struct Scsi_Host {
*/
   unsigned reverse_ordering:1;
  
 - /*
 -  * Ordered write support
 -  */
 - unsigned ordered_tag:1;
 -
   /* Task mgmt function in progress */
   unsigned tmf_in_progress:1;
  
 
Reviewed-by: Hannes Reinecke h...@suse.de

Cheers,

Hannes
-- 
Dr. Hannes Reinecke   zSeries  Storage
h...@suse.de  +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 21284 (AG Nürnberg)
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 04/11] scsi: remove ordered_tag host template field

2014-11-04 Thread Martin K. Petersen 
 Christoph == Christoph Hellwig h...@lst.de writes:

Description a bit lacking but subject says it all, I guess :)

Reviewed-by: Martin K. Petersen martin.peter...@oracle.com

-- 
Martin K. Petersen  Oracle Linux Engineering
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 04/11] scsi: remove ordered_tag host template field

2014-11-03 Thread Christoph Hellwig 
Signed-off-by: Christoph Hellwig h...@lst.de
---
 drivers/scsi/hosts.c  |  1 -
 drivers/usb/storage/uas.c |  1 -
 include/scsi/scsi_host.h  | 10 --
 3 files changed, 12 deletions(-)

diff --git a/drivers/scsi/hosts.c b/drivers/scsi/hosts.c
index 06030e1..8bb173e 100644
--- a/drivers/scsi/hosts.c
+++ b/drivers/scsi/hosts.c
@@ -418,7 +418,6 @@ struct Scsi_Host *scsi_host_alloc(struct scsi_host_template 
*sht, int privsize)
shost-cmd_per_lun = sht-cmd_per_lun;
shost-unchecked_isa_dma = sht-unchecked_isa_dma;
shost-use_clustering = sht-use_clustering;
-   shost-ordered_tag = sht-ordered_tag;
shost-no_write_same = sht-no_write_same;
 
if (shost_eh_deadline == -1 || !sht-eh_host_reset_handler)
diff --git a/drivers/usb/storage/uas.c b/drivers/usb/storage/uas.c
index b38bc13..1bc5df4 100644
--- a/drivers/usb/storage/uas.c
+++ b/drivers/usb/storage/uas.c
@@ -817,7 +817,6 @@ static struct scsi_host_template uas_host_template = {
.sg_tablesize = SG_NONE,
.cmd_per_lun = 1,   /* until we override it */
.skip_settle_delay = 1,
-   .ordered_tag = 1,
 
/*
 * The uas drivers expects tags not to be bigger than the maximum
diff --git a/include/scsi/scsi_host.h b/include/scsi/scsi_host.h
index 5e36248..f62143a 100644
--- a/include/scsi/scsi_host.h
+++ b/include/scsi/scsi_host.h
@@ -451,11 +451,6 @@ struct scsi_host_template {
 */
unsigned skip_settle_delay:1;
 
-   /*
-* True if we are using ordered write support.
-*/
-   unsigned ordered_tag:1;
-
/* True if the controller does not support WRITE SAME */
unsigned no_write_same:1;
 
@@ -662,11 +657,6 @@ struct Scsi_Host {
 */
unsigned reverse_ordering:1;
 
-   /*
-* Ordered write support
-*/
-   unsigned ordered_tag:1;
-
/* Task mgmt function in progress */
unsigned tmf_in_progress:1;
 
-- 
1.9.1

--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html