RE: [PATCH 04/15] megaraid_sas: Call megasas_complete_cmd_dpc_fusion every 1 second while there are pending commands

2017-07-04 Thread Shivasharan Srikanteshwara 
> -Original Message-
> From: Hannes Reinecke [mailto:h...@suse.de]
> Sent: Friday, June 30, 2017 6:55 PM
> To: Shivasharan S; linux-scsi@vger.kernel.org
> Cc: martin.peter...@oracle.com; the...@redhat.com;
> j...@linux.vnet.ibm.com; kashyap.de...@broadcom.com;
> sumit.sax...@broadcom.com; h...@suse.com; h...@lst.de
> Subject: Re: [PATCH 04/15] megaraid_sas: Call
> megasas_complete_cmd_dpc_fusion every 1 second while there are pending
> commands
>
> On 06/30/2017 10:29 AM, Shivasharan S wrote:
> > Signed-off-by: Kashyap Desai <kashyap.de...@broadcom.com>
> > Signed-off-by: Shivasharan S <shivasharan.srikanteshw...@broadcom.com>
> > ---
> >  drivers/scsi/megaraid/megaraid_sas_fusion.c | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.c
> > b/drivers/scsi/megaraid/megaraid_sas_fusion.c
> > index 5018a3f..0f13c58 100644
> > --- a/drivers/scsi/megaraid/megaraid_sas_fusion.c
> > +++ b/drivers/scsi/megaraid/megaraid_sas_fusion.c
> > @@ -3552,6 +3552,7 @@ int megasas_wait_for_outstanding_fusion(struct
> megasas_instance *instance,
> > }
> > }
> >
> > +   megasas_complete_cmd_dpc_fusion((unsigned long)instance);
> > outstanding = atomic_read(>fw_outstanding);
> > if (!outstanding)
> > goto out;
> > @@ -3560,8 +3561,6 @@ int megasas_wait_for_outstanding_fusion(struct
> megasas_instance *instance,
> > dev_notice(>pdev->dev, "[%2d]waiting for
> %d "
> >"commands to complete for scsi%d\n", i,
> >outstanding, instance->host->host_no);
> > -   megasas_complete_cmd_dpc_fusion(
> > -   (unsigned long)instance);
> > }
> > msleep(1000);
> > }
> >
> Please add a changelog why this is necessary.
>

Sure Hannes. I will update the commit description with the details
and send out v2 of the series.

> Cheers,
>
> Hannes
> --
> Dr. Hannes Reinecke  Teamlead Storage & Networking
> h...@suse.de +49 911 74053 688
> SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
> GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284
> (AG
> Nürnberg)

Re: [PATCH 04/15] megaraid_sas: Call megasas_complete_cmd_dpc_fusion every 1 second while there are pending commands

2017-06-30 Thread Hannes Reinecke 
On 06/30/2017 10:29 AM, Shivasharan S wrote:
> Signed-off-by: Kashyap Desai 
> Signed-off-by: Shivasharan S 
> ---
>  drivers/scsi/megaraid/megaraid_sas_fusion.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.c 
> b/drivers/scsi/megaraid/megaraid_sas_fusion.c
> index 5018a3f..0f13c58 100644
> --- a/drivers/scsi/megaraid/megaraid_sas_fusion.c
> +++ b/drivers/scsi/megaraid/megaraid_sas_fusion.c
> @@ -3552,6 +3552,7 @@ int megasas_wait_for_outstanding_fusion(struct 
> megasas_instance *instance,
>   }
>   }
>  
> + megasas_complete_cmd_dpc_fusion((unsigned long)instance);
>   outstanding = atomic_read(>fw_outstanding);
>   if (!outstanding)
>   goto out;
> @@ -3560,8 +3561,6 @@ int megasas_wait_for_outstanding_fusion(struct 
> megasas_instance *instance,
>   dev_notice(>pdev->dev, "[%2d]waiting for %d "
>  "commands to complete for scsi%d\n", i,
>  outstanding, instance->host->host_no);
> - megasas_complete_cmd_dpc_fusion(
> - (unsigned long)instance);
>   }
>   msleep(1000);
>   }
> 
Please add a changelog why this is necessary.

Cheers,

Hannes
-- 
Dr. Hannes ReineckeTeamlead Storage & Networking
h...@suse.de   +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)

[PATCH 04/15] megaraid_sas: Call megasas_complete_cmd_dpc_fusion every 1 second while there are pending commands

2017-06-30 Thread Shivasharan S 
Signed-off-by: Kashyap Desai 
Signed-off-by: Shivasharan S 
---
 drivers/scsi/megaraid/megaraid_sas_fusion.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.c 
b/drivers/scsi/megaraid/megaraid_sas_fusion.c
index 5018a3f..0f13c58 100644
--- a/drivers/scsi/megaraid/megaraid_sas_fusion.c
+++ b/drivers/scsi/megaraid/megaraid_sas_fusion.c
@@ -3552,6 +3552,7 @@ int megasas_wait_for_outstanding_fusion(struct 
megasas_instance *instance,
}
}
 
+   megasas_complete_cmd_dpc_fusion((unsigned long)instance);
outstanding = atomic_read(>fw_outstanding);
if (!outstanding)
goto out;
@@ -3560,8 +3561,6 @@ int megasas_wait_for_outstanding_fusion(struct 
megasas_instance *instance,
dev_notice(>pdev->dev, "[%2d]waiting for %d "
   "commands to complete for scsi%d\n", i,
   outstanding, instance->host->host_no);
-   megasas_complete_cmd_dpc_fusion(
-   (unsigned long)instance);
}
msleep(1000);
}
-- 
2.8.3