Re: [PATCH 1/3] target: Fix sense data for out-of-bounds IO operations

2013-02-13 Thread Nicholas A. Bellinger 
Hi Roland,

On Fri, 2013-02-08 at 15:18 -0800, Roland Dreier wrote:
 From: Roland Dreier rol...@purestorage.com
 
 We're supposed to return LOGICAL BLOCK ADDRESS OUT OF RANGE, not
 INVALID FIELD IN CDB.
 
 Signed-off-by: Roland Dreier rol...@purestorage.com
 ---

Apologies for the delayed response.  Applied to target-pending/for-next.

Thank you,

--nab

  drivers/target/target_core_sbc.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
 
 diff --git a/drivers/target/target_core_sbc.c 
 b/drivers/target/target_core_sbc.c
 index a664c66..170f1f7 100644
 --- a/drivers/target/target_core_sbc.c
 +++ b/drivers/target/target_core_sbc.c
 @@ -486,7 +486,7 @@ sbc_parse_cdb(struct se_cmd *cmd, struct sbc_ops *ops)
*/
   if (cmd-t_task_lba || sectors) {
   if (sbc_check_valid_sectors(cmd)  0)
 - return TCM_INVALID_CDB_FIELD;
 + return TCM_ADDRESS_OUT_OF_RANGE;
   }
   cmd-execute_cmd = ops-execute_sync_cache;
   break;


--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 1/3] target: Fix sense data for out-of-bounds IO operations

2013-02-08 Thread Roland Dreier 
From: Roland Dreier rol...@purestorage.com

We're supposed to return LOGICAL BLOCK ADDRESS OUT OF RANGE, not
INVALID FIELD IN CDB.

Signed-off-by: Roland Dreier rol...@purestorage.com
---
 drivers/target/target_core_sbc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/target/target_core_sbc.c b/drivers/target/target_core_sbc.c
index a664c66..170f1f7 100644
--- a/drivers/target/target_core_sbc.c
+++ b/drivers/target/target_core_sbc.c
@@ -486,7 +486,7 @@ sbc_parse_cdb(struct se_cmd *cmd, struct sbc_ops *ops)
 */
if (cmd-t_task_lba || sectors) {
if (sbc_check_valid_sectors(cmd)  0)
-   return TCM_INVALID_CDB_FIELD;
+   return TCM_ADDRESS_OUT_OF_RANGE;
}
cmd-execute_cmd = ops-execute_sync_cache;
break;
-- 
1.8.1.2

--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html