Re: [PATCH 1/5] be2iscsi: Fix the sparse warning introduced in previous submission

[Hannes Reinecke]

On 08/08/2014 06:59 AM, Jay Kallickal wrote:

From: Jayamohan Kallickal jayamohan.kallic...@emulex.com

  commit 73af08e11c6638e2abd6b1fa13cdab58c2bbdbf8
  Author: Jayamohan Kallickal jayamohan.kallic...@emulex.com
  Date:   Mon May 5 21:41:26 2014 -0400

   be2iscsi: Fix interrupt Coalescing mechanism.

Signed-off-by: John Soni Jose sony.joh...@emulex.com
Signed-off-by: Jayamohan Kallickal jayamohan.kallic...@emulex.com
---
  drivers/scsi/be2iscsi/be_cmds.h | 14 +++---
  1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/scsi/be2iscsi/be_cmds.h b/drivers/scsi/be2iscsi/be_cmds.h
index cc7405c..4e8cb61 100644
--- a/drivers/scsi/be2iscsi/be_cmds.h
+++ b/drivers/scsi/be2iscsi/be_cmds.h
@@ -26,9 +26,9 @@
   * The commands are serviced by the ARM processor in the OneConnect's MPU.
   */
  struct be_sge {
-   u32 pa_lo;
-   u32 pa_hi;
-   u32 len;
+   __le32 pa_lo;
+   __le32 pa_hi;
+   __le32 len;
  };

  #define MCC_WRB_SGE_CNT_SHIFT 3   /* bits 3 - 7 of dword 0 */
@@ -624,11 +624,11 @@ static inline struct be_sge *nonembedded_sgl(struct 
be_mcc_wrb *wrb)
  / Modify EQ Delay ***/
  struct be_cmd_req_modify_eq_delay {
struct be_cmd_req_hdr hdr;
-   u32 num_eq;
+   __le32 num_eq;
struct {
-   u32 eq_id;
-   u32 phase;
-   u32 delay_multiplier;
+   __le32 eq_id;
+   __le32 phase;
+   __le32 delay_multiplier;
} delay[MAX_CPUS];
  } __packed;



Reviewed-by: Hannes Reinecke h...@suse.de

Cheers,

Hannes
--
Dr. Hannes Reinecke   zSeries  Storage
h...@suse.de  +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/5] be2iscsi: Fix the sparse warning introduced in previous submission

[Christoph Hellwig]

Thanks,

applied the whole series to the drivers-for-3.18 tree.

--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 1/5] be2iscsi: Fix the sparse warning introduced in previous submission

[Jay Kallickal]

From: Jayamohan Kallickal jayamohan.kallic...@emulex.com

 commit 73af08e11c6638e2abd6b1fa13cdab58c2bbdbf8
 Author: Jayamohan Kallickal jayamohan.kallic...@emulex.com
 Date:   Mon May 5 21:41:26 2014 -0400

  be2iscsi: Fix interrupt Coalescing mechanism.

Signed-off-by: John Soni Jose sony.joh...@emulex.com
Signed-off-by: Jayamohan Kallickal jayamohan.kallic...@emulex.com
---
 drivers/scsi/be2iscsi/be_cmds.h | 14 +++---
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/scsi/be2iscsi/be_cmds.h b/drivers/scsi/be2iscsi/be_cmds.h
index cc7405c..4e8cb61 100644
--- a/drivers/scsi/be2iscsi/be_cmds.h
+++ b/drivers/scsi/be2iscsi/be_cmds.h
@@ -26,9 +26,9 @@
  * The commands are serviced by the ARM processor in the OneConnect's MPU.
  */
 struct be_sge {
-   u32 pa_lo;
-   u32 pa_hi;
-   u32 len;
+   __le32 pa_lo;
+   __le32 pa_hi;
+   __le32 len;
 };
 
 #define MCC_WRB_SGE_CNT_SHIFT 3/* bits 3 - 7 of dword 0 */
@@ -624,11 +624,11 @@ static inline struct be_sge *nonembedded_sgl(struct 
be_mcc_wrb *wrb)
 / Modify EQ Delay ***/
 struct be_cmd_req_modify_eq_delay {
struct be_cmd_req_hdr hdr;
-   u32 num_eq;
+   __le32 num_eq;
struct {
-   u32 eq_id;
-   u32 phase;
-   u32 delay_multiplier;
+   __le32 eq_id;
+   __le32 phase;
+   __le32 delay_multiplier;
} delay[MAX_CPUS];
 } __packed;
 
-- 
1.8.5.3

--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html