Re: [PATCH 1/5] ibmvfc: Properly set cancel flags when cancelling abort

[Robert Jennings]

* Brian King (brk...@linux.vnet.ibm.com) wrote:
> 
> The flags on a cancel operation are intended to indicate what,
> if any, TMF will follow the cancel request. This fixes a case
> where we were incorrectly setting the abort task set flag on
> the cancel flag when we were cancelling an abort task set.
> 
> Signed-off-by: Brian King 
Acked-by: Robert Jennings 
> ---
> 
>  drivers/scsi/ibmvscsi/ibmvfc.c |2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff -puN drivers/scsi/ibmvscsi/ibmvfc.c~ibmvfc_abort_cancel_flags 
> drivers/scsi/ibmvscsi/ibmvfc.c
> --- linux-2.6/drivers/scsi/ibmvscsi/ibmvfc.c~ibmvfc_abort_cancel_flags
> 2013-01-22 07:44:23.0 -0600
> +++ linux-2.6-bjking1/drivers/scsi/ibmvscsi/ibmvfc.c  2013-01-22 
> 07:44:56.0 -0600
> @@ -2327,7 +2327,7 @@ static int ibmvfc_abort_task_set(struct
>   timeout = wait_for_completion_timeout(&evt->comp, timeout);
> 
>   if (!timeout) {
> - rc = ibmvfc_cancel_all(sdev, IBMVFC_TMF_ABORT_TASK_SET);
> + rc = ibmvfc_cancel_all(sdev, 0);
>   if (!rc) {
>   rc = ibmvfc_wait_for_ops(vhost, sdev->hostdata, 
> ibmvfc_match_key);
>   if (rc == SUCCESS)
> _

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 1/5] ibmvfc: Properly set cancel flags when cancelling abort

[Brian King]

The flags on a cancel operation are intended to indicate what,
if any, TMF will follow the cancel request. This fixes a case
where we were incorrectly setting the abort task set flag on
the cancel flag when we were cancelling an abort task set.

Signed-off-by: Brian King 
---

 drivers/scsi/ibmvscsi/ibmvfc.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff -puN drivers/scsi/ibmvscsi/ibmvfc.c~ibmvfc_abort_cancel_flags 
drivers/scsi/ibmvscsi/ibmvfc.c
--- linux-2.6/drivers/scsi/ibmvscsi/ibmvfc.c~ibmvfc_abort_cancel_flags  
2013-01-22 07:44:23.0 -0600
+++ linux-2.6-bjking1/drivers/scsi/ibmvscsi/ibmvfc.c2013-01-22 
07:44:56.0 -0600
@@ -2327,7 +2327,7 @@ static int ibmvfc_abort_task_set(struct
timeout = wait_for_completion_timeout(&evt->comp, timeout);
 
if (!timeout) {
-   rc = ibmvfc_cancel_all(sdev, IBMVFC_TMF_ABORT_TASK_SET);
+   rc = ibmvfc_cancel_all(sdev, 0);
if (!rc) {
rc = ibmvfc_wait_for_ops(vhost, sdev->hostdata, 
ibmvfc_match_key);
if (rc == SUCCESS)
_

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html