Re: [PATCH 10/47] ips: Do not try to abort command from host reset

2017-06-28 Thread Johannes Thumshirn

Reviewed-by: Johannes Thumshirn 
-- 
Johannes Thumshirn  Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850


[PATCH 10/47] ips: Do not try to abort command from host reset

2017-06-28 Thread Hannes Reinecke
The code for aborting an outstanding command is a copy of the
functionality from command abort. As we already have called this
function once we reach host reset there's no point in trying to
do so again.

Signed-off-by: Hannes Reinecke 
---
 drivers/scsi/ips.c | 17 -
 1 file changed, 17 deletions(-)

diff --git a/drivers/scsi/ips.c b/drivers/scsi/ips.c
index 3419e1b..97d9cca 100644
--- a/drivers/scsi/ips.c
+++ b/drivers/scsi/ips.c
@@ -865,23 +865,6 @@ static int __ips_eh_reset(struct scsi_cmnd *SC)
if (!ha->active)
return (FAILED);
 
-   /* See if the command is on the copp queue */
-   item = ha->copp_waitlist.head;
-   while ((item) && (item->scsi_cmd != SC))
-   item = item->next;
-
-   if (item) {
-   /* Found it */
-   ips_removeq_copp(>copp_waitlist, item);
-   return (SUCCESS);
-   }
-
-   /* See if the command is on the wait queue */
-   if (ips_removeq_wait(>scb_waitlist, SC)) {
-   /* command not sent yet */
-   return (SUCCESS);
-   }
-
/* An explanation for the casual observer:  
*/
/* Part of the function of a RAID controller is automatic error 
*/
/* detection and recovery.  As such, the only problem that physically   
*/
-- 
1.8.5.6