Re: [PATCH 2/3] scsi: be2iscsi: Add warnings for unsupported adapters

[Johannes Thumshirn]

On Thu, Jun 07, 2018 at 01:54:42PM +0530, Jitendra Bhivare wrote:
> From: Ketan Mukadam 
> 
> Add a warning message to indicate obsolete/unsupported
> BE3 Adapter Family devices.

Ahm no. The upstream Linux kernel doesn't deprecate specific hardware.

-- 
Johannes Thumshirn  Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850

[PATCH 2/3] scsi: be2iscsi: Add warnings for unsupported adapters

[Jitendra Bhivare]

From: Ketan Mukadam 

Add a warning message to indicate obsolete/unsupported
BE3 Adapter Family devices.

Signed-off-by: Ketan Mukadam 
Reviewed-by: Jitendra Bhivare 
---
 drivers/scsi/be2iscsi/be_main.c | 2 ++
 drivers/scsi/be2iscsi/be_mgmt.c | 3 ++-
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/scsi/be2iscsi/be_main.c b/drivers/scsi/be2iscsi/be_main.c
index b3cfdd5..2b4f524 100644
--- a/drivers/scsi/be2iscsi/be_main.c
+++ b/drivers/scsi/be2iscsi/be_main.c
@@ -5583,6 +5583,8 @@ static int beiscsi_dev_probe(struct pci_dev *pcidev,
case OC_DEVICE_ID3:
phba->generation = BE_GEN3;
phba->iotask_fn = beiscsi_iotask;
+   dev_warn(>dev,
+"Obsolete/Unsupported BE3 Adapter Family\n");
break;
case OC_SKH_ID1:
phba->generation = BE_GEN4;
diff --git a/drivers/scsi/be2iscsi/be_mgmt.c b/drivers/scsi/be2iscsi/be_mgmt.c
index 66ca967..dff6cdf 100644
--- a/drivers/scsi/be2iscsi/be_mgmt.c
+++ b/drivers/scsi/be2iscsi/be_mgmt.c
@@ -1233,7 +1233,8 @@ beiscsi_adap_family_disp(struct device *dev, struct 
device_attribute *attr,
break;
case BE_DEVICE_ID2:
case OC_DEVICE_ID3:
-   return snprintf(buf, PAGE_SIZE, "BE3-R Adapter Family\n");
+   return snprintf(buf, PAGE_SIZE,
+   "Obsolete/Unsupported BE3-R Adapter Family\n");
break;
case OC_SKH_ID1:
return snprintf(buf, PAGE_SIZE, "Skyhawk-R Adapter Family\n");
-- 
2.7.4