Re: [PATCH 27/28] eata: remove 'arg_done' from eata2x_eh_host_reset()

[Christoph Hellwig]

Looks fine,

Reviewed-by: Christoph Hellwig 

Re: [PATCH 27/28] eata: remove 'arg_done' from eata2x_eh_host_reset()

[Johannes Thumshirn]

Reviewed-by: Johannes Thumshirn 
-- 
Johannes Thumshirn  Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850

[PATCH 27/28] eata: remove 'arg_done' from eata2x_eh_host_reset()

[Hannes Reinecke]

Just displaying some different information; drop it.

Signed-off-by: Hannes Reinecke 
---
 drivers/scsi/eata.c | 9 +
 1 file changed, 1 insertion(+), 8 deletions(-)

diff --git a/drivers/scsi/eata.c b/drivers/scsi/eata.c
index 227dd2c..6501c33 100644
--- a/drivers/scsi/eata.c
+++ b/drivers/scsi/eata.c
@@ -1899,7 +1899,6 @@ static int eata2x_eh_abort(struct scsi_cmnd *SCarg)
 static int eata2x_eh_host_reset(struct scsi_cmnd *SCarg)
 {
unsigned int i, time, k, c, limit = 0;
-   int arg_done = 0;
struct scsi_cmnd *SCpnt;
struct Scsi_Host *shost = SCarg->device->host;
struct hostdata *ha = (struct hostdata *)shost->hostdata;
@@ -1967,9 +1966,6 @@ static int eata2x_eh_host_reset(struct scsi_cmnd *SCarg)
if (SCpnt->scsi_done == NULL)
panic("%s: reset, mbox %d, SCpnt->scsi_done == NULL.\n",
  ha->board_name, i);
-
-   if (SCpnt == SCarg)
-   arg_done = 1;
}
 
if (do_dma(shost->io_port, 0, RESET_PIO)) {
@@ -2037,10 +2033,7 @@ static int eata2x_eh_host_reset(struct scsi_cmnd *SCarg)
ha->in_reset = 0;
do_trace = 0;
 
-   if (arg_done)
-   printk("%s: reset, exit, done.\n", ha->board_name);
-   else
-   printk("%s: reset, exit.\n", ha->board_name);
+   printk("%s: reset, exit.\n", ha->board_name);
 
spin_unlock_irq(shost->host_lock);
return SUCCESS;
-- 
1.8.5.6