Re: [PATCH 3/6] scsi: lpfc: Cocci spatch "pool_zalloc-simple"

2017-09-25 Thread Martin K. Petersen 

Thomas,

> Use *_pool_zalloc rather than *_pool_alloc followed by memset with 0.
> Found by coccinelle spatch "api/alloc/pool_zalloc-simple.cocci"

Applied to 4.15/scsi-queue. Thank you!

-- 
Martin K. Petersen  Oracle Linux Engineering

Re: [PATCH 3/6] scsi: lpfc: Cocci spatch "pool_zalloc-simple"

2017-09-22 Thread James Smart 

On 9/20/2017 11:15 PM, Thomas Meyer wrote:

Use *_pool_zalloc rather than *_pool_alloc followed by memset with 0.
Found by coccinelle spatch "api/alloc/pool_zalloc-simple.cocci"

Signed-off-by: Thomas Meyer 
---




Looks good. Thanks.

Signed-off-by: James Smart

[PATCH 3/6] scsi: lpfc: Cocci spatch "pool_zalloc-simple"

2017-09-21 Thread Thomas Meyer 
Use *_pool_zalloc rather than *_pool_alloc followed by memset with 0.
Found by coccinelle spatch "api/alloc/pool_zalloc-simple.cocci"

Signed-off-by: Thomas Meyer 
---

diff -u -p a/drivers/scsi/lpfc/lpfc_nvme.c b/drivers/scsi/lpfc/lpfc_nvme.c
--- a/drivers/scsi/lpfc/lpfc_nvme.c
+++ b/drivers/scsi/lpfc/lpfc_nvme.c
@@ -1938,14 +1938,13 @@ lpfc_new_nvme_buf(struct lpfc_vport *vpo
 * pci bus space for an I/O. The DMA buffer includes the
 * number of SGE's necessary to support the sg_tablesize.
 */
-   lpfc_ncmd->data = dma_pool_alloc(phba->lpfc_sg_dma_buf_pool,
-GFP_KERNEL,
-_ncmd->dma_handle);
+   lpfc_ncmd->data = dma_pool_zalloc(phba->lpfc_sg_dma_buf_pool,
+ GFP_KERNEL,
+ _ncmd->dma_handle);
if (!lpfc_ncmd->data) {
kfree(lpfc_ncmd);
break;
}
-   memset(lpfc_ncmd->data, 0, phba->cfg_sg_dma_buf_size);
 
lxri = lpfc_sli4_next_xritag(phba);
if (lxri == NO_XRI) {