[PATCH 3] scsi: fix build errors, SCSI_FC_ATTRS needs to depend on SCSI NET
From: Randy Dunlap rdun...@infradead.org Fix build errors when CONFIG_SCSI_NETLINK is enabled but CONFIG_NET is not enabled: drivers/built-in.o: In function `scsi_nl_rcv_msg': scsi_netlink.c:(.text+0x1850fa): undefined reference to `netlink_ack' scsi_netlink.c:(.text+0x185105): undefined reference to `skb_pull' scsi_netlink.c:(.text+0x18515d): undefined reference to `netlink_capable' drivers/built-in.o: In function `scsi_netlink_init': (.text+0x185244): undefined reference to `init_net' drivers/built-in.o: In function `scsi_netlink_init': (.text+0x185258): undefined reference to `__netlink_kernel_create' drivers/built-in.o: In function `scsi_netlink_exit': (.text+0x185291): undefined reference to `netlink_kernel_release' Signed-off-by: Randy Dunlap rdun...@infradead.org --- drivers/scsi/Kconfig |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Based on Anish's previous SCSI_NETLINK patch. Sorry about missing this one. --- lnx-317-rc5.orig/drivers/scsi/Kconfig +++ lnx-317-rc5/drivers/scsi/Kconfig @@ -257,7 +257,7 @@ config SCSI_SPI_ATTRS config SCSI_FC_ATTRS tristate FiberChannel Transport Attributes - depends on SCSI + depends on SCSI NET select SCSI_NETLINK help If you wish to export transport-specific information about -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH 3] scsi: fix build errors, SCSI_FC_ATTRS needs to depend on SCSI NET
From : Randy Dunlap [rdun...@infradead.org] Sent: Monday, September 15, 2014 5:20 PM To: Anish Bhatt; net...@vger.kernel.org; jbottom...@parallels.com; David Miller Cc: linux-scsi@vger.kernel.org; mc...@broadcom.com; eddie@broadcom.com; jim.ep...@gmail.com Subject: [PATCH 3] scsi: fix build errors, SCSI_FC_ATTRS needs to depend on SCSI NET From: Randy Dunlap rdun...@infradead.org Fix build errors when CONFIG_SCSI_NETLINK is enabled but CONFIG_NET is not enabled: drivers/built-in.o: In function `scsi_nl_rcv_msg': scsi_netlink.c:(.text+0x1850fa): undefined reference to `netlink_ack' scsi_netlink.c:(.text+0x185105): undefined reference to `skb_pull' scsi_netlink.c:(.text+0x18515d): undefined reference to `netlink_capable' drivers/built-in.o: In function `scsi_netlink_init': (.text+0x185244): undefined reference to `init_net' drivers/built-in.o: In function `scsi_netlink_init': (.text+0x185258): undefined reference to `__netlink_kernel_create' drivers/built-in.o: In function `scsi_netlink_exit': (.text+0x185291): undefined reference to `netlink_kernel_release' Signed-off-by: Randy Dunlap rdun...@infradead.org Doesn't fix make warnings, but SCSI_FC_ATTRS can no longer be selected without NET. Though both ia64 and powerpc emit a lot of unmet dependency warnings as is on defconfig Tested-by: Anish Bhatt an...@chelsio.com --- drivers/scsi/Kconfig |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Based on Anish's previous SCSI_NETLINK patch. Sorry about missing this one. --- lnx-317-rc5.orig/drivers/scsi/Kconfig +++ lnx-317-rc5/drivers/scsi/Kconfig @@ -257,7 +257,7 @@ config SCSI_SPI_ATTRS config SCSI_FC_ATTRS tristate FiberChannel Transport Attributes - depends on SCSI + depends on SCSI NET select SCSI_NETLINK help If you wish to export transport-specific information about -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 3] scsi: fix build errors, SCSI_FC_ATTRS needs to depend on SCSI NET
On 09/15/14 20:00, Anish Bhatt wrote: Doesn't fix make warnings, but SCSI_FC_ATTRS can no longer be selected without NET. Though both ia64 and powerpc emit a lot of unmet dependency warnings as is on defconfig You mean these kconfig warnings? quote After merging the net tree, today's linux-next build (powerpc ppc64_defconfig) failed like this: warning: (PPC_CELL_NATIVE BLUESTONE CANYONLANDS GLACIER EIGER 440EPX 440GRX 440GX 460SX 405EX) selects IBM_EMAC_RGMII which has unmet direct dependencies (NETDEVICES ETHERNET NET_VENDOR_IBM) warning: (PPC_CELL_NATIVE CANYONLANDS GLACIER 440EP 440EPX 440GRX 440GP 440GX 460SX 405GP) selects IBM_EMAC_ZMII which has unmet direct dependencies (NETDEVICES ETHERNET NET_VENDOR_IBM) warning: (PPC_CELL_NATIVE 440GX 460EX 460SX APM821xx) selects IBM_EMAC_TAH which has unmet direct dependencies (NETDEVICES ETHERNET NET_VENDOR_IBM) warning: (PPC_CELL_NATIVE AKEBONO 440EPX 440GRX 440GX 440SPe 460EX 460SX APM821xx 405EX) selects IBM_EMAC_EMAC4 which has unmet direct dependencies (NETDEVICES ETHERNET NET_VENDOR_IBM) warning: (PPC_CELL_NATIVE CANYONLANDS GLACIER 440EP 440EPX 440GRX 440GP 440GX 460SX 405GP) selects IBM_EMAC_ZMII which has unmet direct dependencies (NETDEVICES ETHERNET NET_VENDOR_IBM) warning: (PPC_CELL_NATIVE BLUESTONE CANYONLANDS GLACIER EIGER 440EPX 440GRX 440GX 460SX 405EX) selects IBM_EMAC_RGMII which has unmet direct dependencies (NETDEVICES ETHERNET NET_VENDOR_IBM) warning: (PPC_CELL_NATIVE 440GX 460EX 460SX APM821xx) selects IBM_EMAC_TAH which has unmet direct dependencies (NETDEVICES ETHERNET NET_VENDOR_IBM) warning: (PPC_CELL_NATIVE AKEBONO 440EPX 440GRX 440GX 440SPe 460EX 460SX APM821xx 405EX) selects IBM_EMAC_EMAC4 which has unmet direct dependencies (NETDEVICES ETHERNET NET_VENDOR_IBM) /quote I'll look into those. -- ~Randy -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 3] scsi: fix build errors, SCSI_FC_ATTRS needs to depend on SCSI NET
From: Randy Dunlap rdun...@infradead.org Date: Mon, 15 Sep 2014 17:20:42 -0700 From: Randy Dunlap rdun...@infradead.org Fix build errors when CONFIG_SCSI_NETLINK is enabled but CONFIG_NET is not enabled: ... Signed-off-by: Randy Dunlap rdun...@infradead.org Applied, thanks a lot Randy. -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH 3] scsi: fix build errors, SCSI_FC_ATTRS needs to depend on SCSI NET
From: Randy Dunlap [rdun...@infradead.org] Sent: Monday, September 15, 2014 8:17 PM To: Anish Bhatt; net...@vger.kernel.org; jbottom...@parallels.com; David Miller Cc: linux-scsi@vger.kernel.org; mc...@broadcom.com; eddie@broadcom.com; jim.ep...@gmail.com Subject: Re: [PATCH 3] scsi: fix build errors, SCSI_FC_ATTRS needs to depend on SCSI NET On 09/15/14 20:00, Anish Bhatt wrote: Doesn't fix make warnings, but SCSI_FC_ATTRS can no longer be selected without NET. Though both ia64 and powerpc emit a lot of unmet dependency warnings as is on defconfig You mean these kconfig warnings? [] I'll look into those. -- ~Randy Yes, thanks -Anish -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
