RE: [PATCH RESEND] bfa: deinline __bfa_trc() and __bfa_trc32()

[Anil Gurumurthy]

You could remove the __bfa_trc32() routine

Thanks,
Acked-by: Anil Gurumurthy <anil.gurumur...@qlogic.com>

-Original Message-
From: Martin K. Petersen [mailto:martin.peter...@oracle.com] 
Sent: 10 February 2016 22:59
To: Denys Vlasenko <dvlas...@redhat.com>
Cc: James Bottomley <jbottom...@parallels.com>; Fabian Frederick 
<f...@skynet.be>; Anil Gurumurthy <anil.gurumur...@qlogic.com>; Christoph 
Hellwig <h...@lst.de>; Guenter Roeck <li...@roeck-us.net>; Ben Hutchings 
<b...@decadent.org.uk>; linux-kernel <linux-ker...@vger.kernel.org>; linux-scsi 
<linux-scsi@vger.kernel.org>
Subject: Re: [PATCH RESEND] bfa: deinline __bfa_trc() and __bfa_trc32()

>>>>> "Denys" == Denys Vlasenko <dvlas...@redhat.com> writes:

Denys> __bfa_trc32() is very similar, so it is uninlined too.  However, 
Denys> it appears to be unused, therefore this patch ifdefs it out.

Why don't we just drop it?

-- 
Martin K. Petersen  Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH RESEND] bfa: deinline __bfa_trc() and __bfa_trc32()

[Martin K. Petersen]

> "Denys" == Denys Vlasenko  writes:

Denys> __bfa_trc() compiles to 115 bytes of machine code.  With this
Denys> .config: http://busybox.net/~vda/kernel_config there are 1494
Denys> calls of __bfa_trc().

Applied to 4.6/scsi-queue.

-- 
Martin K. Petersen  Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH RESEND] bfa: deinline __bfa_trc() and __bfa_trc32()

[Martin K. Petersen]

> "Denys" == Denys Vlasenko  writes:

Denys> __bfa_trc32() is very similar, so it is uninlined too.  However,
Denys> it appears to be unused, therefore this patch ifdefs it out.

Why don't we just drop it?

-- 
Martin K. Petersen  Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH RESEND] bfa: deinline __bfa_trc() and __bfa_trc32()

[Denys Vlasenko]

__bfa_trc() compiles to 115 bytes of machine code.
With this .config: http://busybox.net/~vda/kernel_config
there are 1494 calls of __bfa_trc().

__bfa_trc32() is very similar, so it is uninlined too.
However, it appears to be unused, therefore this patch
ifdefs it out.

Change in code size is about 130,000 bytes:

text data  bss   dec hex filename
85975426 22294712 20627456 128897594 7aed23a vmlinux.before
85842882 22294584 20627456 128764922 7accbfa vmlinux

Signed-off-by: Denys Vlasenko 
Acked-by: Anil Gurumurthy 
CC: Fabian Frederick 
CC: Anil Gurumurthy 
CC: Christoph Hellwig 
CC: Guenter Roeck 
CC: Ben Hutchings 
CC: James Bottomley 
CC: linux-ker...@vger.kernel.org
CC: linux-scsi@vger.kernel.org
---
 drivers/scsi/bfa/bfa_core.c | 40 
 drivers/scsi/bfa/bfa_cs.h   | 41 -
 2 files changed, 44 insertions(+), 37 deletions(-)

diff --git a/drivers/scsi/bfa/bfa_core.c b/drivers/scsi/bfa/bfa_core.c
index e3f67b0..3657a00 100644
--- a/drivers/scsi/bfa/bfa_core.c
+++ b/drivers/scsi/bfa/bfa_core.c
@@ -90,6 +90,46 @@ static bfa_ioc_mbox_mcfunc_t  bfa_mbox_isrs[BFI_MC_MAX] = {
 
 
 
+void
+__bfa_trc(struct bfa_trc_mod_s *trcm, int fileno, int line, u64 data)
+{
+   int tail = trcm->tail;
+   struct bfa_trc_s*trc = >trc[tail];
+
+   if (trcm->stopped)
+   return;
+
+   trc->fileno = (u16) fileno;
+   trc->line = (u16) line;
+   trc->data.u64 = data;
+   trc->timestamp = BFA_TRC_TS(trcm);
+
+   trcm->tail = (trcm->tail + 1) & (BFA_TRC_MAX - 1);
+   if (trcm->tail == trcm->head)
+   trcm->head = (trcm->head + 1) & (BFA_TRC_MAX - 1);
+}
+
+#if 0 /* UNUSED */
+void
+__bfa_trc32(struct bfa_trc_mod_s *trcm, int fileno, int line, u32 data)
+{
+   int tail = trcm->tail;
+   struct bfa_trc_s *trc = >trc[tail];
+
+   if (trcm->stopped)
+   return;
+
+   trc->fileno = (u16) fileno;
+   trc->line = (u16) line;
+   trc->data.u32.u32 = data;
+   trc->timestamp = BFA_TRC_TS(trcm);
+
+   trcm->tail = (trcm->tail + 1) & (BFA_TRC_MAX - 1);
+   if (trcm->tail == trcm->head)
+   trcm->head = (trcm->head + 1) & (BFA_TRC_MAX - 1);
+}
+#endif
+
 static void
 bfa_com_port_attach(struct bfa_s *bfa)
 {
diff --git a/drivers/scsi/bfa/bfa_cs.h b/drivers/scsi/bfa/bfa_cs.h
index 91a8aa3..dd3154e 100644
--- a/drivers/scsi/bfa/bfa_cs.h
+++ b/drivers/scsi/bfa/bfa_cs.h
@@ -107,44 +107,11 @@ bfa_trc_stop(struct bfa_trc_mod_s *trcm)
trcm->stopped = 1;
 }
 
-static inline void
-__bfa_trc(struct bfa_trc_mod_s *trcm, int fileno, int line, u64 data)
-{
-   int tail = trcm->tail;
-   struct bfa_trc_s*trc = >trc[tail];
-
-   if (trcm->stopped)
-   return;
-
-   trc->fileno = (u16) fileno;
-   trc->line = (u16) line;
-   trc->data.u64 = data;
-   trc->timestamp = BFA_TRC_TS(trcm);
-
-   trcm->tail = (trcm->tail + 1) & (BFA_TRC_MAX - 1);
-   if (trcm->tail == trcm->head)
-   trcm->head = (trcm->head + 1) & (BFA_TRC_MAX - 1);
-}
-
+void
+__bfa_trc(struct bfa_trc_mod_s *trcm, int fileno, int line, u64 data);
 
-static inline void
-__bfa_trc32(struct bfa_trc_mod_s *trcm, int fileno, int line, u32 data)
-{
-   int tail = trcm->tail;
-   struct bfa_trc_s *trc = >trc[tail];
-
-   if (trcm->stopped)
-   return;
-
-   trc->fileno = (u16) fileno;
-   trc->line = (u16) line;
-   trc->data.u32.u32 = data;
-   trc->timestamp = BFA_TRC_TS(trcm);
-
-   trcm->tail = (trcm->tail + 1) & (BFA_TRC_MAX - 1);
-   if (trcm->tail == trcm->head)
-   trcm->head = (trcm->head + 1) & (BFA_TRC_MAX - 1);
-}
+void
+__bfa_trc32(struct bfa_trc_mod_s *trcm, int fileno, int line, u32 data);
 
 #define bfa_sm_fault(__mod, __event)   do {\
bfa_trc(__mod, (((u32)0xDEAD << 16) | __event));\
-- 
1.8.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html