Re: [PATCH RESEND 0/5] Add vhost-blk support

2012-07-18 Thread Stefan Hajnoczi
On Tue, Jul 17, 2012 at 4:09 PM, Michael S. Tsirkin m...@redhat.com wrote:
 On Fri, Jul 13, 2012 at 04:55:06PM +0800, Asias He wrote:

 Hi folks,

 [I am resending to fix the broken thread in the previous one.]

 This patchset adds vhost-blk support. vhost-blk is a in kernel virito-blk
 device accelerator. Compared to userspace virtio-blk implementation, 
 vhost-blk
 gives about 5% to 15% performance improvement.

 Same thing as tcm_host comment:

 It seems not 100% clear whether this driver will have major
 userspace using it. And if not, it would be very hard to support a
 driver when recent userspace does not use it in the end.

 I think a good idea for 3.6 would be to make it depend on
 CONFIG_STAGING.  Then we don't commit to an ABI.  For this, you can 
 add
 a separate Kconfig and source it from drivers/staging/Kconfig.  Maybe 
 it
 needs to be in a separate directory drivers/vhost/staging/Kconfig.

 I Cc'd the list of tcm_host in the hope that you can cooperate on this.


Adding it to staging allows more people to try it out, so that's a
good thing.  If I get a moment to play with it I'll let you know the
results.

Stefan
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH RESEND 0/5] Add vhost-blk support

2012-07-17 Thread Michael S. Tsirkin
On Fri, Jul 13, 2012 at 04:55:06PM +0800, Asias He wrote:
 
 Hi folks,
 
 [I am resending to fix the broken thread in the previous one.]
 
 This patchset adds vhost-blk support. vhost-blk is a in kernel virito-blk
 device accelerator. Compared to userspace virtio-blk implementation, vhost-blk
 gives about 5% to 15% performance improvement.

Same thing as tcm_host comment:

It seems not 100% clear whether this driver will have major
userspace using it. And if not, it would be very hard to support a
driver when recent userspace does not use it in the end.

I think a good idea for 3.6 would be to make it depend on
CONFIG_STAGING.  Then we don't commit to an ABI.  For this, you can add
a separate Kconfig and source it from drivers/staging/Kconfig.  Maybe it
needs to be in a separate directory drivers/vhost/staging/Kconfig.

I Cc'd the list of tcm_host in the hope that you can cooperate on this.

-- 
MST
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html