Re: [PATCH V4 0/2] smartpqi: initial commit of Microsemi smartpqi driver

[Martin K. Petersen]

> "Don" == Don Brace  writes:

Don,

Don> I am thinking that you mean users will need to have some kind of
Don> notification that newer kernels will require that the smartpqi
Don> driver be configured, especially if they are already booting from
Don> the aacraid driver.

One issue is Kconfig. You need to make sure that make oldconfig will
pull in smartpqi if aacraid was previously selected.

The other issue is that the initrd needs to include the smartpqi
module. Hopefully dracut will handle this correctly now. But please test
that it is working correctly when transitioning from an old kernel with
aacraid to a new kernel with smartpqi.

-- 
Martin K. Petersen  Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH V4 0/2] smartpqi: initial commit of Microsemi smartpqi driver

[Don Brace]

> -Original Message-
> From: Martin K. Petersen [mailto:martin.peter...@oracle.com]
> Sent: Friday, August 12, 2016 3:10 PM
> To: Don Brace
> Cc: Martin K. Petersen; j...@linux.vnet.ibm.com; Viswas G; Mahesh
> Rajashekhara; h...@infradead.org; Scott Teel; Kevin Barnett; Justin Lindley;
> Scott Benesh; elli...@hpe.com; linux-scsi@vger.kernel.org
> Subject: Re: [PATCH V4 0/2] smartpqi: initial commit of Microsemi smartpqi
> driver
> 
> EXTERNAL EMAIL
> 
> 
> >>>>> "Don" == Don Brace <don.br...@microsemi.com> writes:
> 
> Don> Great. So we are good to go?
> 
> I applied the driver to 4.9/scsi-queue. You'll need to come up with a
> migration approach for patch 2.
> 
> --
> Martin K. Petersen  Oracle Linux Engineering

I am thinking that you mean users will need to have some kind of notification 
that newer kernels will require that the smartpqi driver be configured, 
especially if they are already booting from the aacraid driver.


Can I submit a smartpqi/Kconfig patch to change the default value to 'y' and 
add you as a Suggested-by?

We will of course need some documentation as you suggested.

Thanks,
Don Brace
ESC - Smart Storage
Microsemi Corporation



--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH V4 0/2] smartpqi: initial commit of Microsemi smartpqi driver

[Martin K. Petersen]

> "Don" == Don Brace  writes:

Don> Great. So we are good to go?

I applied the driver to 4.9/scsi-queue. You'll need to come up with a
migration approach for patch 2.

-- 
Martin K. Petersen  Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH V4 0/2] smartpqi: initial commit of Microsemi smartpqi driver

[Don Brace]

> -Original Message-
> From: Martin K. Petersen [mailto:martin.peter...@oracle.com]
> Sent: Wednesday, August 10, 2016 9:26 PM
> To: Don Brace
> Cc: Martin K. Petersen; j...@linux.vnet.ibm.com; Viswas G; Mahesh
> Rajashekhara; h...@infradead.org; Scott Teel; Kevin Barnett; Justin Lindley;
> Scott Benesh; elli...@hpe.com; linux-scsi@vger.kernel.org
> Subject: Re: [PATCH V4 0/2] smartpqi: initial commit of Microsemi smartpqi
> driver
> 
> EXTERNAL EMAIL
> 
> 
> >>>>> "Don" == Don Brace <don.br...@microsemi.com> writes:
> 
> Don,
> 
> >> OK. I was just wondering whether it would make sense to have a libpqi
> >> with all the spec-compliant pieces and put the "smart" in a dedicated
> >> Microsemi driver.
> 
> Don> We would prefer not to do this at this time. We do not know of any
> Don> other PQI drivers that could take advantage of a PQI library.
> Don> However we may end up doing this in the future.
> 
> I understand. But we have been badly burned every single time we
> accepted code on the premise that it would get reworked later.
> 
> That said, I haven't seen much interest in T10 PQI outside of the
> HP/PMC/MS nexus so it's probably not too likely that another driver
> would come along.
> 
> --
> Martin K. Petersen  Oracle Linux Engineering

Great. So we are good to go?

Thanks,
Don Brace
ESC - Smart Storage
Microsemi Corporation



--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH V4 0/2] smartpqi: initial commit of Microsemi smartpqi driver

[Martin K. Petersen]

> "Don" == Don Brace  writes:

Don,

>> OK. I was just wondering whether it would make sense to have a libpqi
>> with all the spec-compliant pieces and put the "smart" in a dedicated
>> Microsemi driver.

Don> We would prefer not to do this at this time. We do not know of any
Don> other PQI drivers that could take advantage of a PQI library.
Don> However we may end up doing this in the future.

I understand. But we have been badly burned every single time we
accepted code on the premise that it would get reworked later. 

That said, I haven't seen much interest in T10 PQI outside of the
HP/PMC/MS nexus so it's probably not too likely that another driver
would come along.

-- 
Martin K. Petersen  Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH V4 0/2] smartpqi: initial commit of Microsemi smartpqi driver

[Don Brace]

> -Original Message-
> From: Martin K. Petersen [mailto:martin.peter...@oracle.com]
> Sent: Monday, August 08, 2016 8:05 PM
> To: Don Brace
> Cc: Martin K. Petersen; j...@linux.vnet.ibm.com; Viswas G; Mahesh
> Rajashekhara; h...@infradead.org; Scott Teel; Kevin Barnett; Justin Lindley;
> Scott Benesh; elli...@hpe.com; linux-scsi@vger.kernel.org
> Subject: Re: [PATCH V4 0/2] smartpqi: initial commit of Microsemi smartpqi
> driver
> 
> EXTERNAL EMAIL
> 
> 
> >>>>> "Don" == Don Brace <don.br...@microsemi.com> writes:
> 
> >> Is your interface related to T10 PQI?
> 
> Don> We follow it pretty closely with some exceptions: - Our memory BARS
> Don> includes both the aacraid SIS and PQI interfaces - We have our own
> Don> config table defined.  - We are using our own error data buffer
> Don> schema - We are not yet supporting fencing and some other features.
> 
> OK. I was just wondering whether it would make sense to have a libpqi
> with all the spec-compliant pieces and put the "smart" in a dedicated
> Microsemi driver.
> 
> --
> Martin K. Petersen  Oracle Linux Engineering

We would prefer not to do this at this time. We do not know of any other PQI 
drivers that
could take advantage of a PQI library. However we may end up doing this in the 
future.

We hope that this is OK for now.

Thanks,
Don Brace

ESC - Smart Storage
Microsemi Corporation



--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH V4 0/2] smartpqi: initial commit of Microsemi smartpqi driver

[Martin K. Petersen]

> "Don" == Don Brace  writes:

>> Is your interface related to T10 PQI?

Don> We follow it pretty closely with some exceptions: - Our memory BARS
Don> includes both the aacraid SIS and PQI interfaces - We have our own
Don> config table defined.  - We are using our own error data buffer
Don> schema - We are not yet supporting fencing and some other features.

OK. I was just wondering whether it would make sense to have a libpqi
with all the spec-compliant pieces and put the "smart" in a dedicated
Microsemi driver.

-- 
Martin K. Petersen  Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH V4 0/2] smartpqi: initial commit of Microsemi smartpqi driver

[Don Brace]

> -Original Message-
> From: Martin K. Petersen [mailto:martin.peter...@oracle.com]
> Sent: Thursday, August 04, 2016 8:25 PM
> To: Don Brace
> Cc: j...@linux.vnet.ibm.com; Viswas G; Mahesh Rajashekhara;
> h...@infradead.org; Scott Teel; Kevin Barnett; Justin Lindley; Scott Benesh;
> elli...@hpe.com; linux-scsi@vger.kernel.org
> Subject: Re: [PATCH V4 0/2] smartpqi: initial commit of Microsemi smartpqi
> driver
> 
> EXTERNAL EMAIL
> 
> 
> >>>>> "Don" == Don Brace <don.br...@microsemi.com> writes:
> 
> Don,
> 
> Don> This driver is based on Linus's tree This initial commit contains
> Don> WIP of Microsemi's smartpqi module.
> 
> Is your interface related to T10 PQI?
> 
> --
> Martin K. Petersen  Oracle Linux Engineering

We follow it pretty closely with some exceptions:
 - Our memory BARS includes both the aacraid SIS and PQI interfaces
- We have our own config table defined.
- We are using our own error data buffer schema
- We are not yet supporting fencing and some other features.

Thanks,
Don Brace
ESC - Smart Storage
Microsemi Corporation


--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH V4 0/2] smartpqi: initial commit of Microsemi smartpqi driver

[Martin K. Petersen]

> "Don" == Don Brace  writes:

Don,

Don> This driver is based on Linus's tree This initial commit contains
Don> WIP of Microsemi's smartpqi module.

Is your interface related to T10 PQI?

-- 
Martin K. Petersen  Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH V4 0/2] smartpqi: initial commit of Microsemi smartpqi driver

[Don Brace]

This driver is based on Linus's tree

This initial commit contains WIP of Microsemi's smartpqi module.

- add smartpqi to kernel.org
- remove PCI IDs from aacraid driver
  - Depends on adoption of smartpqi driver

Changes since V3
 - removed 'devices' and 'PQI info' sysfs attributes
   according to Hannes's review.
 - changes suggested by Hannes and Johannes Thumshirn:
   - removed statistics
 - fixed issues raised by Johannes Thumshirn
 - answers to other Johannes Thumshirn's review posted in a
   separate reply.

Changes since V2
 - Corrected make ARCH=s390 kbuild test robot issue.
 - Answers to Hannes's Review posted in a separate reply

Changes since V1
 - Corrected make ARCH=i386 kbuild test robot issue.

Changes since initial upload
 - Forgot to give correct ownership to the author.

---

Don Brace (1):
  aacraid: remove wildcard for series 9 controllers

Kevin Barnett (1):
  smartpqi: initial commit of Microsemi smartpqi driver


 MAINTAINERS|   11 
 drivers/scsi/Kconfig   |1 
 drivers/scsi/Makefile  |1 
 drivers/scsi/aacraid/linit.c   |2 
 drivers/scsi/smartpqi/Kconfig  |   50 
 drivers/scsi/smartpqi/Makefile |3 
 drivers/scsi/smartpqi/smartpqi.h   | 1133 
 drivers/scsi/smartpqi/smartpqi_init.c  | 6306 
 drivers/scsi/smartpqi/smartpqi_sas_transport.c |  350 +
 drivers/scsi/smartpqi/smartpqi_sis.c   |  394 +
 drivers/scsi/smartpqi/smartpqi_sis.h   |   32 
 11 files changed, 8281 insertions(+), 2 deletions(-)
 create mode 100644 drivers/scsi/smartpqi/Kconfig
 create mode 100644 drivers/scsi/smartpqi/Makefile
 create mode 100644 drivers/scsi/smartpqi/smartpqi.h
 create mode 100644 drivers/scsi/smartpqi/smartpqi_init.c
 create mode 100644 drivers/scsi/smartpqi/smartpqi_sas_transport.c
 create mode 100644 drivers/scsi/smartpqi/smartpqi_sis.c
 create mode 100644 drivers/scsi/smartpqi/smartpqi_sis.h

--
Signature
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html