Re: [RFC PATCH 0/4] libfc: Do not send ABTS when resetting exchanges

2016-08-18 Thread Martin K. Petersen
> "Hannes" == Hannes Reinecke  writes:

Hannes> Hi all, here's a patchset to fixup an issue reported by QLogic:
Hannes> when running against a certain target the libfc stack would get
Hannes> in an infinite loop sending ABTS when trying to reset a
Hannes> connection.  The problem is that the libfc stack is sending ABTS
Hannes> for any open exchanges when removing an rport, totally ignorant
Hannes> of the fact that in most cases we are already logged out of the
Hannes> said remote port.  This patchset alters the handling slightly so
Hannes> that we will only ever reset open exchanges after we have either
Hannes> logged out of the port or an implicit logout can be assumed.
Hannes> With that we don't need to send ABTS any more during rport
Hannes> reset.

Applied to 4.9/scsi-queue. I had to do patch 2 by hand. Please check.

-- 
Martin K. Petersen  Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [RFC PATCH 0/4] libfc: Do not send ABTS when resetting exchanges

2016-08-18 Thread Chad Dupuis

On Fri, 5 Aug 2016, 12:54pm -, Hannes Reinecke wrote:

> Hi all,
> 
> here's a patchset to fixup an issue reported by QLogic: when running
> against a certain target the libfc stack would get in an infinite loop
> sending ABTS when trying to reset a connection.
> The problem is that the libfc stack is sending ABTS for any open exchanges
> when removing an rport, totally ignorant of the fact that in most cases
> we are already logged out of the said remote port.
> This patchset alters the handling slightly so that we will only ever reset
> open exchanges after we have either logged out of the port or an implicit
> logout can be assumed.
> With that we don't need to send ABTS any more during rport reset.
> 
> As usual, comments and reviews are welcome.
> 
> Hannes Reinecke (4):
>   libfc: Issue PRLI after a PRLO has been received
>   libfc: send LOGO for PLOGI failure
>   libfc: reset exchange manager during LOGO handling
>   libfc: do not send ABTS when resetting exchanges
> 
>  drivers/scsi/libfc/fc_exch.c  |  1 -
>  drivers/scsi/libfc/fc_rport.c | 26 +++---
>  2 files changed, 23 insertions(+), 4 deletions(-)
> 
> 

Hannes, thanks for posting this.  I've been working witih a customer of 
ours and have successfully tested this patch set.

Reviewed-by: Chad Dupuis 
Tested-by: Chad Dupuis 
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[RFC PATCH 0/4] libfc: Do not send ABTS when resetting exchanges

2016-08-05 Thread Hannes Reinecke
Hi all,

here's a patchset to fixup an issue reported by QLogic: when running
against a certain target the libfc stack would get in an infinite loop
sending ABTS when trying to reset a connection.
The problem is that the libfc stack is sending ABTS for any open exchanges
when removing an rport, totally ignorant of the fact that in most cases
we are already logged out of the said remote port.
This patchset alters the handling slightly so that we will only ever reset
open exchanges after we have either logged out of the port or an implicit
logout can be assumed.
With that we don't need to send ABTS any more during rport reset.

As usual, comments and reviews are welcome.

Hannes Reinecke (4):
  libfc: Issue PRLI after a PRLO has been received
  libfc: send LOGO for PLOGI failure
  libfc: reset exchange manager during LOGO handling
  libfc: do not send ABTS when resetting exchanges

 drivers/scsi/libfc/fc_exch.c  |  1 -
 drivers/scsi/libfc/fc_rport.c | 26 +++---
 2 files changed, 23 insertions(+), 4 deletions(-)

-- 
1.8.5.6

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html