RE: [PATCH] dpt_i2o: convert to SCSI hotplug model

2007-07-31 Thread Salyzyn, Mark 
ACK!

Sincerely -- Mark Salyzyn

 -Original Message-
 From: Matthew Wilcox [mailto:[EMAIL PROTECTED] 
 Sent: Monday, July 30, 2007 5:19 PM
 To: AACRAID; linux-scsi@vger.kernel.org
 Subject: [PATCH] dpt_i2o: convert to SCSI hotplug model
  
 dpt_i2o: Convert to new SCSI driver model
 
  - Delete refereces to HOSTS_C
  - Switch to module_init/module_exit instead of detect/release
  - Don't pass around the host template and rename it to adpt_template
  - Switch from scsi_register/scsi_unregister to scsi_host_alloc,
scsi_add_host, scsi_scan_host and scsi_host_put.
-
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] dpt_i2o: convert to SCSI hotplug model

2007-07-30 Thread Christoph Hellwig 
On Mon, Jul 30, 2007 at 03:19:18PM -0600, Matthew Wilcox wrote:
 dpt_i2o: Convert to new SCSI driver model
 
  - Delete refereces to HOSTS_C
  - Switch to module_init/module_exit instead of detect/release
  - Don't pass around the host template and rename it to adpt_template
  - Switch from scsi_register/scsi_unregister to scsi_host_alloc,
scsi_add_host, scsi_scan_host and scsi_host_put.

Looks fine to me except that I'd prefer to see adpt_detect merged into
adpt_init even if that means moving some code around and the cleanup
in the init path might better be just opencoded than re-using adpt_exit
especiall if that one's going to get a little more complicated later on.

-
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] dpt_i2o: convert to SCSI hotplug model

2007-07-30 Thread Jeff Garzik 

Matthew Wilcox wrote:

dpt_i2o: Convert to new SCSI driver model

 - Delete refereces to HOSTS_C
 - Switch to module_init/module_exit instead of detect/release
 - Don't pass around the host template and rename it to adpt_template
 - Switch from scsi_register/scsi_unregister to scsi_host_alloc,
   scsi_add_host, scsi_scan_host and scsi_host_put.


ACK.

I like the minimal nature of this patch.  I hope that any unrelated 
cleanups go into separate patches, following this one.


-
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html