RE: [PATCH] target: Fix incorrect unmap_zeroes_data_store return

[Pocas, Jamie]

Sorry about this. I am working on an older 3.10 codebase (RHEL7.x) where the 
equivalent function int se_dev_set_unmap_zeroes_data(struct se_device *dev, int 
flag) does and SHOULD return 0. There are apparently more changes between 
configfs in 3.10 and latest than I found. That one slipped by when I ported it 
up to latest. Good catch!

-Original Message-
From: Nicholas A. Bellinger [mailto:n...@daterainc.com] 
Sent: Thursday, February 11, 2016 2:02 AM
To: target-devel; linux-scsi
Cc: Christoph Hellwig; Pocas, Jamie; Nicholas Bellinger
Subject: [PATCH] target: Fix incorrect unmap_zeroes_data_store return

From: Nicholas Bellinger 

This patch fixes an incorrect return of zero from the new
unmap_zeroes_data_store() configfs store attribute handler introduced in 
v4.5-rc1, to use the correct 'count' bytes return value.

Signed-off-by: Nicholas Bellinger 
---
 drivers/target/target_core_configfs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/target/target_core_configfs.c 
b/drivers/target/target_core_configfs.c
index 3327c49..713c63d9 100644
--- a/drivers/target/target_core_configfs.c
+++ b/drivers/target/target_core_configfs.c
@@ -898,7 +898,7 @@ static ssize_t unmap_zeroes_data_store(struct config_item 
*item,
da->unmap_zeroes_data = flag;
pr_debug("dev[%p]: SE Device Thin Provisioning LBPRZ bit: %d\n",
 da->da_dev, flag);
-   return 0;
+   return count;
 }
 
 /*
--
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] target: Fix incorrect unmap_zeroes_data_store return

[Sagi Grimberg]

Looks good,

Reviewed-by: Sagi Grimberg 
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html