RE: [PATCH 1/1] storvsc: Don't set the SRB_FLAGS_QUEUE_ACTION_ENABLE flag

2015-10-05 Thread KY Srinivasan 


> -Original Message-
> From: James Bottomley [mailto:james.bottom...@hansenpartnership.com]
> Sent: Monday, August 31, 2015 7:02 AM
> To: KY Srinivasan 
> Cc: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org;
> de...@linuxdriverproject.org; oher...@suse.com;
> jbottom...@parallels.com; h...@infradead.org; linux-scsi@vger.kernel.org;
> a...@canonical.com; vkuzn...@redhat.com; jasow...@redhat.com;
> sta...@vger.kernel.org
> Subject: Re: [PATCH 1/1] storvsc: Don't set the
> SRB_FLAGS_QUEUE_ACTION_ENABLE flag
> 
> On Mon, 2015-08-31 at 08:21 -0700, K. Y. Srinivasan wrote:
> > Don't set the SRB_FLAGS_QUEUE_ACTION_ENABLE flag since we are not
> specifying
> > tags.
> 
> What's the actual problem description this causes?

James,

Should I resend this patch. I think I provided the clarification you had sought.

Regards,

K. Y
> 
> James
> 
> 
> > Signed-off-by: K. Y. Srinivasan 
> > Cc: sta...@vger.kernel.org
> > ---
> >  drivers/scsi/storvsc_drv.c |3 +--
> >  1 files changed, 1 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c
> > index 40c43ae..ad8c4bc 100644
> > --- a/drivers/scsi/storvsc_drv.c
> > +++ b/drivers/scsi/storvsc_drv.c
> > @@ -1647,8 +1647,7 @@ static int storvsc_queuecommand(struct
> Scsi_Host *host, struct scsi_cmnd *scmnd)
> > vm_srb->win8_extension.time_out_value = 60;
> >
> > vm_srb->win8_extension.srb_flags |=
> > -   (SRB_FLAGS_QUEUE_ACTION_ENABLE |
> > -   SRB_FLAGS_DISABLE_SYNCH_TRANSFER);
> > +   SRB_FLAGS_DISABLE_SYNCH_TRANSFER;
> >
> > /* Build the SRB */
> > switch (scmnd->sc_data_direction) {
> 
> 

N�r��yb�X��ǧv�^�)޺{.n�+{���"�{ay�ʇڙ�,j��f���h���z��w���
���j:+v���w�j�mzZ+�ݢj"��!�i

RE: [PATCH 1/1] storvsc: Don't set the SRB_FLAGS_QUEUE_ACTION_ENABLE flag

2015-08-31 Thread KY Srinivasan 


> -Original Message-
> From: James Bottomley [mailto:james.bottom...@hansenpartnership.com]
> Sent: Monday, August 31, 2015 7:02 AM
> To: KY Srinivasan 
> Cc: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org;
> de...@linuxdriverproject.org; oher...@suse.com;
> jbottom...@parallels.com; h...@infradead.org; linux-scsi@vger.kernel.org;
> a...@canonical.com; vkuzn...@redhat.com; jasow...@redhat.com;
> sta...@vger.kernel.org
> Subject: Re: [PATCH 1/1] storvsc: Don't set the
> SRB_FLAGS_QUEUE_ACTION_ENABLE flag
> 
> On Mon, 2015-08-31 at 08:21 -0700, K. Y. Srinivasan wrote:
> > Don't set the SRB_FLAGS_QUEUE_ACTION_ENABLE flag since we are not
> specifying
> > tags.
> 
> What's the actual problem description this causes?
Qlogic driver does not work correctly if the SRB_FLAGS_QUEUE_ACTION_ENABLE
is set and no action tag is specified.

Regards,

K. Y

> 
> James
> 
> 
> > Signed-off-by: K. Y. Srinivasan 
> > Cc: sta...@vger.kernel.org
> > ---
> >  drivers/scsi/storvsc_drv.c |3 +--
> >  1 files changed, 1 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c
> > index 40c43ae..ad8c4bc 100644
> > --- a/drivers/scsi/storvsc_drv.c
> > +++ b/drivers/scsi/storvsc_drv.c
> > @@ -1647,8 +1647,7 @@ static int storvsc_queuecommand(struct
> Scsi_Host *host, struct scsi_cmnd *scmnd)
> > vm_srb->win8_extension.time_out_value = 60;
> >
> > vm_srb->win8_extension.srb_flags |=
> > -   (SRB_FLAGS_QUEUE_ACTION_ENABLE |
> > -   SRB_FLAGS_DISABLE_SYNCH_TRANSFER);
> > +   SRB_FLAGS_DISABLE_SYNCH_TRANSFER;
> >
> > /* Build the SRB */
> > switch (scmnd->sc_data_direction) {
> 
> 

N�r��yb�X��ǧv�^�)޺{.n�+{���"�{ay�ʇڙ�,j��f���h���z��w���
���j:+v���w�j�mzZ+�ݢj"��!�i

Re: [PATCH 1/1] storvsc: Don't set the SRB_FLAGS_QUEUE_ACTION_ENABLE flag

2015-08-31 Thread James Bottomley 
On Mon, 2015-08-31 at 08:21 -0700, K. Y. Srinivasan wrote:
> Don't set the SRB_FLAGS_QUEUE_ACTION_ENABLE flag since we are not specifying
> tags.

What's the actual problem description this causes?

James


> Signed-off-by: K. Y. Srinivasan 
> Cc: sta...@vger.kernel.org
> ---
>  drivers/scsi/storvsc_drv.c |3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c
> index 40c43ae..ad8c4bc 100644
> --- a/drivers/scsi/storvsc_drv.c
> +++ b/drivers/scsi/storvsc_drv.c
> @@ -1647,8 +1647,7 @@ static int storvsc_queuecommand(struct Scsi_Host *host, 
> struct scsi_cmnd *scmnd)
>   vm_srb->win8_extension.time_out_value = 60;
>  
>   vm_srb->win8_extension.srb_flags |=
> - (SRB_FLAGS_QUEUE_ACTION_ENABLE |
> - SRB_FLAGS_DISABLE_SYNCH_TRANSFER);
> + SRB_FLAGS_DISABLE_SYNCH_TRANSFER;
>  
>   /* Build the SRB */
>   switch (scmnd->sc_data_direction) {



--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html