Re: [PATCH v2 22/30] scsi: aacraid: Merge adapter setup with resolve luns
Raghava Aditya Renukunta writes: > Hi Nikola, > >> -Original Message- >> From: Nikola Pajkovsky [mailto:npajkov...@suse.cz] >> Sent: Wednesday, January 3, 2018 2:02 AM >> To: Raghava Aditya Renukunta >> >> Cc: j...@linux.vnet.ibm.com; martin.peter...@oracle.com; linux- >> s...@vger.kernel.org; Scott Benesh ; Tom >> White ; dl-esc-Aacraid Linux Driver >> ; Guilherme G . Piccoli >> ; Bart Van Assche >> >> Subject: Re: [PATCH v2 22/30] scsi: aacraid: Merge adapter setup with resolve >> luns >> >> EXTERNAL EMAIL >> >> >> Raghava Aditya Renukunta >> writes: >> >> > The device hotplug events are processed only after retrieving the updated >> > lun information from the fw. Does not make sense to keep them separate. >> > >> > Merge both the hotplug handling and safw adapter setup code into single >> > function. >> > >> > Signed-off-by: Raghava Aditya Renukunta >> >> >> According to subsequent commit >> >> [PATCH v2 23/30] scsi: aacraid: Block concurrent hotplug event handling >> >> this commit is racy, because 23/30 adds ->scan_mutex. Shouldn't be these >> commits squashed? > > I tried to make the patches as logically distinct as possible, maybe I > got a bit too ambitious and I expected the patches to go thru as a set so > I don’t think it would make any difference. What do you think? It does make difference, when you start cherry-picking patches to downstream kernel. However, I don't have strong opinion here, so it can stay as is. -- Nikola
RE: [PATCH v2 22/30] scsi: aacraid: Merge adapter setup with resolve luns
Hi Nikola, > -Original Message- > From: Nikola Pajkovsky [mailto:npajkov...@suse.cz] > Sent: Wednesday, January 3, 2018 2:02 AM > To: Raghava Aditya Renukunta > > Cc: j...@linux.vnet.ibm.com; martin.peter...@oracle.com; linux- > s...@vger.kernel.org; Scott Benesh ; Tom > White ; dl-esc-Aacraid Linux Driver > ; Guilherme G . Piccoli > ; Bart Van Assche > > Subject: Re: [PATCH v2 22/30] scsi: aacraid: Merge adapter setup with resolve > luns > > EXTERNAL EMAIL > > > Raghava Aditya Renukunta > writes: > > > The device hotplug events are processed only after retrieving the updated > > lun information from the fw. Does not make sense to keep them separate. > > > > Merge both the hotplug handling and safw adapter setup code into single > > function. > > > > Signed-off-by: Raghava Aditya Renukunta > > > According to subsequent commit > > [PATCH v2 23/30] scsi: aacraid: Block concurrent hotplug event handling > > this commit is racy, because 23/30 adds ->scan_mutex. Shouldn't be these > commits squashed? I tried to make the patches as logically distinct as possible, maybe I got a bit too ambitious and I expected the patches to go thru as a set so I don’t think it would make any difference. What do you think? Thanks Raghava Aditya > -- > Nikola
Re: [PATCH v2 22/30] scsi: aacraid: Merge adapter setup with resolve luns
Raghava Aditya Renukunta writes: > The device hotplug events are processed only after retrieving the updated > lun information from the fw. Does not make sense to keep them separate. > > Merge both the hotplug handling and safw adapter setup code into single > function. > > Signed-off-by: Raghava Aditya Renukunta > According to subsequent commit [PATCH v2 23/30] scsi: aacraid: Block concurrent hotplug event handling this commit is racy, because 23/30 adds ->scan_mutex. Shouldn't be these commits squashed? -- Nikola