Re: [PATCH 0/5] fix iommu sg list merge problem
On Wed, 26 Sep 2007 09:38:32 -0500 James Bottomley <[EMAIL PROTECTED]> wrote: > On Wed, 2007-09-26 at 23:34 +0900, FUJITA Tomonori wrote: > > Yeah, I thought about it and it's possible (but not so easy). parisc > > has IOMMU merging helper code and two parisc IOMMUs use it. ia64 > > sba_iommu is almost identical to parisc code. x86_64 gart, power, and > > alpha do in their own way. But I think that we can merging helper code > > useful for all. > > Er ... it should be identical ... the SBA iommu is the same ... I > thought we moved the common code out to a shared file. 2.6.23-rc8-mm1 has two iommu_coalesce_chunks in drivers/iommu-helpers.h and arch/ioa64/hp/common/sb_iommu.c iommu_coalesce_chunks are almost same. parisc's iommu_coalesce_chunks is simpler a bit. - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/5] fix iommu sg list merge problem
On Wed, 26 Sep 2007 12:02:21 +0200 Muli Ben-Yehuda <[EMAIL PROTECTED]> wrote: > On Wed, Sep 26, 2007 at 05:57:57PM +0900, FUJITA Tomonori wrote: > > > iommu code merges sg lists without considering lld's restrictions so > > some llds need a workaround to split sg lists again. This patchset > > fixes iommu to handle lld's max segment size limit properly. > > The patches look reasonable to me. > > > This patchset includes only the x86_64 iommu patch > > There are multiple x86-64 IOMMUs, but only GART is in-tree and > supports merging. > > > but my git tree includes x86_64, ppc, ia64, parisc, and alpha > > patches. As far as I know, thye are all the iommu code that merges > > sg lists. The iommu patchse are only compile tested. > > > > > > git://git.kernel.org/pub/scm/linux/kernel/git/tomo/linux-2.6-bidi.git iommu > > Do you think it will be possible to abstract the merging code into > common code, rather than duplicating it for every IOMMU? Yeah, I thought about it and it's possible (but not so easy). parisc has IOMMU merging helper code and two parisc IOMMUs use it. ia64 sba_iommu is almost identical to parisc code. x86_64 gart, power, and alpha do in their own way. But I think that we can merging helper code useful for all. I'll see what we can have after fixing the mering problem. - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/5] fix iommu sg list merge problem
On Wed, 2007-09-26 at 23:34 +0900, FUJITA Tomonori wrote: > Yeah, I thought about it and it's possible (but not so easy). parisc > has IOMMU merging helper code and two parisc IOMMUs use it. ia64 > sba_iommu is almost identical to parisc code. x86_64 gart, power, and > alpha do in their own way. But I think that we can merging helper code > useful for all. Er ... it should be identical ... the SBA iommu is the same ... I thought we moved the common code out to a shared file. James - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/5] fix iommu sg list merge problem
On Wed, Sep 26, 2007 at 05:57:57PM +0900, FUJITA Tomonori wrote: > iommu code merges sg lists without considering lld's restrictions so > some llds need a workaround to split sg lists again. This patchset > fixes iommu to handle lld's max segment size limit properly. The patches look reasonable to me. > This patchset includes only the x86_64 iommu patch There are multiple x86-64 IOMMUs, but only GART is in-tree and supports merging. > but my git tree includes x86_64, ppc, ia64, parisc, and alpha > patches. As far as I know, thye are all the iommu code that merges > sg lists. The iommu patchse are only compile tested. > > > git://git.kernel.org/pub/scm/linux/kernel/git/tomo/linux-2.6-bidi.git iommu Do you think it will be possible to abstract the merging code into common code, rather than duplicating it for every IOMMU? Cheers, Muli - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
